Skip to content

Commit cd10f72

Browse files
committed
updates and cleanup
-included toolkit in SparkFun_Qwiic_Buzzer_Arduino_Library.h -Changed I2C constructor from () to {} -changeAddress is now setAddress -function order now the same between header and source files.
1 parent 514df20 commit cd10f72

File tree

5 files changed

+49
-48
lines changed

5 files changed

+49
-48
lines changed

examples/Example_05_ChangeI2CAddress/Example_05_ChangeI2CAddress.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void setup() {
5555
Serial.print("Attempting to set device address to 0x");
5656
Serial.println(newAddress, HEX);
5757

58-
if (buzzer.changeAddress(newAddress) == true) {
58+
if (buzzer.setAddress(newAddress) == true) {
5959
Serial.println("Device address set succeeded!");
6060
}
6161

keywords.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ QwiicBuzzer KEYWORD1
1212

1313
begin KEYWORD2
1414
isConnected KEYWORD2
15-
changeAddress KEYWORD2
15+
setAddress KEYWORD2
1616
getAddress KEYWORD2
1717
buzzerConfig KEYWORD2
1818
off KEYWORD2

src/SparkFun_Qwiic_Buzzer_Arduino_Library.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#pragma once
2727

28+
#include <SparkFun_Toolkit.h>
2829
#include "sfeQwiicBuzzer.h"
2930

3031
class QwiicBuzzer : public sfeQwiicBuzzerArdI2C

src/sfeQwiicBuzzer.cpp

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -42,32 +42,6 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::isConnected()
4242
return _theBus->ping();
4343
}
4444

45-
sfeTkError_t sfeQwiicBuzzerArdI2C::changeAddress(const uint8_t &address)
46-
{
47-
if (address < 0x08 || address > 0x77)
48-
{
49-
Serial.println("Address out of legal range");
50-
return kSTkErrFail; //error immediately if the address is out of legal range
51-
}
52-
53-
sfeTkError_t err = _theBus->writeRegisterByte(kSfeQwiicBuzzerRegI2cAddress, address);
54-
55-
// Check whether the write was successful
56-
if (err != kSTkErrOk)
57-
return err;
58-
59-
// Update the address in the bus
60-
_theBus->setAddress(address);
61-
62-
// Done!
63-
return kSTkErrOk;
64-
}
65-
66-
uint8_t sfeQwiicBuzzerArdI2C::getAddress()
67-
{
68-
return _theBus->address();
69-
}
70-
7145
sfeTkError_t sfeQwiicBuzzerArdI2C::buzzerConfig(uint16_t toneFrequency, uint16_t duration, uint8_t volume)
7246
{
7347
// All of the necessary configuration register address are in sequencial order
@@ -99,16 +73,6 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::buzzerConfig(uint16_t toneFrequency, uint16_t
9973
return _theBus->writeRegisterRegion(kSfeQwiicBuzzerRegToneFrequencyMsb, data, dataLength);
10074
}
10175

102-
sfeTkError_t sfeQwiicBuzzerArdI2C::setBuzzerActiveReg()
103-
{
104-
return _theBus->writeRegisterByte(kSfeQwiicBuzzerRegActive, 0x01);
105-
}
106-
107-
sfeTkError_t sfeQwiicBuzzerArdI2C::clearBuzzerActiveReg()
108-
{
109-
return _theBus->writeRegisterByte(kSfeQwiicBuzzerRegActive, 0x00);
110-
}
111-
11276
sfeTkError_t sfeQwiicBuzzerArdI2C::on(uint16_t toneFrequency, uint16_t duration, uint8_t volume)
11377
{
11478
sfeTkError_t err = buzzerConfig(toneFrequency, duration, volume);
@@ -128,6 +92,42 @@ sfeTkError_t sfeQwiicBuzzerArdI2C::saveSettings()
12892
return _theBus->writeRegisterByte(kSfeQwiicBuzzerRegSaveSettings, 0x01);
12993
}
13094

95+
sfeTkError_t sfeQwiicBuzzerArdI2C::setBuzzerActiveReg()
96+
{
97+
return _theBus->writeRegisterByte(kSfeQwiicBuzzerRegActive, 0x01);
98+
}
99+
100+
sfeTkError_t sfeQwiicBuzzerArdI2C::clearBuzzerActiveReg()
101+
{
102+
return _theBus->writeRegisterByte(kSfeQwiicBuzzerRegActive, 0x00);
103+
}
104+
105+
sfeTkError_t sfeQwiicBuzzerArdI2C::setAddress(const uint8_t &address)
106+
{
107+
if (address < 0x08 || address > 0x77)
108+
{
109+
Serial.println("Address out of legal range");
110+
return kSTkErrFail; //error immediately if the address is out of legal range
111+
}
112+
113+
sfeTkError_t err = _theBus->writeRegisterByte(kSfeQwiicBuzzerRegI2cAddress, address);
114+
115+
// Check whether the write was successful
116+
if (err != kSTkErrOk)
117+
return err;
118+
119+
// Update the address in the bus
120+
_theBus->setAddress(address);
121+
122+
// Done!
123+
return kSTkErrOk;
124+
}
125+
126+
uint8_t sfeQwiicBuzzerArdI2C::getAddress()
127+
{
128+
return _theBus->address();
129+
}
130+
131131
/*------------------------- Sound Effects ---------------- */
132132

133133
void sfeQwiicBuzzerArdI2C::playSoundEffect(uint8_t soundEffectNumber, uint8_t volume)

src/sfeQwiicBuzzer.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class sfeQwiicBuzzerArdI2C
3737
{
3838
public:
3939
/// @brief Default constructor
40-
sfeQwiicBuzzerArdI2C() : _theBus(nullptr)
40+
sfeQwiicBuzzerArdI2C() : _theBus{nullptr}
4141
{
4242
}
4343

@@ -80,6 +80,15 @@ class sfeQwiicBuzzerArdI2C
8080
/// @return 0 for succuss, negative for errors, positive for warnings
8181
sfeTkError_t clearBuzzerActiveReg();
8282

83+
/// @brief Changes the I2C address of the Qwiic Buzzer
84+
/// @param address New address, must be in the range 0x20 to 0x2F
85+
/// @return 0 for succuss, negative for errors, positive for warnings
86+
sfeTkError_t setAddress(const uint8_t &address);
87+
88+
/// @brief Gets the current I2C address of the Qwiic Buzzer
89+
/// @return The current I2C address, 7-bit unshifted
90+
uint8_t getAddress();
91+
8392
/// @brief Plays one of the sound effects included in this library
8493
/// @param soundEffectNumber The sound effect you with to play
8594
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
@@ -125,15 +134,6 @@ class sfeQwiicBuzzerArdI2C
125134
/// @param volume Volume (4 settings; 0=off, 1=quiet... 4=loudest)
126135
void soundEffect9(uint8_t volume);
127136

128-
/// @brief Changes the I2C address of the Qwiic Buzzer
129-
/// @param address New address, must be in the range 0x20 to 0x2F
130-
/// @return 0 for succuss, negative for errors, positive for warnings
131-
sfeTkError_t changeAddress(const uint8_t &address);
132-
133-
/// @brief Gets the current I2C address of the Qwiic Buzzer
134-
/// @return The current I2C address, 7-bit unshifted
135-
uint8_t getAddress();
136-
137137
protected:
138138
sfeTkII2C *_theBus;
139139
};

0 commit comments

Comments
 (0)