Clean up some warnings

Author: PaulZC

Firmware/RTK_Everywhere/Display.ino

@@ -1992,7 +1992,7 @@ void paintIPAddress()
     char ipAddress[16];
     snprintf(ipAddress, sizeof(ipAddress), "%s",
 #ifdef COMPILE_ETHERNET
-             ETH.localIP().toString());
+             ETH.localIP().toString().c_str());
 #else  // COMPILE_ETHERNET
              "0.0.0.0");
 #endif // COMPILE_ETHERNET
@@ -2052,7 +2052,7 @@ void displayFullIPAddress(std::vector<iconPropertyBlinking> *iconList) // Bottom
             // Display the IP address when it is available
             if (ipAddress != IPAddress((uint32_t)0))
             {
-                snprintf(myAddress, sizeof(myAddress), "%s", ipAddress.toString());
+                snprintf(myAddress, sizeof(myAddress), "%s", ipAddress.toString().c_str());
 
                 oled->setFont(QW_FONT_5X7); // Set font to smallest
                 oled->setCursor(0, 55);

Firmware/RTK_Everywhere/NTP.ino

@@ -609,7 +609,7 @@ bool ntpProcessOneRequest(bool process, const timeval *recTv, const timeval *syn
             if (ntpDiag != nullptr)
             {
                 char tmpbuf[128];
-                snprintf(tmpbuf, sizeof(tmpbuf), "Originate Timestamp (Client Transmit): %u.%06u\r\n",
+                snprintf(tmpbuf, sizeof(tmpbuf), "Originate Timestamp (Client Transmit): %lu.%06lu\r\n",
                          packet.transmitTimestampSeconds,
                          packet.convertFractionToMicros(packet.transmitTimestampFraction));
                 strlcat(ntpDiag, tmpbuf, ntpDiagSize);
@@ -631,7 +631,7 @@ bool ntpProcessOneRequest(bool process, const timeval *recTv, const timeval *syn
             if (ntpDiag != nullptr)
             {
                 char tmpbuf[128];
-                snprintf(tmpbuf, sizeof(tmpbuf), "Received Timestamp:                    %u.%06u\r\n",
+                snprintf(tmpbuf, sizeof(tmpbuf), "Received Timestamp:                    %lu.%06lu\r\n",
                          packet.receiveTimestampSeconds,
                          packet.convertFractionToMicros(packet.receiveTimestampFraction));
                 strlcat(ntpDiag, tmpbuf, ntpDiagSize);
@@ -649,7 +649,7 @@ bool ntpProcessOneRequest(bool process, const timeval *recTv, const timeval *syn
             if (ntpDiag != nullptr)
             {
                 char tmpbuf[128];
-                snprintf(tmpbuf, sizeof(tmpbuf), "Reference Timestamp (Last Sync):       %u.%06u\r\n",
+                snprintf(tmpbuf, sizeof(tmpbuf), "Reference Timestamp (Last Sync):       %lu.%06lu\r\n",
                          packet.referenceTimestampSeconds,
                          packet.convertFractionToMicros(packet.referenceTimestampFraction));
                 strlcat(ntpDiag, tmpbuf, ntpDiagSize);
@@ -677,7 +677,7 @@ bool ntpProcessOneRequest(bool process, const timeval *recTv, const timeval *syn
             if (ntpDiag != nullptr)
             {
                 char tmpbuf[128];
-                snprintf(tmpbuf, sizeof(tmpbuf), "Transmit Timestamp:                    %u.%06u\r\n",
+                snprintf(tmpbuf, sizeof(tmpbuf), "Transmit Timestamp:                    %lu.%06lu\r\n",
                          packet.transmitTimestampSeconds,
                          packet.convertFractionToMicros(packet.transmitTimestampFraction));
                 strlcat(ntpDiag, tmpbuf, ntpDiagSize);

Firmware/RTK_Everywhere/NVM.ino

@@ -279,7 +279,7 @@ void recordSystemSettingsToFile(File *settingsFile)
         break;
         case _uint32_t: {
             uint32_t *ptr = (uint32_t *)rtkSettingsEntries[i].var;
-            settingsFile->printf("%s=%d\r\n", rtkSettingsEntries[i].name, *ptr);
+            settingsFile->printf("%s=%lu\r\n", rtkSettingsEntries[i].name, *ptr);
         }
         break;
         case _uint64_t: {

Firmware/RTK_Everywhere/States.ino

@@ -683,6 +683,7 @@ const char *getState(SystemState state, char *buffer)
         return "STATE_DISPLAY_SETUP";
     case (STATE_WEB_CONFIG_NOT_STARTED):
         return "STATE_WEB_CONFIG_NOT_STARTED";
+    case (STATE_WEB_CONFIG_WAIT_FOR_NETWORK):
     case (STATE_WEB_CONFIG):
         return "STATE_WEB_CONFIG";
     case (STATE_TEST):

Firmware/RTK_Everywhere/Tasks.ino

@@ -1645,7 +1645,7 @@ void handleGnssDataTask(void *e)
                                 // Record trigger count with Time Of Week of rising edge (ms), Millisecond fraction of Time Of Week of
                                 // rising edge (ns), and accuracy estimate (ns)
                                 char eventData[82]; // Max NMEA sentence length is 82
-                                snprintf(eventData, sizeof(eventData), "%d,%d,%d,%d", triggerCount, triggerTowMsR, triggerTowSubMsR,
+                                snprintf(eventData, sizeof(eventData), "%lu,%lu,%lu,%lu", triggerCount, triggerTowMsR, triggerTowSubMsR,
                                         triggerAccEst);
 
                                 char nmeaMessage[82]; // Max NMEA sentence length is 82

Firmware/RTK_Everywhere/menuCommands.ino

@@ -2438,7 +2438,7 @@ void stringRecord(char *settingsCSV, const char *id, int settingValue)
 void stringRecord(char *settingsCSV, const char *id, uint32_t settingValue)
 {
     char record[100];
-    snprintf(record, sizeof(record), "%s,%d,", id, settingValue);
+    snprintf(record, sizeof(record), "%s,%lu,", id, settingValue);
     strcat(settingsCSV, record);
 }
 
@@ -4129,7 +4129,7 @@ void printAvailableSettings()
 
             // Convert int to string
             char batteryChargingPercentStr[3] = {0}; // 45
-            snprintf(batteryChargingPercentStr, sizeof(batteryChargingPercentStr), "%0.0f", batteryChargingPercentStr);
+            snprintf(batteryChargingPercentStr, sizeof(batteryChargingPercentStr), "%0.0f", batteryChargingPercentPerHour);
 
             // Create the settingType based on the length of the firmware version
             char settingType[100];