fixes and made read/write region virtual

Author: gigapod

src/sfeTk/sfeTkISPI.h

@@ -30,10 +30,13 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 class sfeTkSPI : public sfeTkIBus
 {
   public:
-    sfeTkI2C() : _csPin{kNoCSPin}
+    sfeTkSPI() : _cs{kNoCSPin}
     {
     }
 
+    sfeTkSPI(uint8_t csPin) : _cs{csPin}
+    {
+    }
     /// @brief setter for the CS Pin
     ///
     /// @param devCS The device's CS Pin

src/sfeTkArdI2C.cpp

@@ -125,7 +125,7 @@ bool sfeTkArdI2C::writeRegisterWord(uint8_t devReg, uint16_t dataToWrite)
 //
 // Returns the number of bytes written, < 0 is an error
 //
-int sfeTkArdI2C::writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length)
+virtual int sfeTkArdI2C::writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length)
 {
     if (!_i2cPort)
         return -1;
@@ -192,7 +192,7 @@ bool sfeTkArdI2C::readRegisterWord(uint8_t devReg, uint16_t &dataToRead)
 //
 // Returns the number of bytes read, < 0 is an error
 //
-int sfeTkArdI2C::readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes)
+virtual int sfeTkArdI2C::readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes)
 {
     // got port
     if (!_i2cPort)

src/sfeTkArdI2C.h

@@ -86,13 +86,14 @@ class sfeTkArdI2C : public sfeTkII2C
 
     /// @brief Writes a number of bytes starting at the given register's address.
     /// @note sfeTkIBus interface method
+    /// @note This method is virtual to allow it to be overridden to support a device that requires a unique impl
     ///
     /// @param devReg The device's register's address.
     /// @param data Data to write.
     ///
     /// @retval returns number of bytes written, < 0 is an error code
     ///
-    int writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length);
+    virtual int writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length);
 
     /// @brief Reads a byte of data from the given register.
     /// @note sfeTkIBus interface method
@@ -116,13 +117,14 @@ class sfeTkArdI2C : public sfeTkII2C
 
     /// @brief Reads a block of data from the given register.
     /// @note sfeTkIBus interface method
+    /// @note This method is virtual to allow it to be overridden to support a device that requires a unique impl
     ///
     /// @param devReg The device's register's address.
     /// @param data Data to write.
     ///
     /// @retval 0 on success, < 0 on error - see error code
     ///
-    int readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes);
+    virtual int readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes);
 
   private:
     // The actual Arduino i2c port

src/sfeTkArdSPI.cpp

@@ -128,7 +128,7 @@ bool sfeTkBusSPI::writeRegisterWord(uint8_t devReg, uint8_t dataToWrite)
 //
 // Returns the number of bytes written, < 0 is an error
 //
-int sfeTkBusSPI::writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length)
+virtual int sfeTkBusSPI::writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length)
 {
     if (!_spiPort)
         return -1;
@@ -166,7 +166,7 @@ bool sfeTkBusSPI::readRegisterWord(uint8_t devReg, uint16_t &data)
 //
 // Returns the number of bytes read, < 0 is an error
 //
-int sfeTkBusSPI::readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes)
+virtual int sfeTkBusSPI::readRegisterRegion(uint8_t devReg, uint8_t *data, uint16_t numBytes)
 {
     if (!_spiPort)
         return -1;

src/sfeTkArdSPI.h

@@ -79,13 +79,14 @@ class sfeTkBusSPI : public sfeTkIBus
     bool writeRegisterWord(uint8_t devReg, uint16_t data);
 
     /// @brief Writes a number of bytes starting at the given register's address.
-    ///
+    /// @note This method is virtual to allow it to be overridden to support a device that requires a unique impl
+    //
     /// @param devReg The device's register's address.
     /// @param data Data to write.
     ///
     /// @retval int - number of bytes written, < 0 = error value
     ///
-    int writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length);
+    virtual int writeRegisterRegion(uint8_t devReg, const uint8_t *data, uint16_t length);
 
     /// @brief Read a single byte from the given register
     ///
@@ -106,13 +107,14 @@ class sfeTkBusSPI : public sfeTkIBus
     bool readRegisterWord(uint8_t devReg, uint16_t &data);
 
     /// @brief Reads a block of data from the given register.
+    /// @note This method is virtual to allow it to be overridden to support a device that requires a unique impl
     ///
     /// @param devReg The device's register's address.
     /// @param data Data to write.
     ///
     /// @retval int returns the number of bytes read, < 0 on error
     ///
-    int readRegisterRegion(uint8_t reg, uint8_t *data, uint16_t numBytes);
+    virtual int readRegisterRegion(uint8_t reg, uint8_t *data, uint16_t numBytes);
 
   private:
     SPIClass *_spiPort;