-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
As far as I can tell from source code there is no memoization of fetched cache value for later cached method calls on the same object. Is it on purpose?
To be honest, this behavior seems to be pretty surprising:
class Foo
include Cacheable
cacheable :bar
def bar
"foo"
end
end
foo = Foo.new
foo.bar # cache read and deserialization
foo.bar # cache read and deserialization
foo.bar # cache read and deserializationContext: recently I saw a Rails app in the wild that cached some ActiveRecord model methods that in turn returned another ActiveRecord objects. And some places got terribly slow due to dozens of repeated calls to retrieve and deserialize which is especially slow and compute-intensive for AR objects, see this blog post for details (and yes, I know that doing so is a bad idea per se). So I had to get rid of cacheable in favor of pure memoization or manual caching with following memoization.
Metadata
Metadata
Assignees
Labels
No labels