Skip to content

Commit b73524c

Browse files
committed
Adapt to API changes in Spring Data for Apache Geode (SDG).
1 parent ba542b1 commit b73524c

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

spring-geode-project/spring-geode-autoconfigure/src/main/java/org/springframework/geode/boot/autoconfigure/ClientSecurityAutoConfiguration.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import org.springframework.core.env.PropertySource;
4242
import org.springframework.data.gemfire.client.ClientCacheFactoryBean;
4343
import org.springframework.data.gemfire.config.annotation.EnableSecurity;
44-
import org.springframework.data.gemfire.config.annotation.support.AutoConfiguredAuthenticationInitializer;
4544
import org.springframework.geode.core.env.VcapPropertySource;
4645
import org.springframework.geode.core.env.support.CloudCacheService;
4746
import org.springframework.geode.core.env.support.User;
@@ -112,11 +111,8 @@ public class ClientSecurityAutoConfiguration {
112111

113112
private static final String POOL_LOCATORS_PROPERTY = "spring.data.gemfire.pool.locators";
114113

115-
private static final String SECURITY_USERNAME_PROPERTY =
116-
AutoConfiguredAuthenticationInitializer.SDG_SECURITY_USERNAME_PROPERTY;
117-
118-
private static final String SECURITY_PASSWORD_PROPERTY =
119-
AutoConfiguredAuthenticationInitializer.SDG_SECURITY_PASSWORD_PROPERTY;
114+
private static final String SECURITY_USERNAME_PROPERTY = "spring.data.gemfire.security.username";
115+
private static final String SECURITY_PASSWORD_PROPERTY = "spring.data.gemfire.security.password";
120116

121117
private static final String SSL_USE_DEFAULT_CONTEXT_PROPERTY =
122118
"spring.data.gemfire.security.ssl.use-default-context";

spring-geode-project/spring-geode/src/main/java/org/springframework/geode/config/annotation/SecurityManagerProxyConfiguration.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717

1818
import java.util.Properties;
1919

20+
import org.apache.geode.cache.Cache;
21+
22+
import org.springframework.context.ApplicationContext;
2023
import org.springframework.context.ApplicationListener;
2124
import org.springframework.context.annotation.Configuration;
2225
import org.springframework.context.event.ContextRefreshedEvent;
@@ -46,9 +49,11 @@ public class SecurityManagerProxyConfiguration implements ApplicationListener<Co
4649
@Override
4750
public void onApplicationEvent(ContextRefreshedEvent event) {
4851

52+
ApplicationContext applicationContext = event.getApplicationContext();
53+
4954
SecurityManagerProxy securityManagerProxy = SecurityManagerProxy.getInstance();
5055

51-
securityManagerProxy.setBeanFactory(event.getApplicationContext().getAutowireCapableBeanFactory());
52-
securityManagerProxy.init(new Properties());
56+
securityManagerProxy.setBeanFactory(applicationContext.getAutowireCapableBeanFactory());
57+
securityManagerProxy.initialize(applicationContext.getBean(Cache.class), new Properties());
5358
}
5459
}

spring-geode-project/spring-geode/src/main/java/org/springframework/geode/security/support/SecurityManagerProxy.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,11 @@ public void destroy() throws Exception {
171171
INSTANCE.set(null);
172172
}
173173

174+
@Override
175+
public void init(Properties props) {
176+
super.init(props);
177+
}
178+
174179
@Override
175180
protected BeanFactory locateBeanFactory() {
176181
return this.beanFactory != null ? this.beanFactory : super.locateBeanFactory();

spring-geode-project/spring-geode/src/test/java/org/springframework/geode/security/support/SecurityManagerProxyIntegrationTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,13 @@
1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.mockito.Mockito.mock;
2020

21-
import org.apache.geode.cache.GemFireCache;
2221
import org.junit.AfterClass;
2322
import org.junit.BeforeClass;
2423
import org.junit.Test;
2524
import org.junit.runner.RunWith;
25+
26+
import org.apache.geode.cache.GemFireCache;
27+
2628
import org.springframework.beans.factory.annotation.Autowired;
2729
import org.springframework.context.annotation.Bean;
2830
import org.springframework.data.gemfire.config.annotation.PeerCacheApplication;
@@ -35,7 +37,7 @@
3537
import org.springframework.test.context.junit4.SpringRunner;
3638

3739
/**
38-
* Integration tests for {@link SecurityManagerProxy}.
40+
* Integration Tests for {@link SecurityManagerProxy}.
3941
*
4042
* @author John Blum
4143
* @see org.apache.geode.cache.GemFireCache

spring-geode-project/spring-geode/src/test/java/org/springframework/geode/security/support/SecurityManagerProxyUnitTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
* or implied. See the License for the specific language governing
1414
* permissions and limitations under the License.
1515
*/
16-
1716
package org.springframework.geode.security.support;
1817

1918
import static org.assertj.core.api.Assertions.assertThat;
@@ -27,11 +26,12 @@
2726
import java.security.Principal;
2827
import java.util.Properties;
2928

30-
import org.apache.geode.security.ResourcePermission;
3129
import org.junit.Test;
3230

31+
import org.apache.geode.security.ResourcePermission;
32+
3333
/**
34-
* Unit tests for {@link SecurityManagerProxy}
34+
* Unit Tests for {@link SecurityManagerProxy}
3535
*
3636
* @author John Blum
3737
* @see java.security.Principal

0 commit comments

Comments
 (0)