Address PR feedback

filipnavara · filipnavara · commit cbcb609afe98 · 2019-04-23T13:16:56.000+02:00
Signed-off-by: Filip Navara &lt;filip.navara@gmail.com&gt;
diff --git a/plumbing/format/packfile/packfile.go b/plumbing/format/packfile/packfile.go
@@ -184,7 +184,7 @@ func (p *Packfile) getObjectType(h *ObjectHeader) (typ plumbing.ObjectType, err
 }
 
 func (p *Packfile) objectAtOffset(offset int64, hash plumbing.Hash) (plumbing.EncodedObject, error) {
-	if obj, ok := p.deltaBaseCache.Get(hash); ok {
+	if obj, ok := p.cacheGet(hash); ok {
 		return obj, nil
 	}
 
@@ -237,7 +237,7 @@ func (p *Packfile) getNextObject(h *ObjectHeader, hash plumbing.Hash) (plumbing.
 			} else {
 				err = p.fillOFSDeltaObjectContentWithBuffer(obj, h.OffsetReference, buf)
 			}
-			return obj, nil
+			return obj, err
 		}
 	} else {
 		size, err = p.getObjectSize(h)

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ func (p Packfile) getObjectType(h ObjectHeader) (typ plumbing.ObjectType, err`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`func (p *Packfile) objectAtOffset(offset int64, hash plumbing.Hash) (plumbing.EncodedObject, error) {`
`187`		`- if obj, ok := p.deltaBaseCache.Get(hash); ok {`
	`187`	`+ if obj, ok := p.cacheGet(hash); ok {`
`188`	`188`	`return obj, nil`
`189`	`189`	`}`
`190`	`190`
`@@ -237,7 +237,7 @@ func (p Packfile) getNextObject(h ObjectHeader, hash plumbing.Hash) (plumbing.`
`237`	`237`	`} else {`
`238`	`238`	`err = p.fillOFSDeltaObjectContentWithBuffer(obj, h.OffsetReference, buf)`
`239`	`239`	`}`
`240`		`- return obj, nil`
	`240`	`+ return obj, err`
`241`	`241`	`}`
`242`	`242`	`} else {`
`243`	`243`	`size, err = p.getObjectSize(h)`