Added timeout to subnetdevices and updated readme

Author: stealthcopter

app/src/main/java/com/stealthcotper/networktools/MainActivity.java

@@ -221,8 +221,6 @@ private void findSubnetDevices() {
 
         final long startTimeMillis = System.currentTimeMillis();
 
-        String partialIpAddress = editIpAddress.getText().toString();
-
         SubnetDevices.fromLocalAddress().findDevices(new SubnetDevices.OnSubnetDeviceFound() {
             @Override
             public void onDeviceFound(Device device) {
@@ -232,6 +230,7 @@ public void onDeviceFound(Device device) {
             @Override
             public void onFinished(ArrayList<Device> devicesFound) {
                 float timeTaken =  (System.currentTimeMillis() - startTimeMillis)/1000.0f;
+                appendResultsText("Devices Found: " + devicesFound.size());
                 appendResultsText("Finished "+timeTaken+" s");
             }
         });

library/src/main/java/com/stealthcopter/networktools/PortScan.java

@@ -105,7 +105,7 @@ else if (IPTools.isIpAddressLocalNetwork(ia)){
      * @return this object to allow chaining
      */
     public PortScan setTimeOutMillis(int timeOutMillis){
-        if (timeOutMillis<0) throw new IllegalArgumentException("Times cannot be less than 0");
+        if (timeOutMillis<0) throw new IllegalArgumentException("Timeout cannot be less than 0");
         this.timeOutMillis = timeOutMillis;
         return this;
     }

library/src/main/java/com/stealthcopter/networktools/SubnetDevices.java

@@ -21,6 +21,7 @@ public class SubnetDevices {
     private ArrayList<String> addresses;
     private ArrayList<Device> devicesFound;
     private OnSubnetDeviceFound listener;
+    private int timeOutMillis = 2500;
 
     // This class is not to be instantiated
     private SubnetDevices() {
@@ -92,6 +93,18 @@ public SubnetDevices setNoThreads(int noThreads) throws IllegalAccessException {
         return this;
     }
 
+    /**
+     * Sets the timeout for each address we try to ping
+     *
+     * @return this object to allow chaining
+     */
+    public SubnetDevices setTimeOutMillis(int timeOutMillis){
+        if (timeOutMillis<0) throw new IllegalArgumentException("Timeout cannot be less than 0");
+        this.timeOutMillis = timeOutMillis;
+        return this;
+    }
+
+
     public void findDevices(final OnSubnetDeviceFound listener) {
 
         this.listener = listener;
@@ -134,7 +147,7 @@ public class SubnetDeviceFinderRunnable implements Runnable {
         public void run() {
             try {
                 InetAddress ia = InetAddress.getByName(address);
-                PingResult pingResult = Ping.onAddress(ia).doPing();
+                PingResult pingResult = Ping.onAddress(ia).setTimeOutMillis(timeOutMillis).doPing();
                 if (pingResult.isReachable) {
                     Device device = new Device(ia);
                     device.mac = ARPInfo.getMACFromIPAddress(ia.getHostAddress());

readme.md

@@ -51,7 +51,7 @@ Requires internet permission (obviously...)
 
 ### Port Scanning
 
-A simple java based TCP port scanner, fast and easy to use.
+A simple java based TCP port scanner, fast and easy to use. By default it will try and guess the best timeout and threads to use while scanning depending on if the address looks like localhost, local network or remote. You can override these yourself by calling setNoThreads() and setTimeoutMillis()
 
 ```java
     // Synchronously
@@ -74,7 +74,7 @@ A simple java based TCP port scanner, fast and easy to use.
 
 ### Subnet Devices
 
-Finds devices that respond to ping that are on the same subnet as the current device.
+Finds devices that respond to ping that are on the same subnet as the current device. You can set the timeout for the ping with setTimeOutMillis() \[default 2500\] and the number of threads with setNoThreads() \[default 255\]
 
 ```
     // Asynchronously