Commit 2d41efe
committed
[Build] Don't configure LLDB with tests enabled if the tests will be skipped
Currently the `--skip-test-lldb` flag will only skip *running* the
tests. But we still pass `LLDB_INCLUDE_TESTS` to CMake when configuring
LLDB.
Since #66018 configuring LLDB tests will
now always require libcxx to be built. For some presets (e.g.,
`buildbot_osx_package`) we don't need to build libcxx and we explicitly
pass `--skip-test-lldb`; this means if we were to try configure LLDB
tests we would hard error.
The proposed solution is to check whether the user wants to skip LLDB
tests, and if so, set `LLDB_INCLUDE_TESTS=FALSE`.
rdar://1097741791 parent d685c1c commit 2d41efe
1 file changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2187 | 2187 | | |
2188 | 2188 | | |
2189 | 2189 | | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
| 2195 | + | |
2190 | 2196 | | |
2191 | 2197 | | |
2192 | 2198 | | |
| |||
2205 | 2211 | | |
2206 | 2212 | | |
2207 | 2213 | | |
2208 | | - | |
| 2214 | + | |
2209 | 2215 | | |
2210 | 2216 | | |
2211 | 2217 | | |
| |||
0 commit comments