Skip to content

Commit 5cd9a1f

Browse files
[HttpFoundation] Deprecate Request::get() in favor of using properties ->attributes, query or request directly
1 parent 8617c6d commit 5cd9a1f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

EventListener/ProfilerListener.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ public function onKernelResponse(ResponseEvent $event): void
8080
}
8181

8282
$request = $event->getRequest();
83-
if (null !== $this->collectParameter && null !== $collectParameterValue = $request->get($this->collectParameter)) {
84-
true === $collectParameterValue || filter_var($collectParameterValue, \FILTER_VALIDATE_BOOL) ? $this->profiler->enable() : $this->profiler->disable();
83+
if (null !== $this->collectParameter && null !== $collectParameterValue = $request->attributes->get($this->collectParameter) ?? $request->query->get($this->collectParameter) ?? $request->request->get($this->collectParameter)) {
84+
filter_var($collectParameterValue, \FILTER_VALIDATE_BOOL) ? $this->profiler->enable() : $this->profiler->disable();
8585
}
8686

8787
$exception = $this->exception;

Fragment/InlineFragmentRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ protected function createSubRequest(string $uri, Request $request): Request
118118
$setSession ??= \Closure::bind(static function ($subRequest, $request) { $subRequest->session = $request->session; }, null, Request::class);
119119
$setSession($subRequest, $request);
120120

121-
if ($request->get('_format')) {
122-
$subRequest->attributes->set('_format', $request->get('_format'));
121+
if ($request->attributes->has('_format')) {
122+
$subRequest->attributes->set('_format', $request->attributes->get('_format'));
123123
}
124124
if ($request->getDefaultLocale() !== $request->getLocale()) {
125125
$subRequest->setLocale($request->getLocale());

0 commit comments

Comments
 (0)