CS fixes

Author: nicolas-grekas

Attribute/WithLogLevel.php

@@ -25,7 +25,7 @@ final class WithLogLevel
     public function __construct(public readonly string $level)
     {
         if (!\defined('Psr\Log\LogLevel::'.strtoupper($this->level))) {
-            throw new \InvalidArgumentException(sprintf('Invalid log level "%s".', $this->level));
+            throw new \InvalidArgumentException(\sprintf('Invalid log level "%s".', $this->level));
         }
     }
 }

Bundle/Bundle.php

@@ -70,15 +70,15 @@ public function getContainerExtension(): ?ExtensionInterface
 
             if (null !== $extension) {
                 if (!$extension instanceof ExtensionInterface) {
-                    throw new \LogicException(sprintf('Extension "%s" must implement Symfony\Component\DependencyInjection\Extension\ExtensionInterface.', get_debug_type($extension)));
+                    throw new \LogicException(\sprintf('Extension "%s" must implement Symfony\Component\DependencyInjection\Extension\ExtensionInterface.', get_debug_type($extension)));
                 }
 
                 // check naming convention
                 $basename = preg_replace('/Bundle$/', '', $this->getName());
                 $expectedAlias = Container::underscore($basename);
 
                 if ($expectedAlias != $extension->getAlias()) {
-                    throw new \LogicException(sprintf('Users will expect the alias of the default extension of a bundle to be the underscored version of the bundle name ("%s"). You can override "Bundle::getContainerExtension()" if you want to use "%s" or another alias.', $expectedAlias, $extension->getAlias()));
+                    throw new \LogicException(\sprintf('Users will expect the alias of the default extension of a bundle to be the underscored version of the bundle name ("%s"). You can override "Bundle::getContainerExtension()" if you want to use "%s" or another alias.', $expectedAlias, $extension->getAlias()));
                 }
 
                 $this->extension = $extension;

CacheClearer/Psr6CacheClearer.php

@@ -39,7 +39,7 @@ public function hasPool(string $name): bool
     public function getPool(string $name): CacheItemPoolInterface
     {
         if (!$this->hasPool($name)) {
-            throw new \InvalidArgumentException(sprintf('Cache pool not found: "%s".', $name));
+            throw new \InvalidArgumentException(\sprintf('Cache pool not found: "%s".', $name));
         }
 
         return $this->pools[$name];
@@ -51,7 +51,7 @@ public function getPool(string $name): CacheItemPoolInterface
     public function clearPool(string $name): bool
     {
         if (!isset($this->pools[$name])) {
-            throw new \InvalidArgumentException(sprintf('Cache pool not found: "%s".', $name));
+            throw new \InvalidArgumentException(\sprintf('Cache pool not found: "%s".', $name));
         }
 
         return $this->pools[$name]->clear();

CacheWarmer/CacheWarmer.php

@@ -30,6 +30,6 @@ protected function writeCacheFile(string $file, $content)
             return;
         }
 
-        throw new \RuntimeException(sprintf('Failed to write cache file "%s".', $file));
+        throw new \RuntimeException(\sprintf('Failed to write cache file "%s".', $file));
     }
 }

CacheWarmer/CacheWarmerAggregate.php

@@ -107,13 +107,13 @@ public function warmUp(string $cacheDir, string|SymfonyStyle|null $buildDir = nu
                 $start = microtime(true);
                 foreach ((array) $warmer->warmUp($cacheDir, $buildDir) as $item) {
                     if (is_dir($item) || (str_starts_with($item, \dirname($cacheDir)) && !is_file($item)) || ($buildDir && str_starts_with($item, \dirname($buildDir)) && !is_file($item))) {
-                        throw new \LogicException(sprintf('"%s::warmUp()" should return a list of files or classes but "%s" is none of them.', $warmer::class, $item));
+                        throw new \LogicException(\sprintf('"%s::warmUp()" should return a list of files or classes but "%s" is none of them.', $warmer::class, $item));
                     }
                     $preload[] = $item;
                 }
 
                 if ($io?->isDebug()) {
-                    $io->info(sprintf('"%s" completed in %0.2fms.', $warmer::class, 1000 * (microtime(true) - $start)));
+                    $io->info(\sprintf('"%s" completed in %0.2fms.', $warmer::class, 1000 * (microtime(true) - $start)));
                 }
             }
         } finally {

Controller/ArgumentResolver.php

@@ -60,7 +60,7 @@ public function getArguments(Request $request, callable $controller, ?\Reflectio
                     if ($attribute->disabled) {
                         $disabledResolvers[$attribute->resolver] = true;
                     } elseif ($resolverName) {
-                        throw new \LogicException(sprintf('You can only pin one resolver per argument, but argument "$%s" of "%s()" has more.', $metadata->getName(), $this->getPrettyName($controller)));
+                        throw new \LogicException(\sprintf('You can only pin one resolver per argument, but argument "$%s" of "%s()" has more.', $metadata->getName(), $this->getPrettyName($controller)));
                     } else {
                         $resolverName = $attribute->resolver;
                     }
@@ -94,7 +94,7 @@ public function getArguments(Request $request, callable $controller, ?\Reflectio
                 }
 
                 if (1 < $count && !$metadata->isVariadic()) {
-                    throw new \InvalidArgumentException(sprintf('"%s::resolve()" must yield at most one value for non-variadic arguments.', get_debug_type($resolver)));
+                    throw new \InvalidArgumentException(\sprintf('"%s::resolve()" must yield at most one value for non-variadic arguments.', get_debug_type($resolver)));
                 }
 
                 if ($count) {
@@ -103,11 +103,11 @@ public function getArguments(Request $request, callable $controller, ?\Reflectio
                 }
 
                 if (!$resolver instanceof ValueResolverInterface) {
-                    throw new \InvalidArgumentException(sprintf('"%s::resolve()" must yield at least one value.', get_debug_type($resolver)));
+                    throw new \InvalidArgumentException(\sprintf('"%s::resolve()" must yield at least one value.', get_debug_type($resolver)));
                 }
             }
 
-            throw new \RuntimeException(sprintf('Controller "%s" requires that you provide a value for the "$%s" argument. Either the argument is nullable and no null value has been provided, no default value has been provided or there is a non-optional argument after this one.', $this->getPrettyName($controller), $metadata->getName()));
+            throw new \RuntimeException(\sprintf('Controller "%s" requires that you provide a value for the "$%s" argument. Either the argument is nullable and no null value has been provided, no default value has been provided or there is a non-optional argument after this one.', $this->getPrettyName($controller), $metadata->getName()));
         }
 
         return $arguments;

Controller/ArgumentResolver/BackedEnumValueResolver.php

@@ -78,7 +78,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
         }
 
         if (!\is_int($value) && !\is_string($value)) {
-            throw new \LogicException(sprintf('Could not resolve the "%s $%s" controller argument: expecting an int or string, got "%s".', $argument->getType(), $argument->getName(), get_debug_type($value)));
+            throw new \LogicException(\sprintf('Could not resolve the "%s $%s" controller argument: expecting an int or string, got "%s".', $argument->getType(), $argument->getName(), get_debug_type($value)));
         }
 
         /** @var class-string<\BackedEnum> $enumType */
@@ -87,7 +87,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
         try {
             return [$enumType::from($value)];
         } catch (\ValueError|\TypeError $e) {
-            throw new NotFoundHttpException(sprintf('Could not resolve the "%s $%s" controller argument: ', $argument->getType(), $argument->getName()).$e->getMessage(), $e);
+            throw new NotFoundHttpException(\sprintf('Could not resolve the "%s $%s" controller argument: ', $argument->getType(), $argument->getName()).$e->getMessage(), $e);
         }
     }
 }

Controller/ArgumentResolver/DateTimeValueResolver.php

@@ -90,7 +90,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
         }
 
         if (!$date) {
-            throw new NotFoundHttpException(sprintf('Invalid date given for parameter "%s".', $argument->getName()));
+            throw new NotFoundHttpException(\sprintf('Invalid date given for parameter "%s".', $argument->getName()));
         }
 
         return [$date];

Controller/ArgumentResolver/NotTaggedControllerValueResolver.php

@@ -82,8 +82,8 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
             return [];
         }
 
-        $what = sprintf('argument $%s of "%s()"', $argument->getName(), $controller);
-        $message = sprintf('Could not resolve %s, maybe you forgot to register the controller as a service or missed tagging it with the "controller.service_arguments"?', $what);
+        $what = \sprintf('argument $%s of "%s()"', $argument->getName(), $controller);
+        $message = \sprintf('Could not resolve %s, maybe you forgot to register the controller as a service or missed tagging it with the "controller.service_arguments"?', $what);
 
         throw new RuntimeException($message);
     }

Controller/ArgumentResolver/QueryParameterValueResolver.php

@@ -38,7 +38,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
                 return [];
             }
 
-            throw new NotFoundHttpException(sprintf('Missing query parameter "%s".', $name));
+            throw new NotFoundHttpException(\sprintf('Missing query parameter "%s".', $name));
         }
 
         $value = $request->query->all()[$name];
@@ -52,7 +52,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
             $filtered = array_values(array_filter((array) $value, \is_array(...)));
 
             if ($filtered !== $value && !($attribute->flags & \FILTER_NULL_ON_FAILURE)) {
-                throw new NotFoundHttpException(sprintf('Invalid query parameter "%s".', $name));
+                throw new NotFoundHttpException(\sprintf('Invalid query parameter "%s".', $name));
             }
 
             return $filtered;
@@ -80,8 +80,8 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
             default => match ($enumType = is_subclass_of($type, \BackedEnum::class) ? (new \ReflectionEnum($type))->getBackingType()->getName() : null) {
                 'int' => \FILTER_VALIDATE_INT,
                 'string' => \FILTER_DEFAULT,
-                default => throw new \LogicException(sprintf('#[MapQueryParameter] cannot be used on controller argument "%s$%s" of type "%s"; one of array, string, int, float, bool or \BackedEnum should be used.', $argument->isVariadic() ? '...' : '', $argument->getName(), $type ?? 'mixed')),
-            }
+                default => throw new \LogicException(\sprintf('#[MapQueryParameter] cannot be used on controller argument "%s$%s" of type "%s"; one of array, string, int, float, bool or \BackedEnum should be used.', $argument->isVariadic() ? '...' : '', $argument->getName(), $type ?? 'mixed')),
+            },
         };
 
         $value = filter_var($value, $attribute->filter ?? $filter, $options);
@@ -103,7 +103,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
         }
 
         if (null === $value && !($attribute->flags & \FILTER_NULL_ON_FAILURE)) {
-            throw new NotFoundHttpException(sprintf('Invalid query parameter "%s".', $name));
+            throw new NotFoundHttpException(\sprintf('Invalid query parameter "%s".', $name));
         }
 
         if (!\is_array($value)) {
@@ -117,7 +117,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
         }
 
         if ($filtered !== $value && !($attribute->flags & \FILTER_NULL_ON_FAILURE)) {
-            throw new NotFoundHttpException(sprintf('Invalid query parameter "%s".', $name));
+            throw new NotFoundHttpException(\sprintf('Invalid query parameter "%s".', $name));
         }
 
         return $argument->isVariadic() ? $filtered : [$filtered];