-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add Symfony UX Image component #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
|
Thank you very much for adding this new component. |
|
Yeah that's very nice! Please let me the week (work work work) before i'm starting a full review... ... just to anticipate, would you be OK to trim down the component to the strict bare minimum, and then we build upon it ? (not saying it's not perfect yet, not enough time to review as I said 😅 ) Anyway... thank you for this wonderful contribution. |
WebMamba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pioufffff thanks a lot! It's a lot of work! 🥵 What do you think about starting a bit more simple and then iterate.
What do you think about starting just with those 3 points:
- Automatic WebP conversion
- Responsive srcset/sizes generation
- Viewport-based width configuration (100vw md:80vw lg:50vw)
Do you think we can have two components one image component and one picture component ?
| "symfony/dependency-injection": "^6.4|^7.0|^8.0", | ||
| "symfony/http-kernel": "^6.4|^7.0|^8.0", | ||
| "twig/twig": "^3.0", | ||
| "liip/imagine-bundle": "^2.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hummm that is something that we should discuss 🤔
New
symfony/ux-imagecomponent providing optimized responsive image components with automatic format conversion, smart cropping, and Core Web Vitals optimization.Components
<twig:img>- Simple responsive images100vw md:80vw lg:50vw)densities="1x 2x")<twig:picture>- Art direction supportratio="sm:1:1 md:16:9")Usage Examples