Skip to content

Commit c3ccd05

Browse files
authored
Fix typos and redundancy (freechipsproject#150)
1 parent 60e7144 commit c3ccd05

File tree

3 files changed

+9
-34
lines changed

3 files changed

+9
-34
lines changed

3.1_parameters.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
"metadata": {},
114114
"source": [
115115
"The above code block has some `require(...)` statements.\n",
116-
"These are pre-elaboration assertions, which are useful when your generator only works with certain parameterizations or when some parameterizations are mutually exclusive or nensensical.\n",
116+
"These are pre-elaboration assertions, which are useful when your generator only works with certain parameterizations or when some parameterizations are mutually exclusive or nonsensical.\n",
117117
"The above code block checks that widths are non-negative.\n",
118118
"\n",
119119
"There is a separate construct for simulation-time assertions called `assert(...)`.\n",
@@ -959,4 +959,4 @@
959959
},
960960
"nbformat": 4,
961961
"nbformat_minor": 1
962-
}
962+
}

3.2_collections.ipynb

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -397,31 +397,6 @@
397397
"runOneTest(Seq.fill(500)(r()))"
398398
]
399399
},
400-
{
401-
"cell_type": "code",
402-
"execution_count": null,
403-
"metadata": {},
404-
"outputs": [],
405-
"source": [
406-
"val taps = Seq.fill(500)(r())\n",
407-
"\n",
408-
"val goldenModel = new ScalaFirFilter(taps)\n",
409-
"\n",
410-
"test(new MyManyElementFir(taps, 32)) { c =>\n",
411-
" for(i <- 0 until 100) {\n",
412-
" val input = r()\n",
413-
"\n",
414-
" val goldenModelResult = goldenModel.poke(input)\n",
415-
"\n",
416-
" c.io.in.poke(input.U)\n",
417-
"\n",
418-
" c.io.out.expect(goldenModelResult.U, s\"i $i, input $input, gm $goldenModelResult, ${c.io.out.peek().litValue}\")\n",
419-
"\n",
420-
" c.clock.step(1)\n",
421-
" }\n",
422-
"}\n"
423-
]
424-
},
425400
{
426401
"cell_type": "markdown",
427402
"metadata": {},
@@ -632,4 +607,4 @@
632607
},
633608
"nbformat": 4,
634609
"nbformat_minor": 2
635-
}
610+
}

3.2_interlude.ipynb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,22 +97,22 @@
9797
" io.out <> queue\n",
9898
" }) { c =>\n",
9999
" c.io.out.ready.poke(false.B)\n",
100-
" c.io.in.valid.poke(true.B) // Enqueue an elemen.Ut\n",
100+
" c.io.in.valid.poke(true.B) // Enqueue an element\n",
101101
" c.io.in.bits.poke(42.U)\n",
102102
" println(s\"Starting:\")\n",
103103
" println(s\"\\tio.in: ready=${c.io.in.ready.peek().litValue}\")\n",
104104
" println(s\"\\tio.out: valid=${c.io.out.valid.peek().litValue}, bits=${c.io.out.bits.peek().litValue}\")\n",
105105
" c.clock.step(1)\n",
106106
"\n",
107-
" c.io.in.valid.poke(true.B) // Enqueue another elemen.Ut\n",
107+
" c.io.in.valid.poke(true.B) // Enqueue another element\n",
108108
" c.io.in.bits.poke(43.U)\n",
109109
" // What do you think io.out.valid and io.out.bits will be?\n",
110110
" println(s\"After first enqueue:\")\n",
111111
" println(s\"\\tio.in: ready=${c.io.in.ready.peek().litValue}\")\n",
112112
" println(s\"\\tio.out: valid=${c.io.out.valid.peek().litValue}, bits=${c.io.out.bits.peek().litValue}\")\n",
113113
" c.clock.step(1)\n",
114114
"\n",
115-
" c.io.in.valid.poke(true.B) // Read a element, attempt to enqueu.Ue\n",
115+
" c.io.in.valid.poke(true.B) // Read a element, attempt to enqueue\n",
116116
" c.io.in.bits.poke(44.U)\n",
117117
" c.io.out.ready.poke(true.B)\n",
118118
" // What do you think io.in.ready will be, and will this enqueue succeed, and what will be read?\n",
@@ -121,7 +121,7 @@
121121
" println(s\"\\tio.out: valid=${c.io.out.valid.peek()}, bits=${c.io.out.bits.peek()}\")\n",
122122
" c.clock.step(1)\n",
123123
"\n",
124-
" c.io.in.valid.poke(false.B) // Read elements ou.Ut\n",
124+
" c.io.in.valid.poke(false.B) // Read elements out\n",
125125
" c.io.out.ready.poke(true.B)\n",
126126
" // What do you think will be read here?\n",
127127
" println(s\"On second read:\")\n",
@@ -216,7 +216,7 @@
216216
"outputs": [],
217217
"source": [
218218
"test(new Module {\n",
219-
" // Example circuit using Reverse\n",
219+
" // Example circuit using PopCount\n",
220220
" val io = IO(new Bundle {\n",
221221
" val in = Input(UInt(8.W))\n",
222222
" val out = Output(UInt(8.W))\n",
@@ -509,4 +509,4 @@
509509
},
510510
"nbformat": 4,
511511
"nbformat_minor": 1
512-
}
512+
}

0 commit comments

Comments
 (0)