turn off extension block symbols in the standard library, due to upsteam Swift compiler crashes

Author: tayloraswift

Sources/SymbolGraphBuilder/Builds/SSGC.PackageBuild.swift

@@ -302,7 +302,7 @@ extension SSGC.PackageBuild
         {
             try toolchain.build(package: self.root,
                 using: self.scratch,
-                flags: self.flags.dumping(symbols: .default, to: artifacts))
+                flags: self.flags.dumping(symbols: .init(), to: artifacts))
         }
         catch SystemProcessError.exit(let code, let invocation)
         {
@@ -331,14 +331,13 @@ extension SSGC.PackageBuild
         //  Dump the standard library’s symbols, unless they’re already cached.
         let artifactsCached:FilePath.Directory = try toolchain.dump(
             standardLibrary: .init(platform: platform),
-            options: .default,
             cache: cache)
         for (module, include):(Symbol.Module, [FilePath.Directory]) in try self.modulesToDump(
             among: modules)
         {
             try toolchain.dump(module: module,
                 to: artifacts,
-                options: .default,
+                options: .init(),
                 include: include)
         }
 

Sources/SymbolGraphBuilder/Standard library/SSGC.StandardLibraryBuild.swift

@@ -27,7 +27,6 @@ extension SSGC.StandardLibraryBuild:SSGC.DocumentationBuild
         let standardLibrary:SSGC.StandardLibrary = .init(platform: try toolchain.platform())
 
         let artifacts:FilePath.Directory = try toolchain.dump(standardLibrary: standardLibrary,
-            options: .default,
             cache: cache)
 
         let metadata:SymbolGraphMetadata = .swift(toolchain.splash.swift,

Sources/SymbolGraphBuilder/Toolchains/SSGC.Toolchain.SymbolDumpOptions.swift

@@ -9,10 +9,10 @@ extension SSGC.Toolchain
         var includeInterfaceSymbols:Bool
         var skipInheritedDocs:Bool
 
-        init(minimumACL:Symbol.ACL,
-            emitExtensionBlockSymbols:Bool,
-            includeInterfaceSymbols:Bool,
-            skipInheritedDocs:Bool)
+        init(minimumACL:Symbol.ACL = .internal,
+            emitExtensionBlockSymbols:Bool = true,
+            includeInterfaceSymbols:Bool = true,
+            skipInheritedDocs:Bool = true)
         {
             self.minimumACL = minimumACL
             self.emitExtensionBlockSymbols = emitExtensionBlockSymbols
@@ -21,14 +21,3 @@ extension SSGC.Toolchain
         }
     }
 }
-extension SSGC.Toolchain.SymbolDumpOptions
-{
-    static
-    var `default`:Self
-    {
-        .init(minimumACL: .internal,
-            emitExtensionBlockSymbols: true,
-            includeInterfaceSymbols: true,
-            skipInheritedDocs: true)
-    }
-}

Sources/SymbolGraphBuilder/Toolchains/SSGC.Toolchain.swift

@@ -208,8 +208,10 @@ extension SSGC.Toolchain
 }
 extension SSGC.Toolchain
 {
+    /// Dumps the symbols for the standard library. Due to upstream bugs in the Swift compiler,
+    /// this methods disables extension block symbols by default.
     func dump(standardLibrary:SSGC.StandardLibrary,
-        options:SymbolDumpOptions = .default,
+        options:SymbolDumpOptions = .init(emitExtensionBlockSymbols: false),
         cache:FilePath.Directory) throws -> FilePath.Directory
     {
         let cached:FilePath.Directory = cache / "swift@\(self.splash.swift.version)"
@@ -234,7 +236,7 @@ extension SSGC.Toolchain
     /// output directory.
     func dump(module id:Symbol.Module,
         to output:FilePath.Directory,
-        options:SymbolDumpOptions = .default,
+        options:SymbolDumpOptions,
         include:[FilePath.Directory] = []) throws
     {
         print("Dumping symbols for module '\(id)'")