fix: adjust security_group_ids to TypeSet (#1321)

* adjust security_group_ids to TypeSet

* adjust doc

* adjust security_group_ids to TypeSet

* adjust doc

* adjust security_group_ids to TypeSet

* adjust doc

* adjust security_group_ids to TypeSet

* adjust doc

* add changelog

Co-authored-by: nickyinluo <nickyinluo@tencent.com>

Author: lyu571

.changelog/1321.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/tencentcloud_kubernetes_node_pool: adjust `security_group_ids` type to unordered
+```

tencentcloud/resource_tc_kubernetes_node_pool.go

@@ -326,7 +326,7 @@ func composedKubernetesAsScalingConfigPara() map[string]*schema.Schema {
 			Description:   "ID list of keys.",
 		},
 		"security_group_ids": {
-			Type:        schema.TypeList,
+			Type:        schema.TypeSet,
 			Optional:    true,
 			Elem:        &schema.Schema{Type: schema.TypeString},
 			Description: "Security groups to which a CVM instance belongs.",
@@ -748,12 +748,7 @@ func composedKubernetesAsScalingConfigParaSerial(dMap map[string]interface{}, me
 	}
 
 	if v, ok := dMap["security_group_ids"]; ok {
-		securityGroups := v.([]interface{})
-		request.SecurityGroupIds = make([]*string, 0, len(securityGroups))
-		for i := range securityGroups {
-			securityGroup := securityGroups[i].(string)
-			request.SecurityGroupIds = append(request.SecurityGroupIds, &securityGroup)
-		}
+		request.SecurityGroupIds = helper.InterfacesStringsPoint(v.(*schema.Set).List())
 	}
 
 	request.EnhancedService = &as.EnhancedService{}
@@ -886,12 +881,7 @@ func composeAsLaunchConfigModifyRequest(d *schema.ResourceData, launchConfigId s
 	}
 
 	if v, ok := dMap["security_group_ids"]; ok {
-		securityGroups := v.([]interface{})
-		request.SecurityGroupIds = make([]*string, 0, len(securityGroups))
-		for i := range securityGroups {
-			securityGroup := securityGroups[i].(string)
-			request.SecurityGroupIds = append(request.SecurityGroupIds, &securityGroup)
-		}
+		request.SecurityGroupIds = helper.InterfacesStringsPoint(v.(*schema.Set).List())
 	}
 
 	chargeType, ok := dMap["instance_charge_type"].(string)

tencentcloud/resource_tc_kubernetes_node_pool_test.go

@@ -101,6 +101,7 @@ func TestAccTencentCloudTkeNodePoolResourceBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "node_count", "1"),
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "autoscaling_added_total", "1"),
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "manually_added_total", "0"),
+					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "auto_scaling_config.0.security_group_ids.#", "1"),
 				),
 			},
 			{
@@ -130,6 +131,7 @@ func TestAccTencentCloudTkeNodePoolResourceBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "default_cooldown", "350"),
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "termination_policies.#", "1"),
 					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "termination_policies.0", "NEWEST_INSTANCE"),
+					resource.TestCheckResourceAttr(testTkeClusterNodePoolResourceKey, "auto_scaling_config.0.security_group_ids.#", "2"),
 				),
 			},
 		},
@@ -241,6 +243,10 @@ data "tencentcloud_vpc_subnets" "vpc" {
 data "tencentcloud_security_groups" "sg" {
   name = "default"
 }
+
+data "tencentcloud_security_groups" "sg_as" {
+  name = "keep-for-as"
+}
 `
 
 const testAccTkeNodePoolCluster string = testAccTkeNodePoolClusterBasic + `
@@ -323,7 +329,7 @@ resource "tencentcloud_kubernetes_node_pool" "np_test" {
     instance_type      = var.ins_type
     system_disk_type   = "CLOUD_PREMIUM"
     system_disk_size   = "100"
-    security_group_ids = [data.tencentcloud_security_groups.sg.security_groups[0].security_group_id]
+    security_group_ids = [data.tencentcloud_security_groups.sg.security_groups[0].security_group_id, data.tencentcloud_security_groups.sg_as.security_groups[0].security_group_id]
 	instance_charge_type = "SPOTPAID"
     spot_instance_type = "one-time"
     spot_max_price = "1000"

website/docs/r/kubernetes_node_pool.html.markdown

@@ -196,7 +196,7 @@ The `auto_scaling_config` object supports the following:
 * `key_ids` - (Optional, List, ForceNew) ID list of keys.
 * `password` - (Optional, String, ForceNew) Password to access.
 * `public_ip_assigned` - (Optional, Bool) Specify whether to assign an Internet IP address.
-* `security_group_ids` - (Optional, List) Security groups to which a CVM instance belongs.
+* `security_group_ids` - (Optional, Set) Security groups to which a CVM instance belongs.
 * `spot_instance_type` - (Optional, String) Type of spot instance, only support `one-time` now. Note: it only works when instance_charge_type is set to `SPOTPAID`.
 * `spot_max_price` - (Optional, String) Max price of a spot instance, is the format of decimal string, for example "0.50". Note: it only works when instance_charge_type is set to `SPOTPAID`.
 * `system_disk_size` - (Optional, Int) Volume of system disk in GB. Default is `50`.