fix: mysql8.0 lower_case_table_names (#1751)

Co-authored-by: anonymous <anonymous@mail.org>

Author: gitmkn

tencentcloud/resource_tc_mysql_instance.go

@@ -1145,6 +1145,11 @@ func mysqlMasterInstanceRoleUpdate(ctx context.Context, d *schema.ResourceData,
 			supportsParameters[*parameter.Name] = parameter
 		}
 
+		version := d.Get("engine_version").(string)
+		if version == "8.0" && oldParameters["lower_case_table_names"] != newParameters["lower_case_table_names"] {
+			return fmt.Errorf("this mysql 8.0 not support param `lower_case_table_names` set")
+		}
+
 		for parameName := range newParameters {
 			if _, has := supportsParameters[parameName]; !has {
 				return fmt.Errorf("this mysql not support param %s set", parameName)

tencentcloud/resource_tc_mysql_instance_test.go

@@ -285,6 +285,63 @@ func TestAccTencentCloudMysqlInstanceResource_MasterInstance_basic_and_update(t
 	})
 }
 
+// go test -i; go test -test.run TestAccTencentCloudMysqlInstanceResource_mysql8 -v
+func TestAccTencentCloudMysqlInstanceResource_mysql8(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckMysqlMasterInstanceDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccMysqlMasterInstance_mysql8("utf8"),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMysqlMasterInstanceExists("tencentcloud_mysql_instance.mysql8"),
+					resource.TestCheckResourceAttrSet("tencentcloud_mysql_instance.mysql8", "id"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "charge_type", "POSTPAID"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "engine_version", "8.0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "internet_service", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "slave_deploy_mode", "0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "first_slave_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "second_slave_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "slave_sync_mode", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "availability_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "instance_name", "myTestMysql"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "mem_size", "1000"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "volume_size", "25"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "intranet_port", "3306"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "tags.createdBy", "terraform"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.character_set_server", "utf8"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.lower_case_table_names", "0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.max_connections", "1000"),
+				),
+			},
+			{
+				Config: testAccMysqlMasterInstance_mysql8("gbk"),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMysqlMasterInstanceExists("tencentcloud_mysql_instance.mysql8"),
+					resource.TestCheckResourceAttrSet("tencentcloud_mysql_instance.mysql8", "id"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "charge_type", "POSTPAID"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "engine_version", "8.0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "internet_service", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "slave_deploy_mode", "0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "first_slave_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "second_slave_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "slave_sync_mode", "1"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "availability_zone", "ap-guangzhou-4"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "instance_name", "myTestMysql"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "mem_size", "1000"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "volume_size", "25"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "intranet_port", "3306"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "tags.createdBy", "terraform"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.character_set_server", "gbk"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.lower_case_table_names", "0"),
+					resource.TestCheckResourceAttr("tencentcloud_mysql_instance.mysql8", "parameters.max_connections", "1000"),
+				),
+			},
+		},
+	})
+}
+
 func testAccCheckMysqlMasterInstanceDestroy(s *terraform.State) error {
 	logId := getLogId(contextNil)
 	ctx := context.WithValue(context.TODO(), logIdKey, logId)
@@ -508,3 +565,34 @@ resource "tencentcloud_mysql_instance" "mysql_master" {
 }`
 	return fmt.Sprintf(tpl, instance_name, instranet_port)
 }
+
+func testAccMysqlMasterInstance_mysql8(value string) string {
+	return fmt.Sprintf(`
+resource "tencentcloud_mysql_instance" "mysql8" {
+	internet_service = 1
+	engine_version   = "8.0"
+	charge_type = "POSTPAID"
+	root_password     = "password123"
+	slave_deploy_mode = 0
+	first_slave_zone  = "ap-guangzhou-4"
+	second_slave_zone = "ap-guangzhou-4"
+	slave_sync_mode   = 1
+	availability_zone = "ap-guangzhou-4"
+	project_id        = 0
+	instance_name     = "myTestMysql"
+	mem_size          = 1000
+	volume_size       = 25
+	intranet_port     = 3306
+	security_groups   = ["sg-ngx2bo7j"]
+  
+	tags = {
+	  createdBy = "terraform"
+	}
+  
+	parameters = {
+	  character_set_server = "%s"
+	  lower_case_table_names = 0
+	  max_connections = "1000"
+	}
+}`, value)
+}