optimize code logic

Author: crab21

tencentcloud/data_source_tc_images.go

@@ -268,7 +268,7 @@ func dataSourceTencentCloudImagesRead(d *schema.ResourceData, meta interface{})
 	imageList := make([]map[string]interface{}, 0, len(results))
 	ids := make([]string, 0, len(results))
 	for _, image := range results {
-		snapshots, err := imagesReadSnapshotByIds(image, cbsService, ctx)
+		snapshots, err := imagesReadSnapshotByIds(ctx, cbsService, image)
 		if err != nil {
 			return err
 		}
@@ -311,7 +311,7 @@ func dataSourceTencentCloudImagesRead(d *schema.ResourceData, meta interface{})
 	return nil
 }
 
-func imagesReadSnapshotByIds(image *cvm.Image, cbsService CbsService, ctx context.Context) (snapshotResults []map[string]interface{}, errSnap error) {
+func imagesReadSnapshotByIds(ctx context.Context, cbsService CbsService, image *cvm.Image) (snapshotResults []map[string]interface{}, errSnap error) {
 	if len(image.SnapshotSet) == 0 {
 		return
 	}

tencentcloud/service_tencentcloud_cbs.go

@@ -250,7 +250,7 @@ func (me *CbsService) DescribeSnapshotByIds(ctx context.Context, snapshotIdsPara
 		log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n",
 			logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
 
-		if response == nil || len(response.Response.SnapshotSet) < 1 {
+		if len(response.Response.SnapshotSet) < 1 {
 			break
 		}