Skip to content

Commit 582ae7d

Browse files
authored
fix: organization bug (#2366)
* fix: organization bug * fix: Fix parameter types
1 parent 4b18994 commit 582ae7d

File tree

4 files changed

+25
-10
lines changed

4 files changed

+25
-10
lines changed

.changelog/2366.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
```release-note:bug
2+
resource/tencentcloud_organization_org_member: Fix parameter types and update logic
3+
```
4+
5+
```release-note:bug
6+
resource/tencentcloud_organization_org_member_email: Fix parameter types
7+
```

tencentcloud/resource_tc_organization_org_member.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,16 +375,26 @@ func resourceTencentCloudOrganizationOrgMemberUpdate(d *schema.ResourceData, met
375375
if v, _ := d.GetOk("policy_type"); v != nil {
376376
updateRequest.PolicyType = helper.String(v.(string))
377377
}
378+
if v, _ := d.GetOk("permission_ids"); v != nil {
379+
ids := v.(*schema.Set).List()
380+
for i := range ids {
381+
id := ids[i].(int)
382+
updateRequest.PermissionIds = append(updateRequest.PermissionIds, helper.IntUint64(id))
383+
}
384+
}
378385
}
379386

380387
if d.HasChange("permission_ids") {
381388
if v, _ := d.GetOk("permission_ids"); v != nil {
382389
ids := v.(*schema.Set).List()
383390
for i := range ids {
384-
id := ids[i].(uint64)
385-
updateRequest.PermissionIds = append(updateRequest.PermissionIds, helper.Uint64(id))
391+
id := ids[i].(int)
392+
updateRequest.PermissionIds = append(updateRequest.PermissionIds, helper.IntUint64(id))
386393
}
387394
}
395+
if v, _ := d.GetOk("policy_type"); v != nil {
396+
updateRequest.PolicyType = helper.String(v.(string))
397+
}
388398
}
389399

390400
if d.HasChange("is_allow_quit") {

tencentcloud/resource_tc_organization_org_member_email.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ func resourceTencentCloudOrganizationOrgMemberEmailRead(d *schema.ResourceData,
185185
return nil
186186
}
187187

188-
_ = d.Set("member_uin", memberUin)
188+
_ = d.Set("member_uin", helper.StrToInt64(memberUin))
189189

190190
if orgMemberEmail.Email != nil {
191191
_ = d.Set("email", orgMemberEmail.Email)

tencentcloud/resource_tc_organization_org_member_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ func TestAccTencentCloudOrganizationOrgMemberResource_basic(t *testing.T) {
1010
t.Parallel()
1111
resource.Test(t, resource.TestCase{
1212
PreCheck: func() {
13-
testAccPreCheck(t)
13+
testAccPreCheckCommon(t, ACCOUNT_TYPE_ORGANIZATION)
1414
},
1515
Providers: testAccProviders,
1616
Steps: []resource.TestStep{
1717
{
1818
Config: testAccOrganizationOrgMember,
1919
Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_organization_org_member.org_member", "id"),
20-
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "name", "terraform_test"),
20+
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "name", "tf_example"),
2121
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "node_id", "59849"),
2222
resource.TestCheckResourceAttrSet("tencentcloud_organization_org_member.org_member", "permission_ids.#"),
2323
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "policy_type", "Financial"),
@@ -27,7 +27,7 @@ func TestAccTencentCloudOrganizationOrgMemberResource_basic(t *testing.T) {
2727
{
2828
Config: testAccOrganizationOrgMemberUpdate,
2929
Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_organization_org_member.org_member", "id"),
30-
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "name", "terraform_test_1"),
30+
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "name", "tf_example_1"),
3131
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "node_id", "59849"),
3232
resource.TestCheckResourceAttrSet("tencentcloud_organization_org_member.org_member", "permission_ids.#"),
3333
resource.TestCheckResourceAttr("tencentcloud_organization_org_member.org_member", "policy_type", "Financial"),
@@ -46,7 +46,7 @@ func TestAccTencentCloudOrganizationOrgMemberResource_basic(t *testing.T) {
4646
const testAccOrganizationOrgMember = `
4747
4848
resource "tencentcloud_organization_org_member" "org_member" {
49-
name = "terraform_test"
49+
name = "tf_example"
5050
node_id = 59849
5151
permission_ids = [
5252
1,
@@ -57,18 +57,16 @@ resource "tencentcloud_organization_org_member" "org_member" {
5757
policy_type = "Financial"
5858
remark = "for terraform test"
5959
}
60-
6160
`
6261
const testAccOrganizationOrgMemberUpdate = `
6362
6463
resource "tencentcloud_organization_org_member" "org_member" {
65-
name = "terraform_test_1"
64+
name = "tf_example_1"
6665
node_id = 59849
6766
permission_ids = [
6867
1,
6968
2,
7069
3,
71-
4,
7270
]
7371
policy_type = "Financial"
7472
remark = "for terraform test"

0 commit comments

Comments
 (0)