Skip to content

Commit 9a47c87

Browse files
Modify the problems in the code review
1 parent 49cbc6b commit 9a47c87

File tree

7 files changed

+171
-230
lines changed

7 files changed

+171
-230
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
## 1.41.3 (Unreleased)
1+
## 1.42.0 (Unreleased)
22

33
FEATURES:
44

55
* **New Resource**: `tencentcloud_ckafka_topic`
6-
* **New Data Source**: `tencentcloud_ckafka_topics`
6+
* **New Data Source**: `tencentcloud_ckafka_topics`
77

88
## 1.41.2 (August 28, 2020)
99

tencentcloud/data_source_tc_ckafka_topics.go

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
Use this data source to query detailed information of ckafka topic instances.
2+
Use this data source to query detailed information of ckafka topic.
33
44
Example Usage
55
@@ -67,7 +67,7 @@ func dataSourceTencentCloudCkafkaTopics() *schema.Resource {
6767
"topic_name": {
6868
Type: schema.TypeString,
6969
Computed: true,
70-
Description: "Name of the CKafka topic. It must start with a letter, the rest can contain letters, numbers and dashes(-). The length range is from 1 to 64.",
70+
Description: "Name of the CKafka topic.",
7171
},
7272
"partition_num": {
7373
Type: schema.TypeInt,
@@ -77,12 +77,12 @@ func dataSourceTencentCloudCkafkaTopics() *schema.Resource {
7777
"replica_num": {
7878
Type: schema.TypeInt,
7979
Computed: true,
80-
Description: "The number of replica, the maximum is 3.",
80+
Description: "The number of replica.",
8181
},
8282
"note": {
8383
Type: schema.TypeString,
8484
Computed: true,
85-
Description: "The subject note is a string of no more than 64 characters. It must start with a letter, and the remaining part can contain letters, numbers and dashes (-).",
85+
Description: "Topic note description.",
8686
},
8787
"create_time": {
8888
Type: schema.TypeString,
@@ -117,17 +117,17 @@ func dataSourceTencentCloudCkafkaTopics() *schema.Resource {
117117
"retention": {
118118
Type: schema.TypeInt,
119119
Computed: true,
120-
Description: "Message can be selected. Retention time, unit ms, the current minimum value is 60000ms.",
120+
Description: "Message can be selected. Retention time, unit ms.",
121121
},
122122
"sync_replica_min_num": {
123123
Type: schema.TypeInt,
124124
Computed: true,
125-
Description: "Min number of sync replicas, Default is 1.",
125+
Description: "Min number of sync replicas.",
126126
},
127127
"clean_up_policy": {
128128
Type: schema.TypeString,
129129
Computed: true,
130-
Description: "Clear log policy, log clear mode, the default is delete. delete: logs are deleted according to the storage time, compact: logs are compressed according to the key, compact, delete: logs are compressed according to the key and will be deleted according to the storage time.",
130+
Description: "Clear log policy, log clear mode. delete: logs are deleted according to the storage time, compact: logs are compressed according to the key, compact, delete: logs are compressed according to the key and will be deleted according to the storage time.",
131131
},
132132
"unclean_leader_election_enable": {
133133
Type: schema.TypeInt,
@@ -142,7 +142,7 @@ func dataSourceTencentCloudCkafkaTopics() *schema.Resource {
142142
"segment": {
143143
Type: schema.TypeInt,
144144
Computed: true,
145-
Description: "Segment scrolling time, in ms, the current minimum is 3600000ms.",
145+
Description: "Segment scrolling time, in ms.",
146146
},
147147
"segment_bytes": {
148148
Type: schema.TypeInt,
@@ -181,7 +181,6 @@ func dataSourceTencentCloudCkafkaTopicRead(d *schema.ResourceData, meta interfac
181181
ids := make([]string, 0, len(topicDetails))
182182

183183
for _, topic := range topicDetails {
184-
//configs := []*ckafka.Config{topic.Config}
185184
instance := map[string]interface{}{
186185
"topic_name": topic.TopicName,
187186
"topic_id": topic.TopicId,

0 commit comments

Comments
 (0)