Skip to content

Commit a0934e8

Browse files
authored
fix: cos resource context conflict (#1272)
1 parent 8373884 commit a0934e8

File tree

3 files changed

+14
-21
lines changed

3 files changed

+14
-21
lines changed

tencentcloud/data_source_tc_cos_buckets_test.go

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@ func TestAccTencentCloudCosBucketDataSource_tags(t *testing.T) {
3838
Providers: testAccProviders,
3939
Steps: []resource.TestStep{
4040
{
41-
Config: testAccCosBucketDataSource_tags(appid),
41+
Config: testAccCosBucketDataSource_tags(),
4242
Check: resource.ComposeAggregateTestCheckFunc(
43-
testAccCheckCosBucketExists("tencentcloud_cos_bucket.bucket_basic"),
4443
resource.TestMatchResourceAttr("data.tencentcloud_cos_buckets.bucket_list", "bucket_list.#", regexp.MustCompile(`^[1-9]\d*$`)),
45-
resource.TestCheckResourceAttr("data.tencentcloud_cos_buckets.bucket_list", "bucket_list.0.tags.test", "test"),
44+
resource.TestCheckResourceAttr("data.tencentcloud_cos_buckets.bucket_list", "bucket_list.0.tags.fixed_resource", "do_not_remove"),
4645
),
4746
},
4847
},
@@ -105,20 +104,13 @@ data "tencentcloud_cos_buckets" "bucket_list" {
105104
`, acctest.RandInt(), appid)
106105
}
107106

108-
func testAccCosBucketDataSource_tags(appid string) string {
107+
func testAccCosBucketDataSource_tags() string {
109108
return fmt.Sprintf(`
110-
resource "tencentcloud_cos_bucket" "bucket_basic" {
111-
bucket = "tf-tags-%d-%s"
112-
113-
tags = {
114-
"test" = "test"
115-
}
116-
}
117-
109+
%s
118110
data "tencentcloud_cos_buckets" "bucket_list" {
119-
tags = tencentcloud_cos_bucket.bucket_basic.tags
111+
tags = var.fixed_tags
120112
}
121-
`, acctest.RandInt(), appid)
113+
`, fixedTagVariable)
122114
}
123115

124116
func testAccCosBucketDataSource_full(appid string) string {

tencentcloud/resource_tc_cos_bucket_domain_certificate_attachment_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
)
1212

1313
func TestAccTencentCloudCosBucketDomainCertificate_basic(t *testing.T) {
14-
t.Parallel()
1514
id := new(string)
1615

1716
resource.Test(t, resource.TestCase{

tencentcloud/service_tencentcloud_cos.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,15 @@ func (me *CosService) PutBucket(ctx context.Context, bucket, acl string) (errRet
128128
}
129129
}()
130130
ratelimit.Check("CreateBucket")
131-
response, err := me.client.UseCosClient().CreateBucket(&request)
131+
client := me.client.UseCosClient()
132+
response, err := client.CreateBucket(&request)
132133
if err != nil {
133134
errRet = fmt.Errorf("cos put bucket error: %s, bucket: %s", err.Error(), bucket)
134135
return
135136
}
136137

137-
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n",
138-
logId, "put bucket", request.String(), response.String())
138+
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s], endpoint %s\n",
139+
logId, "put bucket", request.String(), response.String(), client.Endpoint)
139140

140141
return nil
141142
}
@@ -154,7 +155,8 @@ func (me *CosService) TencentCosPutBucket(ctx context.Context, bucket string, op
154155
}()
155156

156157
ratelimit.Check("TencentcloudCosPutBucket")
157-
response, err := me.client.UseTencentCosClient(bucket).Bucket.Put(ctx, opt)
158+
client := me.client.UseTencentCosClient(bucket)
159+
response, err := client.Bucket.Put(ctx, opt)
158160

159161
if err != nil {
160162
errRet = fmt.Errorf("cos put bucket error: %s, bucket: %s", err.Error(), bucket)
@@ -163,8 +165,8 @@ func (me *CosService) TencentCosPutBucket(ctx context.Context, bucket string, op
163165

164166
resp, _ := json.Marshal(response)
165167

166-
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n",
167-
logId, "put bucket", req, resp)
168+
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s], baseUrl %s\n",
169+
logId, "put bucket", req, resp, client.BaseURL.BucketURL)
168170

169171
return nil
170172
}

0 commit comments

Comments
 (0)