Skip to content

Commit b2460ec

Browse files
gitmknanonymous
andauthored
fix: modify bandwidth_package (#1367)
* fix: modify bandwidth_package * feat: add changelog Co-authored-by: anonymous <anonymous@mail.org>
1 parent 598c6dc commit b2460ec

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

.changelog/1367.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/tencentcloud_vpc_bandwidth_package: Handling api interface return is incorrect
3+
```

tencentcloud/resource_tc_vpc_bandwidth_package.go

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,23 @@ func resourceTencentCloudVpcBandwidthPackageCreate(d *schema.ResourceData, meta
126126
d.SetId(bandwidthPackageId)
127127

128128
ctx := context.WithValue(context.TODO(), logIdKey, logId)
129+
130+
if tags := helper.GetTags(d, "tags"); len(tags) > 0 {
131+
tagService := TagService{client: meta.(*TencentCloudClient).apiV3Conn}
132+
region := meta.(*TencentCloudClient).apiV3Conn.Region
133+
resourceName := fmt.Sprintf("qcs::vpc:%s:uin/:bandwidthPackage/%s", region, bandwidthPackageId)
134+
if err := tagService.ModifyTags(ctx, resourceName, tags, nil); err != nil {
135+
return err
136+
}
137+
}
138+
129139
service := VpcService{client: meta.(*TencentCloudClient).apiV3Conn}
130140
err = resource.Retry(3*readRetryTimeout, func() *resource.RetryError {
131141
instance, errRet := service.DescribeVpcBandwidthPackage(ctx, bandwidthPackageId)
132142
if errRet != nil {
133143
return retryError(errRet, InternalError)
134144
}
135-
if *instance.Status == "CREATED" {
145+
if instance != nil && *instance.Status == "CREATED" {
136146
return nil
137147
}
138148
return resource.RetryableError(fmt.Errorf("tmpInstance status is %v, retry...", *instance.Status))
@@ -141,14 +151,6 @@ func resourceTencentCloudVpcBandwidthPackageCreate(d *schema.ResourceData, meta
141151
return err
142152
}
143153

144-
if tags := helper.GetTags(d, "tags"); len(tags) > 0 {
145-
tagService := TagService{client: meta.(*TencentCloudClient).apiV3Conn}
146-
region := meta.(*TencentCloudClient).apiV3Conn.Region
147-
resourceName := fmt.Sprintf("qcs::vpc:%s:uin/:bandwidthPackage/%s", region, bandwidthPackageId)
148-
if err := tagService.ModifyTags(ctx, resourceName, tags, nil); err != nil {
149-
return err
150-
}
151-
}
152154
return resourceTencentCloudVpcBandwidthPackageRead(d, meta)
153155
}
154156

@@ -211,27 +213,19 @@ func resourceTencentCloudVpcBandwidthPackageUpdate(d *schema.ResourceData, meta
211213
request.BandwidthPackageId = &bandwidthPackageId
212214

213215
if d.HasChange("network_type") {
214-
215216
return fmt.Errorf("`network_type` do not support change now.")
216-
217217
}
218218

219219
if d.HasChange("bandwidth_package_count") {
220-
221220
return fmt.Errorf("`bandwidth_package_count` do not support change now.")
222-
223221
}
224222

225223
if d.HasChange("internet_max_bandwidth") {
226-
227224
return fmt.Errorf("`internet_max_bandwidth` do not support change now.")
228-
229225
}
230226

231227
if d.HasChange("protocol") {
232-
233228
return fmt.Errorf("`protocol` do not support change now.")
234-
235229
}
236230

237231
if d.HasChange("charge_type") {

0 commit comments

Comments
 (0)