Skip to content

Commit df1022a

Browse files
tongyimingmikatong
andauthored
fix sg_rule policy_index not effect (#1242)
Co-authored-by: mikatong <mikatong@tencent.com>
1 parent 5fb143b commit df1022a

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

tencentcloud/resource_tc_security_group_rule.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ func resourceTencentCloudSecurityGroupRuleCreate(d *schema.ResourceData, m inter
312312
}
313313
var policyIndex int64
314314
if v, ok := d.GetOk("policy_index"); ok {
315-
policyIndex = v.(int64)
315+
policyIndex = int64(v.(int))
316316
}
317317
info := securityGroupRuleBasicInfo{
318318
SgId: sgId,

tencentcloud/resource_tc_security_group_rule_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,13 @@ func TestAccTencentCloudSecurityGroupRule_basic(t *testing.T) {
2929
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in", "type", "ingress"),
3030
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in", "policy_index", "0"),
3131
resource.TestCheckNoResourceAttr("tencentcloud_security_group_rule.http-in", "source_sgid"),
32+
33+
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in1", "cidr_ip", "1.1.1.2"),
34+
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in1", "ip_protocol", "tcp"),
35+
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in1", "description", ""),
36+
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in1", "type", "ingress"),
37+
resource.TestCheckResourceAttr("tencentcloud_security_group_rule.http-in1", "policy_index", "1"),
38+
resource.TestCheckNoResourceAttr("tencentcloud_security_group_rule.http-in1", "source_sgid"),
3239
),
3340
},
3441
},
@@ -254,6 +261,15 @@ resource "tencentcloud_security_group_rule" "http-in" {
254261
policy = "accept"
255262
policy_index = 0
256263
}
264+
resource "tencentcloud_security_group_rule" "http-in1" {
265+
security_group_id = tencentcloud_security_group.foo.id
266+
type = "ingress"
267+
cidr_ip = "1.1.1.2"
268+
ip_protocol = "tcp"
269+
port_range = "80,8080"
270+
policy = "accept"
271+
policy_index = 1
272+
}
257273
`
258274

259275
const testAccSecurityGroupRuleConfigSSH = `

tencentcloud/service_tencentcloud_vpc.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,9 +1285,7 @@ func (me *VpcService) CreateSecurityGroupPolicy(ctx context.Context, info securi
12851285
if info.Protocol != nil {
12861286
policy.Protocol = common.StringPtr(strings.ToUpper(*info.Protocol))
12871287
}
1288-
if policy.PolicyIndex != nil {
1289-
policy.PolicyIndex = helper.Int64(info.PolicyIndex)
1290-
}
1288+
policy.PolicyIndex = helper.Int64(info.PolicyIndex)
12911289
policy.Port = info.PortRange
12921290
policy.PolicyDescription = info.Description
12931291
policy.Action = common.StringPtr(strings.ToUpper(info.Action))

0 commit comments

Comments
 (0)