add sweeper and change prefix for dcdb test case (#1377)

Author: lyu571

tencentcloud/data_source_tc_dcdb_accounts_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbAccountsDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBAccountsDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{
@@ -37,7 +37,7 @@ func TestAccTencentCloudDcdbAccountsDataSource(t *testing.T) {
 
 const testAccDataSourceDcdbAccounts = `
 resource "tencentcloud_dcdb_account" "basic" {
-	instance_id = "%s" # use the hard code before the dcdb_instance resource is ready.
+	instance_id = "%s"
 	user_name = "mysql_ds"
 	host = "127.0.0.1"
 	password = "===password==="

tencentcloud/data_source_tc_dcdb_databases_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbDatabasesDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBDatabasesDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/data_source_tc_dcdb_instances_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbInstancesDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBInstancesDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/data_source_tc_dcdb_parameters_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbParametersDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBParametersDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/data_source_tc_dcdb_security_groups_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbSecurityGroupsDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBSecurityGroupsDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/data_source_tc_dcdb_shards_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccTencentCloudDcdbShardsDataSource(t *testing.T) {
+func TestAccTencentCloudDCDBShardsDataSource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/resource_tc_dcdb_account_test.go

@@ -10,7 +10,44 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccTencentCloudDcdbAccountResource(t *testing.T) {
+func init() {
+	resource.AddTestSweepers("tencentcloud_dcdb_account", &resource.Sweeper{
+		Name: "tencentcloud_dcdb_account",
+		F:    testSweepDCDBAccount,
+	})
+}
+
+// go test -v ./tencentcloud -sweep=ap-guangzhou -sweep-run=tencentcloud_dcdb_account
+func testSweepDCDBAccount(r string) error {
+	logId := getLogId(contextNil)
+	ctx := context.WithValue(context.TODO(), logIdKey, logId)
+	cli, _ := sharedClientForRegion(r)
+	dcdbService := DcdbService{client: cli.(*TencentCloudClient).apiV3Conn}
+
+	account, err := dcdbService.DescribeDcdbAccount(ctx, defaultDcdbInstanceId, "")
+	if err != nil {
+		return err
+	}
+	if account == nil {
+		return fmt.Errorf("dcdb account not exists. instanceId:[%s]", defaultDcdbInstanceId)
+	}
+
+	for _, v := range account.Users {
+		err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+			err := dcdbService.DeleteDcdbAccountById(ctx, defaultDcdbInstanceId, *v.UserName, *v.Host)
+			if err != nil {
+				return retryError(err)
+			}
+			return nil
+		})
+		if err != nil {
+			return fmt.Errorf("[ERROR] delete dcdb account %s reason:[%s]", *v.UserName, err.Error())
+		}
+	}
+	return nil
+}
+
+func TestAccTencentCloudDCDBAccountResource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/resource_tc_dcdb_hourdb_instance_test.go

@@ -3,13 +3,56 @@ package tencentcloud
 import (
 	"context"
 	"fmt"
+	"strings"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccTencentCloudDcdbHourdbInstance_basic(t *testing.T) {
+func init() {
+	resource.AddTestSweepers("tencentcloud_dcdb_hourdb_instance", &resource.Sweeper{
+		Name: "tencentcloud_dcdb_hourdb_instance",
+		F:    testSweepDCDBHourdbInstance,
+	})
+}
+
+// go test -v ./tencentcloud -sweep=ap-guangzhou -sweep-run=tencentcloud_dcdb_hourdb_instance
+func testSweepDCDBHourdbInstance(r string) error {
+	logId := getLogId(contextNil)
+	ctx := context.WithValue(context.TODO(), logIdKey, logId)
+	cli, _ := sharedClientForRegion(r)
+	dcdbService := DcdbService{client: cli.(*TencentCloudClient).apiV3Conn}
+
+	instances, err := dcdbService.DescribeDcdbInstancesByFilter(ctx, nil)
+	if err != nil {
+		return err
+	}
+	if instances == nil {
+		return fmt.Errorf("dcdb hourdb instance not exists.")
+	}
+
+	for _, v := range instances {
+		delId := *v.InstanceId
+		delName := *v.InstanceName
+
+		if strings.HasPrefix(delName, "test_dcdc_") {
+			err := resource.Retry(readRetryTimeout, func() *resource.RetryError {
+				err := dcdbService.DeleteDcdbHourdbInstanceById(ctx, delId)
+				if err != nil {
+					return retryError(err)
+				}
+				return nil
+			})
+			if err != nil {
+				return fmt.Errorf("[ERROR] delete dcdb hourdb instance %s failed! reason:[%s]", delId, err.Error())
+			}
+		}
+	}
+	return nil
+}
+
+func TestAccTencentCloudDCDBHourdbInstance_basic(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{

tencentcloud/resource_tc_dcdb_security_group_attachment_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccTencentCloudDcdbSecurityGroupAttachmentResource(t *testing.T) {
+func TestAccTencentCloudDCDBSecurityGroupAttachmentResource(t *testing.T) {
 	t.Parallel()
 
 	resource.Test(t, resource.TestCase{