Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Commit 906885f

Browse files
author
Nikhil Thorat
authored
Turn off WEBGL_get_buffer_sub_data_async. (#849)
1 parent f76c264 commit 906885f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/environment.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,12 @@ function isFloatTextureReadPixelsEnabled(webGLVersion: number): boolean {
174174
}
175175

176176
function isWebGLGetBufferSubDataAsyncExtensionEnabled(webGLVersion: number) {
177+
// TODO(nsthorat): Remove this once we fix
178+
// https://github.com/PAIR-code/deeplearnjs/issues/848
179+
if (webGLVersion > 0) {
180+
return false;
181+
}
182+
177183
if (webGLVersion !== 2) {
178184
return false;
179185
}

src/environment_test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,10 @@ describe('WEBGL_GET_BUFFER_SUB_DATA_ASYNC_EXTENSION_ENABLED', () => {
150150

151151
const env = new Environment(features);
152152

153+
// TODO(nsthorat): Expect true when we fix
154+
// https://github.com/PAIR-code/deeplearnjs/issues/848
153155
expect(env.get('WEBGL_GET_BUFFER_SUB_DATA_ASYNC_EXTENSION_ENABLED'))
154-
.toBe(true);
156+
.toBe(false);
155157
});
156158

157159
it('WebGL 1 disabled', () => {

0 commit comments

Comments
 (0)