turbo for quote line item dates

thejonroberts · thejonroberts · commit 44e372203d4c · 2024-07-05T15:19:48.000-04:00
diff --git a/app/controllers/line_item_dates_controller.rb b/app/controllers/line_item_dates_controller.rb
@@ -10,7 +10,11 @@ def create
     @line_item_date = @quote.line_item_dates.build(line_item_date_params)
 
     if @line_item_date.save
-      redirect_to quote_path(@quote), notice: "Date was successfully created."
+      respond_to do |format|
+        notice = "Date was successfully created."
+        format.html { redirect_to quote_path(@quote), notice: }
+        format.turbo_stream { flash.now[:notice] = notice }
+      end
     else
       render :new, status: :unprocessable_entity
     end
@@ -21,17 +25,25 @@ def edit
 
   def update
     if @line_item_date.update(line_item_date_params)
-      redirect_to quote_path(@quote), notice: "Date was successfully updated."
+      respond_to do |format|
+        notice = "Date was successfully updated."
+        format.html { redirect_to quote_path(@quote), notice: }
+        format.turbo_stream { flash.now[:notice] = notice }
+      end
     else
       render :edit, status: :unprocessable_entity
     end
   end
 
   def destroy
-    @line_item_date.destroy
+  @line_item_date.destroy
 
-    redirect_to quote_path(@quote), notice: "Date was successfully destroyed."
+  respond_to do |format|
+    notice = "Date was successfully destroyed."
+    format.html { redirect_to quote_path(@quote), notice: }
+    format.turbo_stream { flash.now[:notice] = notice }
   end
+end
 
   private
 
diff --git a/app/models/line_item_date.rb b/app/models/line_item_date.rb
@@ -4,4 +4,8 @@ class LineItemDate < ApplicationRecord
   validates :date, presence: true, uniqueness: { scope: :quote_id }
 
   scope :ordered, -> { order(date: :asc) }
+
+  def previous_date
+    quote.line_item_dates.ordered.where("date < ?", date).last
+  end
 end
diff --git a/app/views/line_item_dates/_line_item_date.html.erb b/app/views/line_item_dates/_line_item_date.html.erb
@@ -1,19 +1,21 @@
-<div class="line-item-date">
-  <div class="line-item-date__header">
-    <h2 class="line-item-date__title">
-      <%= l(line_item_date.date, format: :long) %>
-    </h2>
+<%= turbo_frame_tag line_item_date do %>
+  <div class="line-item-date">
+    <div class="line-item-date__header">
+      <h2 class="line-item-date__title">
+        <%= l(line_item_date.date, format: :long) %>
+      </h2>
 
-    <div class="line-item-date__actions">
-      <%# NOTE: polymorphic routes https://api.rubyonrails.org/classes/ActionDispatch/Routing/PolymorphicRoutes.html %>
-      <%= button_to "Delete",
-              quote_line_item_date_path(quote, line_item_date),
-              method: :delete,
-              form: { data: { turbo_confirm: "Are you sure?" } },
-              class: "btn btn--light" %>
-      <%= link_to "Edit",
-                  [:edit, quote, line_item_date],
-                  class: "btn btn--light" %>
+      <div class="line-item-date__actions">
+        <%# NOTE: polymorphic routes https://api.rubyonrails.org/classes/ActionDispatch/Routing/PolymorphicRoutes.html %>
+        <%= button_to "Delete",
+                quote_line_item_date_path(quote, line_item_date),
+                method: :delete,
+                form: { data: { turbo_confirm: "Are you sure?" } },
+                class: "btn btn--light" %>
+        <%= link_to "Edit",
+                    [:edit, quote, line_item_date],
+                    class: "btn btn--light" %>
+      </div>
     </div>
   </div>
-</div>
+<% end %>
diff --git a/app/views/line_item_dates/create.turbo_stream.erb b/app/views/line_item_dates/create.turbo_stream.erb
@@ -0,0 +1,15 @@
+<%# Step 1: remove the form from the Quotes#index page %>
+<%= turbo_stream.update LineItemDate.new, "" %>
+
+<%# Step 2: add the date at the right place %>
+<% if previous_date = @line_item_date.previous_date %>
+  <%= turbo_stream.after previous_date do %>
+    <%= render @line_item_date, quote: @quote %>
+  <% end %>
+<% else %>
+  <%= turbo_stream.prepend "line_item_dates" do %>
+    <%= render @line_item_date, quote: @quote %>
+  <% end %>
+<% end %>
+
+<%= render_turbo_stream_flash_messages %>
diff --git a/app/views/line_item_dates/destroy.turbo_stream.erb b/app/views/line_item_dates/destroy.turbo_stream.erb
@@ -0,0 +1,2 @@
+<%= turbo_stream.remove @line_item_date %>
+<%= render_turbo_stream_flash_messages %>
diff --git a/app/views/line_item_dates/edit.html.erb b/app/views/line_item_dates/edit.html.erb
@@ -5,5 +5,7 @@
     <h1>Edit date</h1>
   </div>
 
-  <%= render "form", quote: @quote, line_item_date: @line_item_date %>
+  <%= turbo_frame_tag @line_item_date do %>
+    <%= render "form", quote: @quote, line_item_date: @line_item_date %>
+  <% end %>
 </main>
diff --git a/app/views/line_item_dates/new.html.erb b/app/views/line_item_dates/new.html.erb
@@ -5,5 +5,7 @@
     <h1>New date</h1>
   </div>
 
-  <%= render "form", quote: @quote, line_item_date: @line_item_date %>
+  <%= turbo_frame_tag @line_item_date do %>
+    <%= render "form", quote: @quote, line_item_date: @line_item_date %>
+  <% end %>
 </main>
diff --git a/app/views/line_item_dates/update.turbo_stream.erb b/app/views/line_item_dates/update.turbo_stream.erb
@@ -0,0 +1,13 @@
+<%= turbo_stream.remove @line_item_date %>
+
+<% if previous_date = @line_item_date.previous_date %>
+  <%= turbo_stream.after previous_date do %>
+    <%= render @line_item_date, quote: @quote %>
+  <% end %>
+<% else %>
+  <%= turbo_stream.prepend "line_item_dates" do %>
+    <%= render @line_item_date, quote: @quote %>
+  <% end %>
+<% end %>
+
+<%= render_turbo_stream_flash_messages %>
diff --git a/app/views/quotes/_form.html.erb b/app/views/quotes/_form.html.erb
@@ -23,7 +23,7 @@ COMMENT
 %>
 
 <%= simple_form_for quote, html: { class: "quote form" } do |f| %>
-  <%= form_error_notification(line_item_date) %>
+  <%= form_error_notification(quote) %>
 
   <%= f.input :name, input_html: { autofocus: true } %>
   <%= link_to "Cancel", quotes_path, class: "btn btn--light" %>
diff --git a/app/views/quotes/show.html.erb b/app/views/quotes/show.html.erb
@@ -23,8 +23,12 @@ COMMENT
     </h1>
     <%= link_to "New date",
                 new_quote_line_item_date_path(@quote),
+                data: { turbo_frame: dom_id(LineItemDate.new) },
                 class: "btn btn--primary" %>
   </div>
 
-  <%= render @line_item_dates, quote: @quote %>
+  <%= turbo_frame_tag LineItemDate.new %>
+  <%= turbo_frame_tag "line_item_dates" do %>
+    <%= render @line_item_dates, quote: @quote %>
+  <% end %>
 </main>
diff --git a/test/models/line_item_date_test.rb b/test/models/line_item_date_test.rb
@@ -1,7 +1,11 @@
 require "test_helper"
 
 class LineItemDateTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+  test "#previous_date returns the quote's previous date when it exitsts" do
+    assert_equal line_item_dates(:today), line_item_dates(:next_week).previous_date
+  end
+
+  test "#previous_date returns nil when the quote has no previous date" do
+    assert_nil line_item_dates(:today).previous_date
+  end
 end
diff --git a/test/system/line_item_dates_test.rb b/test/system/line_item_dates_test.rb
@@ -0,0 +1,50 @@
+require "application_system_test_case"
+
+class LineItemDatesTest < ApplicationSystemTestCase
+  setup do
+    login_as users(:accountant)
+
+    @quote          = quotes(:one)
+    @line_item_date = line_item_dates(:today)
+
+    visit quote_path(@quote)
+  end
+
+  test "Creating a new line item date" do
+    assert_selector "h1", text: "First quote"
+
+    click_on "New date"
+    assert_selector "h1", text: "First quote"
+    fill_in "Date", with: Date.current + 1.day
+
+    click_on "Create date"
+    assert_text I18n.l(Date.current + 1.day, format: :long)
+  end
+
+  test "Updating a line item date" do
+    assert_selector "h1", text: "First quote"
+
+    within id: dom_id(@line_item_date) do
+      click_on "Edit"
+    end
+
+    assert_selector "h1", text: "First quote"
+
+    fill_in "Date", with: Date.current + 1.day
+    click_on "Update date"
+
+    assert_text I18n.l(Date.current + 1.day, format: :long)
+  end
+
+  test "Destroying a line item date" do
+    assert_text I18n.l(Date.current, format: :long)
+
+    accept_confirm do
+      within id: dom_id(@line_item_date) do
+        click_on "Delete"
+      end
+    end
+
+    assert_no_text I18n.l(Date.current, format: :long)
+  end
+end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<%= turbo_stream.remove @line_item_date %>`
	`2`	`+<%= render_turbo_stream_flash_messages %>`