Removing no needed types

Author: whiskey-coder

src/PostgresLazyTransaction.php

@@ -38,25 +38,15 @@ public function __construct(
 
     public function recordOutboxes(array $outboxes): void
     {
-        /**
-         * @var list<string> $insertData
-         */
         $insertData = [];
 
-        /**
-         * @var list<string> $placeholders
-         */
         $placeholders = [];
-        /**
-         * @var Outbox $outbox
-         */
+
         foreach ($outboxes as $outbox) {
-            array_push($insertData,
-                $this->endpoint->toString(),
-                $outbox->incomingMessageId,
-                new PostgresByteA(serialize($outbox->commands)),
-                new PostgresByteA(serialize($outbox->events)),
-            );
+            $insertData[] = $this->endpoint->toString();
+            $insertData[] = $outbox->incomingMessageId;
+            $insertData[] = new PostgresByteA(serialize($outbox->commands));
+            $insertData[] = new PostgresByteA(serialize($outbox->events));
 
             $placeholders[] = '(?, ?, ?, ?,' . ($outbox->dispatched ? 'now()' : 'null') . ')';
         }
@@ -72,13 +62,13 @@ public function recordOutboxes(array $outboxes): void
                     SQL,
                 $insertData,
             );
-
-            if ($result->getRowCount() !== count($outboxes)) {
-                throw new OutboxAlreadyExists();
-            }
         } catch (SqlTransactionError $exception) {
             throw new TransactionClosed(previous: $exception);
         }
+
+        if ($result->getRowCount() !== count($outboxes)) {
+            throw new OutboxAlreadyExists();
+        }
     }
 
     public function commitIfBegun(): void

src/PostgresStorage.php

@@ -28,8 +28,8 @@ final class PostgresStorage implements Storage
      * @param non-empty-string $outboxTable
      */
     public function __construct(
-        private PostgresLink $postgres,
-        private string $outboxTable = 'outbox',
+        private readonly PostgresLink $postgres,
+        private readonly string $outboxTable = 'outbox',
     ) {}
 
     public function setup(): void
@@ -50,9 +50,6 @@ public function setup(): void
         );
     }
 
-    /**
-     * @return LazyTransaction<AmphpPostgresTransaction>
-     */
     public function createLazyTransaction(Endpoint $endpoint): LazyTransaction
     {
         return new PostgresLazyTransaction(
@@ -77,9 +74,6 @@ public function findOutboxes(Endpoint $endpoint, array $incomingMessageIds): arr
                 [$endpoint->toString(), ...$incomingMessageIds],
             );
 
-        /**
-         * @var list<Outbox> $outboxes
-         */
         $outboxes = [];
 
         while (null !== $row = $result->fetchRow()) {