Skip to content

Commit d551863

Browse files
committed
Use tempfile's naming generator to create session/window names
1 parent f1e2f31 commit d551863

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

tmuxp/testsuite/helpers.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
import logging
1616
import os
1717
import sys
18+
import tempfile
1819
from contextlib import contextmanager
19-
from random import randint
2020

2121
from tmuxp import exc
2222
from tmuxp.testsuite import t
@@ -30,18 +30,20 @@
3030

3131
TEST_SESSION_PREFIX = 'test tmuxp_'
3232

33+
namer = tempfile._RandomNameSequence()
34+
3335

3436
def get_test_session_name(server, prefix=TEST_SESSION_PREFIX):
3537
while True:
36-
session_name = prefix + str(randint(0, 9999999))
38+
session_name = prefix + next(namer)
3739
if not t.has_session(session_name):
3840
break
3941
return session_name
4042

4143

4244
def get_test_window_name(session, prefix=TEST_SESSION_PREFIX):
4345
while True:
44-
window_name = prefix + str(randint(0, 9999999))
46+
window_name = prefix + next(namer)
4547
if not session.findWhere(window_name=window_name):
4648
break
4749
return window_name

tmuxp/testsuite/session.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
import logging
1313
import unittest
14-
from random import randint
1514

1615
from tmuxp import Pane, Session, Window
1716
from tmuxp.testsuite import t
18-
from tmuxp.testsuite.helpers import TEST_SESSION_PREFIX, TmuxTestCase
17+
from tmuxp.testsuite.helpers import TEST_SESSION_PREFIX, TmuxTestCase, namer
1918

2019
logger = logging.getLogger(__name__)
2120

@@ -99,7 +98,7 @@ class SessionNewTest(TmuxTestCase):
9998

10099
def test_new_session(self):
101100
"""Server.new_session creates new session."""
102-
new_session_name = TEST_SESSION_PREFIX + str(randint(0, 1337))
101+
new_session_name = TEST_SESSION_PREFIX + next(namer)
103102
new_session = t.new_session(session_name=new_session_name, detach=True)
104103

105104
self.assertIsInstance(new_session, Session)

tmuxp/testsuite/tmuxobject.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,11 @@
1010
unicode_literals, with_statement)
1111

1212
import logging
13-
import random
1413
import unittest
1514

1615
from tmuxp import Pane, Session, Window
1716
from tmuxp.testsuite import t
18-
from tmuxp.testsuite.helpers import TEST_SESSION_PREFIX, TmuxTestCase
17+
from tmuxp.testsuite.helpers import TEST_SESSION_PREFIX, TmuxTestCase, namer
1918

2019
logger = logging.getLogger(__name__)
2120

@@ -62,9 +61,7 @@ def test_findWhere_None(self):
6261
""".findWhere returns None if no results found."""
6362

6463
while True:
65-
nonexistant_session = TEST_SESSION_PREFIX + str(
66-
random.randint(0, 9999)
67-
)
64+
nonexistant_session = TEST_SESSION_PREFIX + next(namer)
6865

6966
if not t.has_session(nonexistant_session):
7067
break
@@ -176,7 +173,7 @@ def test_getById(self):
176173
self.assertEqual(get_by_id, session)
177174
self.assertIsInstance(get_by_id, Session)
178175
self.assertIsNone(t.getById(
179-
'$' + str(random.randint(50000, 90000))
176+
'$' + next(namer)
180177
))
181178

182179
# session.getById
@@ -189,7 +186,7 @@ def test_getById(self):
189186
self.assertIsInstance(get_by_id, Window)
190187

191188
self.assertIsNone(session.getById(
192-
'@' + str(random.randint(50000, 90000))
189+
'@' + next(namer)
193190
))
194191

195192
# window.getById
@@ -201,7 +198,7 @@ def test_getById(self):
201198
self.assertEqual(get_by_id, pane)
202199
self.assertIsInstance(get_by_id, Pane)
203200
self.assertIsNone(window.getById(
204-
'%' + str(random.randint(50000, 90000))
201+
'%' + next(namer)
205202
))
206203

207204

0 commit comments

Comments
 (0)