Fail the build when noEmitOnError is set and there's a type error

Author: dfreeman

appveyor.yml

@@ -21,7 +21,7 @@ install:
   - yarn
 
 cache:
-#  - "%LOCALAPPDATA%\\Yarn"
+  - "%LOCALAPPDATA%\\Yarn"
 
 # Post-install test scripts.
 test_script:

lib/incremental-typescript-compiler.js

@@ -34,9 +34,11 @@ module.exports = class IncrementalTypescriptCompiler {
 
     this._buildDeferred = RSVP.defer();
     this._isSynced = false;
+    this._pendingErrors = [];
     this._triggerDir = `${this.outDir()}/.rebuild`;
     this._pendingAutoresolve = null;
     this._didAutoresolve = false;
+    this._watchProgram = null;
   }
 
   treeForHost() {
@@ -108,7 +110,7 @@ module.exports = class IncrementalTypescriptCompiler {
     let project = this.project;
     let outDir = this.outDir();
 
-    compile(project, { outDir, watch: true }, {
+    this._watchProgram = compile(project, { outDir, watch: true }, {
       reportWatchStatus: (diagnostic) => {
         let text = diagnostic.messageText;
 
@@ -135,11 +137,17 @@ module.exports = class IncrementalTypescriptCompiler {
 
       reportDiagnostic: (diagnostic) => {
         if (diagnostic.category !== 2) {
-          this.project.ui.write(ts.formatDiagnostic(diagnostic, {
+          let message = ts.formatDiagnostic(diagnostic, {
             getCanonicalFileName: path => path,
             getCurrentDirectory: ts.sys.getCurrentDirectory,
             getNewLine: () => ts.sys.newLine,
-          }));
+          });
+
+          if (this._shouldFailOnTypeError()) {
+            this.didError(message);
+          } else {
+            this.project.ui.write(message);
+          }
         }
       }
     });
@@ -163,9 +171,27 @@ module.exports = class IncrementalTypescriptCompiler {
     }
   }
 
+  didError(message) {
+    this._pendingErrors.push(message);
+  }
+
   didSync() {
     this._isSynced = true;
-    this._buildDeferred.resolve();
+    if (this._pendingErrors.length) {
+      this._buildDeferred.reject(new Error(this._pendingErrors.join('\n')));
+      this._pendingErrors = [];
+    } else {
+      this._buildDeferred.resolve();
+    }
+  }
+
+  getProgram() {
+    return this._watchProgram.getProgram();
+  }
+
+  _shouldFailOnTypeError() {
+    let options = this.getProgram().getCompilerOptions();
+    return !!options.noEmitOnError;
   }
 
   _mirageDirectory() {

lib/utilities/compile.js

@@ -23,13 +23,24 @@ module.exports = function compile(project, tsOptions, callbacks) {
     fullOptions,
     buildWatchHooks(ts.sys),
     createProgram,
-    callbacks.reportDiagnostic,
-    callbacks.reportWatchStatus
+    diagnosticCallback(callbacks.reportDiagnostic),
+    diagnosticCallback(callbacks.reportWatchStatus)
   );
 
   return ts.createWatchProgram(host);
 };
 
+function diagnosticCallback(callback) {
+  if (callback) {
+    // The initial callbacks may be synchronously invoked during instantiation of the
+    // WatchProgram, which is annoying if those callbacks want to _reference_ it, so
+    // we always force invocation to be asynchronous for consistency.
+    return (diagnostic) => {
+      process.nextTick(() => callback(diagnostic));
+    };
+  }
+}
+
 function buildWatchHooks(sys) {
   let watchedFiles = new Map();
 
@@ -48,7 +59,7 @@ function buildWatchHooks(sys) {
       if (!fs.existsSync(dir)) return;
 
       let ignored = /\/(\..*?|dist|node_modules|tmp)\//;
-      let watcher = chokidar.watch(dir, { ignored });
+      let watcher = chokidar.watch(dir, { ignored, ignoreInitial: true });
 
       watcher.on('all', (type, path) => {
         path = path.replace(/\\/g, '/'); // Normalize Windows