Emit warning diagnostics (e.g. type errors) and clean up comment-out code

Author: dfreeman

lib/incremental-typescript-compiler.js

@@ -16,12 +16,6 @@ const ts = require('typescript');
 const debugCompiler = require('debug')('ember-cli-typescript:compiler');
 const debugAutoresolve = require('debug')('ember-cli-typescript:autoresolve');
 
-const formatHost = {
-  getCanonicalFileName: path => path,
-  getCurrentDirectory: ts.sys.getCurrentDirectory,
-  getNewLine: () => ts.sys.newLine,
-};
-
 module.exports = class IncrementalTypescriptCompiler {
   constructor(app, project) {
     if (project._incrementalTsCompiler) {
@@ -113,7 +107,8 @@ module.exports = class IncrementalTypescriptCompiler {
 
     let project = this.project;
     let outDir = this.outDir();
-    let tsc = compile(project, { outDir, watch: true }, {
+
+    compile(project, { outDir, watch: true }, {
       reportWatchStatus: (diagnostic) => {
         let text = diagnostic.messageText;
 
@@ -139,46 +134,15 @@ module.exports = class IncrementalTypescriptCompiler {
       },
 
       reportDiagnostic: (diagnostic) => {
-        // if (diagnostic.category !== 2) {
-        //   this.project.ui.write(ts.formatDiagnostic(diagnostic, formatHost));
-        // }
+        if (diagnostic.category !== 2) {
+          this.project.ui.write(ts.formatDiagnostic(diagnostic, {
+            getCanonicalFileName: path => path,
+            getCurrentDirectory: ts.sys.getCurrentDirectory,
+            getNewLine: () => ts.sys.newLine,
+          }));
+        }
       }
     });
-
-    // tsc.stdout.on('data', data => {
-    //   let text = data
-    //     .toString()
-    //     .trim()
-    //     .replace(/\u001bc/g, '');
-
-    //   if (text) {
-    //     this.project.ui.writeLine(text);
-    //   }
-
-    //   if (data.indexOf('Starting incremental compilation') !== -1) {
-    //     debugCompiler('tsc detected a file change');
-    //     this.willRebuild();
-    //     clearTimeout(this._pendingAutoresolve);
-    //   }
-
-    //   if (data.indexOf('Compilation complete') !== -1) {
-    //     debugCompiler('rebuild completed');
-
-    //     this.didSync();
-
-    //     if (this._didAutoresolve) {
-    //       this._touchRebuildTrigger();
-    //       this.maxBuildCount++;
-    //     }
-
-    //     clearTimeout(this._pendingAutoresolve);
-    //     this._didAutoresolve = false;
-    //   }
-    // });
-
-    // tsc.stderr.on('data', data => {
-    //   this.project.ui.writeError(data.toString().trim());
-    // });
   }
 
   willRebuild() {