Skip to content

Commit defc02b

Browse files
committed
chore: check ember-cli-babel against our new minimum version
1 parent c2ebe19 commit defc02b

File tree

3 files changed

+2457
-2985
lines changed

3 files changed

+2457
-2985
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
"ember-cli-addon-docs": "ember-learn/ember-cli-addon-docs#4f5bfd11",
8484
"ember-cli-addon-docs-esdoc": "0.2.3",
8585
"ember-cli-app-version": "3.2.0",
86-
"ember-cli-babel": "7.13.2",
86+
"ember-cli-babel": "7.17.0",
8787
"ember-cli-blueprint-test-helpers": "0.19.2",
8888
"ember-cli-dependency-checker": "3.2.0",
8989
"ember-cli-deploy": "1.0.2",

ts/addon.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,10 @@ export default addon({
7878
let babel = this.parent.addons.find(addon => addon.name === 'ember-cli-babel');
7979
let version = babel && babel.pkg.version;
8080

81-
// TODO update this check and warning message once we have a Babel version to target
82-
if (!babel || !(semver.gte(version!, '7.7.3') && semver.lt(version!, '8.0.0'))) {
81+
if (!babel || !(semver.gte(version!, '7.17.0') && semver.lt(version!, '8.0.0'))) {
8382
let versionString = babel ? `version ${babel.pkg.version}` : `no instance of ember-cli-babel`;
8483
this.ui.writeWarnLine(
85-
`ember-cli-typescript requires ember-cli-babel ^7.7.3, but you have ${versionString} installed; ` +
84+
`ember-cli-typescript requires ember-cli-babel ^7.17.0, but you have ${versionString} installed; ` +
8685
'your TypeScript files may not be transpiled correctly.'
8786
);
8887
}

0 commit comments

Comments
 (0)