Merge pull request #110 from typed-ember/moar-generators

Acceptance test generator

Author: chriskrycho

.travis.yml

@@ -35,10 +35,10 @@ install:
 
 script:
   - yarn lint:js
+  - yarn ember try:one integrated-node-tests
   # Usually, it's ok to finish the test scenario without reverting
   #  to the addon's original dependency state, skipping "cleanup".
-  - node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
-  - yarn run nodetest
+  - yarn ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
 
 # We build PRs, but don't trigger separate builds for the PR from the branch.
 branches:

appveyor.yml

@@ -28,7 +28,7 @@ test_script:
   # Output useful info for debugging.
   - yarn versions
   - cmd: yarn ember try:one ember-release
-  - cmd: yarn run nodetest
+  - cmd: yarn ember try:one integrated-node-tests
 
 # Don't actually build.
 build: off

blueprints/acceptance-test/index.js

@@ -0,0 +1,35 @@
+'use strict';
+
+const path = require('path');
+const pathUtil = require('ember-cli-path-utils');
+const stringUtils = require('ember-cli-string-utils');
+const existsSync = require('exists-sync');
+
+const useTestFrameworkDetector = require('../test-framework-detector');
+
+module.exports = useTestFrameworkDetector({
+  description: 'Generates an acceptance test for a feature.',
+
+  locals: function(options) {
+    let testFolderRoot = stringUtils.dasherize(options.project.name());
+
+    if (options.project.isEmberCLIAddon()) {
+      testFolderRoot = pathUtil.getRelativeParentPath(options.entity.name, -1, false);
+    }
+
+    let destroyAppExists = existsSync(
+      path.join(this.project.root, '/tests/helpers/destroy-app.js')
+    );
+
+    let friendlyTestName = [
+      'Acceptance',
+      stringUtils.dasherize(options.entity.name).replace(/[-]/g, ' '),
+    ].join(' | ');
+
+    return {
+      testFolderRoot: testFolderRoot,
+      friendlyTestName,
+      destroyAppExists: destroyAppExists,
+    };
+  },
+});

blueprints/acceptance-test/mocha-files/tests/acceptance/__name__-test.ts

@@ -0,0 +1,24 @@
+import { describe, it, beforeEach, afterEach } from 'mocha';
+import { expect } from 'chai';
+import startApp from '<%= dasherizedPackageName %>/tests/helpers/start-app';
+<% if (destroyAppExists) { %>import destroyApp from '<%= dasherizedPackageName %>/tests/helpers/destroy-app';<% } else { %>import { run } from '@ember/runloop';<% } %>
+
+describe('<%= friendlyTestName %>', function() {
+  let application;
+
+  beforeEach(function() {
+    application = startApp();
+  });
+
+  afterEach(function() {
+    <% if (destroyAppExists) { %>destroyApp(application);<% } else { %>run(application, 'destroy');<% } %>
+  });
+
+  it('can visit /<%= dasherizedModuleName %>', function() {
+    visit('/<%= dasherizedModuleName %>');
+
+    return andThen(() => {
+      expect(currentURL()).to.equal('/<%= dasherizedModuleName %>');
+    });
+  });
+});

blueprints/acceptance-test/qunit-files/tests/acceptance/__name__-test.ts

@@ -0,0 +1,12 @@
+import { test } from 'qunit';
+import moduleForAcceptance from '<%= testFolderRoot %>/tests/helpers/module-for-acceptance';
+
+moduleForAcceptance('<%= friendlyTestName %>');
+
+test('visiting /<%= dasherizedModuleName %>', function(assert) {
+  visit('/<%= dasherizedModuleName %>');
+
+  andThen(function() {
+    assert.equal(currentURL(), '/<%= dasherizedModuleName %>');
+  });
+});

blueprints/acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.ts

@@ -0,0 +1,13 @@
+import { module, test } from 'qunit';
+import { visit, currentURL } from '@ember/test-helpers';
+import { setupApplicationTest } from 'ember-qunit';
+
+module('<%= friendlyTestName %>', function(hooks) {
+  setupApplicationTest(hooks);
+
+  test('visiting /<%= dasherizedModuleName %>', async function(assert) {
+    await visit('/<%= dasherizedModuleName %>');
+
+    assert.equal(currentURL(), '/<%= dasherizedModuleName %>');
+  });
+});

config/ember-try.js

@@ -1,6 +1,15 @@
 module.exports = {
   useYarn: true,
   scenarios: [
+    {
+      name: 'integrated-node-tests',
+      command: 'yarn nodetest',
+      npm: {
+        devDependencies: {
+          'ember-cli-qunit': null,
+        },
+      },
+    },
     {
       name: 'ember-lts-2.12',
       npm: {

node-tests/blueprints/acceptance-test-test.js

@@ -0,0 +1,102 @@
+'use strict';
+
+const blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
+const setupTestHooks = blueprintHelpers.setupTestHooks;
+const emberNew = blueprintHelpers.emberNew;
+const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
+const modifyPackages = blueprintHelpers.modifyPackages;
+
+const chai = require('ember-cli-blueprint-test-helpers/chai');
+const expect = chai.expect;
+
+const generateFakePackageManifest = require('../helpers/generate-fake-package-manifest');
+const fixture = require('../helpers/fixture');
+
+describe('Blueprint: acceptance-test', function() {
+  setupTestHooks(this);
+
+  describe('in app', function() {
+    beforeEach(function() {
+      return emberNew();
+    });
+
+    it('acceptance-test foo', function() {
+      return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+        expect(_file('tests/acceptance/foo-test.ts')).to.equal(
+          fixture('acceptance-test/default.ts')
+        );
+      });
+    });
+
+    describe('with ember-cli-qunit@4.2.0', function() {
+      beforeEach(function() {
+        generateFakePackageManifest('ember-cli-qunit', '4.2.0');
+      });
+
+      it('acceptance-test foo', function() {
+        return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+          expect(_file('tests/acceptance/foo-test.ts')).to.equal(
+            fixture('acceptance-test/qunit-rfc268.ts')
+          );
+        });
+      });
+    });
+
+    describe('with ember-cli-mocha', function() {
+      beforeEach(function() {
+        return modifyPackages([
+          { name: 'ember-cli-qunit', delete: true },
+          { name: 'ember-cli-mocha', dev: true },
+        ]);
+      });
+
+      it('acceptance-test foo', function() {
+        return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+          expect(_file('tests/acceptance/foo-test.ts')).to.equal(
+            fixture('acceptance-test/mocha.ts')
+          );
+        });
+      });
+    });
+  });
+
+  describe('in addon', function() {
+    beforeEach(function() {
+      return emberNew({ target: 'addon' });
+    });
+
+    it('acceptance-test foo', function() {
+      return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+        expect(_file('tests/acceptance/foo-test.ts')).to.equal(
+          fixture('acceptance-test/addon-default.ts')
+        );
+
+        expect(_file('app/acceptance-tests/foo.ts')).to.not.exist;
+      });
+    });
+
+    it('acceptance-test foo/bar', function() {
+      return emberGenerateDestroy(['acceptance-test', 'foo/bar'], _file => {
+        expect(_file('tests/acceptance/foo/bar-test.ts')).to.equal(
+          fixture('acceptance-test/addon-nested.ts')
+        );
+
+        expect(_file('app/acceptance-tests/foo/bar.ts')).to.not.exist;
+      });
+    });
+
+    describe('with ember-cli-qunit@4.2.0', function() {
+      beforeEach(function() {
+        generateFakePackageManifest('ember-cli-qunit', '4.2.0');
+      });
+
+      it('acceptance-test foo', function() {
+        return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+          expect(_file('tests/acceptance/foo-test.ts')).to.equal(
+            fixture('acceptance-test/qunit-rfc268.ts')
+          );
+        });
+      });
+    });
+  });
+});

node-tests/fixtures/acceptance-test/.eslintrc.js

@@ -0,0 +1,7 @@
+module.exports = {
+  globals: {
+    andThen: false,
+    visit: false,
+    currentURL: false
+  }
+}

node-tests/fixtures/acceptance-test/addon-default.ts

@@ -0,0 +1,12 @@
+import { test } from 'qunit';
+import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
+
+moduleForAcceptance('Acceptance | foo');
+
+test('visiting /foo', function(assert) {
+  visit('/foo');
+
+  andThen(function() {
+    assert.equal(currentURL(), '/foo');
+  });
+});