Skip to content

Commit fb5c3bc

Browse files
committed
Merge branch 'master' into programmatic-compilation
2 parents b976adc + c723f95 commit fb5c3bc

File tree

6 files changed

+1241
-1177
lines changed

6 files changed

+1241
-1177
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
66

77
## [Unreleased]
88

9+
## [1.2.1] - 2018-03-14
10+
11+
### Fixed
12+
13+
* Blueprint now correctly adds ember-cli-typescript as a dependency, allowing TS to be merged into the regular app tree.
14+
915
## [1.2.0] - 2018-03-05
1016

1117
### Added

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ If you're using [ember-browserify], you're used to writing imports like this:
430430
import MyModule from 'npm:my-module';
431431
```
432432

433-
If the `my-module` has types, you will not be able to resolve them this way by default. You can add a simple tweak to your `tsconfig.json` to resolve the types correctly, hwowever:
433+
If the `my-module` has types, you will not be able to resolve them this way by default. You can add a simple tweak to your `tsconfig.json` to resolve the types correctly, however:
434434

435435
```json
436436
{

blueprints/in-repo-addon/files/lib/__name__/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,8 @@
22
"name": "<%= dasherizedModuleName %>",
33
"keywords": [
44
"ember-addon"
5-
]
5+
],
6+
"devDependencies": {
7+
"ember-cli-typescript": "*"
8+
}
69
}

known-typings.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ to ask for help in the [Ember Community Slack] ([get an invite]).
1616

1717
(Someday soon this list should get _long and awesome_! Help us make it happen!)
1818

19+
* [ember-test-friendly-error-handler](https://github.com/rwjblue/ember-test-friendly-error-handler)
1920
* [True Myth](https://github.com/chriskrycho/true-myth)
2021

2122
## DefinitelyTyped (`@types`)

node-tests/blueprints/in-repo-addon-test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ describe('Acceptance: ember generate and destroy in-repo-addon', function() {
4242
"keywords": [
4343
"ember-addon",
4444
],
45+
"devDependencies": {
46+
"ember-cli-typescript": "*"
47+
}
4548
});
4649

4750
expect(fs.readJsonSync('package.json')['ember-addon']).to.deep.equal({

0 commit comments

Comments
 (0)