question: Inheriting feature does not work as i expect, whenever i activate the whitelist

[kasir-barati]

I was trying to use whitelist alongside the inheriting
I have a dto, this dto would be used whenever the common user trys to create a user:

class CreateUserDto {
  @IsString()
  name: string;
}

And admin can create user too, but admin can specify more fields:

class AdminCreateUserDto extends CreateUserDto {
  @IsNumber()
  credit: number;
}

now In the controller I have:

// first scenario: disabled whaitelist
async adminCreateUser(@Body({ validate: { whitelist: false } }) user: AdminCreateUserDto) {
  /*
   * POST /users
   * body: { name: "nodejs", credit: 1000 }
   */
  console.log(user); // { name: "nodejs", credit: 1000 }
}
 
// second scenario: acvtived whitelist
async adminCreateUser(@Body({ validate: { whitelist: true } }) user: AdminCreateUserDto) {
  /*
   * POST /users
   * body: { name: "as", credit: 1000 }
   */
  console.log(user); // { credit: 1000 }
}

The problem:
As you can see I do not have the name field. My expectation is to get the same result in the second scenario.

• Node: v14.17.6
• npm: 6.14.15
• class-validator: ^0.13.1

[kasir-barati]

@jackjennings , @bogdan , @dooman87 , @nolazybits

This is a serious problem for me. if it's possible, fix this issue.

[braaar]

This could possibly be fixed by #748, as inheritance in general is not entirely stable.

Have you fiddled around with other decorators to see if the behaviour changes based on the decorator used? Apparently inheritance only works with certain decorators, which could cause this issue where the whitelist thinks there is no decorator and thus skips the field in the subclass.