Change to do some to-dos

Author: wooorm

crawl/ecosystem.js

@@ -101,15 +101,15 @@
  *
  *
  * @typedef PackageInfo
- * @property {string} description
+ * @property {string | undefined} description
  * @property {Array<string>} keywords
  * @property {string | undefined} latest
  * @property {string | undefined} license
  * @property {string} name
  * @property {number} score
  *
  * @typedef RawPackage
- * @property {string} description
+ * @property {string | undefined} description
  * @property {number} downloads
  * @property {number | undefined} [gzip]
  * @property {Array<string>} keywords
@@ -753,23 +753,24 @@ async function getPackage(project, manifest, packageJson) {
     return
   }
 
-  // To do: this would probabl go higher? If there’s an error returned?
+  // To do: this would probably go higher? If there’s an error returned?
   // if (body.code === 'NOT_FOUND') {
   //   console.warn('%s#%s: could not find package (on npms)', repo, manifest)
   //   return
   // }
 
-  // To do: remove fallbacks and allow `undefined`?
-  const name = body.collected.metadata.name || ''
-  const description = body.collected.metadata.description || ''
+  const name = body.collected.metadata.name || undefined
+  const description = body.collected.metadata.description || undefined
   const keywords = body.collected.metadata.keywords || []
   const license = body.collected.metadata.license || undefined
   const latest = body.collected.metadata.version || undefined
   const repository = body.collected.metadata.repository
-  const url = (repository && repository.url) || ''
+  const url = (repository && repository.url) || undefined
   const score = body.score.final || 0
   // Note: we used to look at `dependents`, but that’s always on `0` apparently now?
 
+  if (!name) return
+
   if (body.collected.metadata.deprecated) {
     console.warn(
       '%s#%s: ignoring deprecated package: %s',

generate/asset.js

@@ -119,10 +119,16 @@ async function transformJs(file) {
     write: false
   })
 
-  // To do: improve error handling.
-  if (result.errors.length > 0) throw new Error('esbuild errors')
-  if (result.warnings.length > 0) throw new Error('esbuild warnings')
-  // To do: asset size
+  const logs = await Promise.all([
+    esbuild.formatMessages(result.errors, {kind: 'error'}),
+    esbuild.formatMessages(result.warnings, {kind: 'warning'})
+  ])
+  const flatLogs = logs.flat()
+  if (flatLogs.length > 0) {
+    console.error(flatLogs.join('\n'))
+  }
+
+  assert.equal(result.outputFiles.length, 1)
   const output = result.outputFiles[0]
   file.value = output.contents
   return file

generate/atom/micro/description.js

@@ -1,5 +1,3 @@
-// To do: remove? Unused?
-
 /**
  * @import {Element, Parents} from 'hast'
  */

generate/atom/micro/downloads.js

@@ -12,13 +12,12 @@ import {downloads as icon} from '../icon/downloads.js'
  * @returns {Array<ElementContent> | ElementContent}
  */
 export function downloads(value, name) {
-  let node
-
   if (!value) {
     return []
   }
 
-  node = [icon(), ' ', fmtCompact(value)]
+  /** @type {Array<ElementContent | string> | ElementContent} */
+  let node = [icon(), ' ', fmtCompact(value)]
 
   if (name) {
     node = h('a.tap-target', {href: 'https://www.npmtrends.com/' + name}, node)

generate/atom/micro/license.js

@@ -1,5 +1,3 @@
-// To do: remove? Unused?
-
 /**
  * @import {ElementContent, Element} from 'hast'
  */

generate/component/article/helper-sort.js

@@ -20,6 +20,5 @@ export function helperSort(data) {
  */
 function score(d) {
   const matter = d.data.matter || {}
-  // @ts-expect-error: to do: type `index`?
   return matter.index || Number.POSITIVE_INFINITY
 }

generate/component/article/item.js

@@ -15,7 +15,6 @@ import {tag} from '../../atom/micro/tag.js'
 export function item(d) {
   const {matter, meta} = d.data
   const data = {...matter, ...meta}
-  // @ts-expect-error: to do: type `authorGithub`?
   const {title, description, author, authorGithub, tags, pathname} = data
 
   assert(pathname)

generate/index.js

@@ -289,6 +289,9 @@ const promises = tasks.map((fn) => () => {
       function (x) {
         console.log(reporter(x))
       },
+      /**
+       * @param {unknown} error
+       */
       function (error) {
         console.error(error)
       }

generate/page/learn.js

@@ -3,6 +3,7 @@
  * @import {Metadata} from '../component/article/list.js'
  */
 
+import {ok as assert} from 'devlop'
 import {h} from 'hastscript'
 import {breadcrumbs} from '../molecule/breadcrumbs.js'
 import {list} from '../component/article/list.js'
@@ -29,11 +30,16 @@ export function learn(sections) {
         'through how to complete bigger tasks.'
       ])
     ]),
-    ...sections.flatMap((d) => [
-      h('.article.content', [h('h3', {}, d.title), h('p', {}, d.description)]),
-      // To do: assert that entries exists?
-      list(d, helperSort(d.entries || []))
-    ]),
+    ...sections.flatMap((d) => {
+      assert(d.entries)
+      return [
+        h('.article.content', [
+          h('h3', {}, d.title),
+          h('p', {}, d.description)
+        ]),
+        list(d, helperSort(d.entries || []))
+      ]
+    }),
     h('.article.content', [
       h('h3', 'Explore'),
       h('p', [

generate/plugin/rehype-resolve-urls.js

@@ -11,8 +11,9 @@
  * @property {string | null | undefined} [repo]
  */
 
+import {isElement} from 'hast-util-is-element'
+import {urlAttributes} from 'html-url-attributes'
 import {visit} from 'unist-util-visit'
-import {tagToUrl} from '../util/tag-to-url.js'
 
 const own = {}.hasOwnProperty
 const gh = 'https://github.com'
@@ -56,9 +57,13 @@ export default function rehypeResolveUrls(options) {
 
     /** @type {BuildVisitor<Root, 'element'>} */
     function visitor(node) {
-      const {tagName} = node
-      if (own.call(tagToUrl, tagName)) {
-        tagToUrl[tagName].forEach((p) => resolve(node, p, tagName))
+      for (const property in node.properties) {
+        if (
+          own.call(urlAttributes, property) &&
+          isElement(node, urlAttributes[property])
+        ) {
+          resolve(node, property, node.tagName)
+        }
       }
     }