Update as requested in the review. Thanks for your advise @veeresht.

Author: BastienTr

commpy/channelcoding/tests/test_ldpc.py

@@ -1,14 +1,16 @@
 # Authors: Veeresh Taranalli <veeresht@gmail.com>
 # License: BSD 3-Clause
 
+import os
+
+from nose.plugins.attrib import attr
 from numpy import array, sqrt, zeros
 from numpy.random import randn
 from numpy.testing import assert_allclose
+
 from commpy.channelcoding.ldpc import get_ldpc_code_params, ldpc_bp_decode
 from commpy.utilities import hamming_dist
-import os
 
-from nose.plugins.attrib import attr
 
 @attr('slow')
 class TestLDPCCode(object):
@@ -59,4 +61,4 @@ def test_ldpc_bp_decode(self):
                     fer_array_test[idx] = float(fer_cnt_bp)/(iter_cnt+1)
                     break
 
-        assert_allclose(fer_array_test, fer_array_ref, rtol=2e-1, atol=0)
+        assert_allclose(fer_array_test, fer_array_ref, rtol=.5, atol=0)

commpy/examples/plotConsModem.py

@@ -7,10 +7,10 @@
 # Example constellation plot of Modem
 # =============================================================================
 
-# PSK corresponding to PSKModem for 4 bits
+# Constellation corresponding to PSKModem for 4 bits per symbols
 psk = PSKModem(16)
 psk.plotCons()
 
-# QAM corresponding to QAMModem for 2bits
-Qam = QAMModem(4)
-Qam.plotCons()
+# Constellation corresponding to QAMModem for 2 bits per symbols
+qam = QAMModem(4)
+qam.plotCons()

commpy/links.py

@@ -10,15 +10,15 @@
    :toctree: generated/
 
    link_performance     -- Estimate the BER performance of a link model with Monte Carlo simulation.
-   linkModel            -- Link model object.
+   LinkModel            -- Link model object.
 """
 from __future__ import division  # Python 2 compatibility
 
 import numpy as np
 
 from commpy.channels import MIMOFlatChannel
 
-__all__ = ['link_performance', 'linkModel']
+__all__ = ['link_performance', 'LinkModel']
 
 
 def link_performance(link_model, SNRs, send_max, err_min, send_chunk=None, code_rate=1):
@@ -89,7 +89,7 @@ def link_performance(link_model, SNRs, send_max, err_min, send_chunk=None, code_
     return BERs
 
 
-class linkModel:
+class LinkModel:
     """
         Construct a link model.
 

commpy/modulation.py

@@ -21,13 +21,14 @@
 from itertools import product
 
 import matplotlib.pyplot as plt
-from commpy.utilities import bitarray2dec, dec2bitarray
 from numpy import arange, array, zeros, pi, cos, sin, sqrt, log2, argmin, \
     hstack, repeat, tile, dot, shape, concatenate, exp, \
     log, vectorize, empty, eye, kron
 from numpy.fft import fft, ifft
 from numpy.linalg import qr, norm
 
+from commpy.utilities import bitarray2dec, dec2bitarray
+
 __all__ = ['PSKModem', 'QAMModem', 'ofdm_tx', 'ofdm_rx', 'mimo_ml', 'kbest', 'bit_lvl_repr']
 
 
@@ -100,7 +101,7 @@ def demodulate(self, input_symbols, demod_type, noise_var=0):
 
         return demod_bits
 
-    def plotCons(self):
+    def plot_constellation(self):
         """ Plot the constellation """
         # init some arrays
         beta = self.num_bits_symbol

commpy/tests/test_links.py

@@ -9,7 +9,7 @@
 from scipy.special import erfc
 
 from commpy.channels import MIMOFlatChannel, SISOFlatChannel
-from commpy.links import link_performance, linkModel
+from commpy.links import link_performance, LinkModel
 from commpy.modulation import QAMModem, kbest
 
 
@@ -20,7 +20,7 @@ def test_link_performance():
 
     def receiver(y, h, constellation):
         return QPSK.demodulate(y, 'hard')
-    model = linkModel(QPSK.modulate, SISOFlatChannel(fading_param=(1 + 0j, 0)), receiver,
+    model = LinkModel(QPSK.modulate, SISOFlatChannel(fading_param=(1 + 0j, 0)), receiver,
                       QPSK.num_bits_symbol, QPSK.constellation, QPSK.Es)
 
     BERs = link_performance(model, range(0, 9, 2), 600e4, 600)
@@ -35,7 +35,7 @@ def receiver(y, h, constellation):
 
     def receiver(y, h, constellation):
         return QAM16.demodulate(kbest(y, h, constellation, 16), 'hard')
-    model = linkModel(QAM16.modulate, RayleighChannel, receiver,
+    model = LinkModel(QAM16.modulate, RayleighChannel, receiver,
                       QAM16.num_bits_symbol, QAM16.constellation, QAM16.Es)
     SNRs = arange(0, 21, 5) + 10 * log10(QAM16.num_bits_symbol)
 

commpy/tests/test_modulation.py

@@ -1,13 +1,14 @@
 # Authors: Youness Akourim <akourim97@gmail.com>
 # License: BSD 3-Clause
 
-from commpy.channels import MIMOFlatChannel
-from commpy.links import *
-from commpy.modulation import QAMModem, mimo_ml, bit_lvl_repr
 from numpy import zeros, identity, arange, concatenate, log2, array
 from numpy.random import seed
 from numpy.testing import run_module_suite, assert_allclose, dec
 
+from commpy.channels import MIMOFlatChannel
+from commpy.links import *
+from commpy.modulation import QAMModem, mimo_ml, bit_lvl_repr
+
 
 @dec.slow
 def test_bit_lvl_repr():
@@ -35,13 +36,13 @@ def receiverWithoutBLR(y, H, cons):
         return qam.demodulate(mimo_ml(y, H, cons), 'hard')
 
     MymodelWithoutBLR = \
-        linkModel(qam.modulate, RayleighChannel, receiverWithoutBLR, qam.num_bits_symbol, qam.constellation, qam.Es)
+        LinkModel(qam.modulate, RayleighChannel, receiverWithoutBLR, qam.num_bits_symbol, qam.constellation, qam.Es)
     MymodelWithBLR = \
-        linkModel(qam.modulate, RayleighChannel, receiverWithBLR, qam.num_bits_symbol, qam.constellation, qam.Es)
+        LinkModel(qam.modulate, RayleighChannel, receiverWithBLR, qam.num_bits_symbol, qam.constellation, qam.Es)
 
     BERWithoutBLR = link_performance(MymodelWithoutBLR, SNR, 300e4, 300)
     BERWithBLR = link_performance(MymodelWithBLR, SNR, 300e4, 300)
-    assert_allclose(BERWithoutBLR, BERWithBLR, rtol=0.25,
+    assert_allclose(BERWithoutBLR, BERWithBLR, rtol=0.5,
                     err_msg='bit_lvl_repr changes the performance')