refactor: unify package manager related logic (#4256)

Author: haoqunjiang

packages/@vue/cli-ui/apollo-server/connectors/dependencies.js

@@ -13,14 +13,8 @@ const logs = require('./logs')
 const getContext = require('../context')
 // Utils
 const { isPlugin, hasYarn, resolveModule } = require('@vue/cli-shared-utils')
-const getPackageVersion = require('@vue/cli/lib/util/getPackageVersion')
-const {
-  progress: installProgress,
-  installPackage,
-  uninstallPackage,
-  updatePackage
-} = require('@vue/cli/lib/util/installDeps')
-const { getCommand } = require('../util/command')
+const { progress: installProgress } = require('@vue/cli/lib/util/executeCommand')
+const PackageManager = require('@vue/cli/lib/util/ProjectPackageManager')
 const { resolveModuleRoot } = require('../util/resolve-path')
 const { notify } = require('../util/notification')
 const { log } = require('../util/logger')
@@ -113,10 +107,7 @@ async function getMetadata (id, context) {
 
   if (!metadata) {
     try {
-      const res = await getPackageVersion(id)
-      if (res.statusCode === 200) {
-        metadata = res.body
-      }
+      metadata = await (new PackageManager({ context: cwd.get() })).getMetadata()
     } catch (e) {
       // No connection?
     }
@@ -126,7 +117,7 @@ async function getMetadata (id, context) {
     metadataCache.set(id, metadata)
     return metadata
   } else {
-    log('Dpendencies', chalk.yellow(`Can't load metadata`), id)
+    log('Dependencies', chalk.yellow(`Can't load metadata`), id)
   }
 }
 
@@ -211,7 +202,8 @@ function install ({ id, type, range }, context) {
       arg = id
     }
 
-    await installPackage(cwd.get(), getCommand(cwd.get()), arg, type === 'devDependencies')
+    const pm = new PackageManager({ context: cwd.get() })
+    await pm.add(arg, type === 'devDependencies')
 
     logs.add({
       message: `Dependency ${id} installed`,
@@ -239,7 +231,8 @@ function uninstall ({ id }, context) {
 
     const dep = findOne(id, context)
 
-    await uninstallPackage(cwd.get(), getCommand(cwd.get()), id)
+    const pm = new PackageManager({ context: cwd.get() })
+    await pm.remove(id)
 
     logs.add({
       message: `Dependency ${id} uninstalled`,
@@ -265,7 +258,9 @@ function update ({ id }, context) {
 
     const dep = findOne(id, context)
     const { current, wanted } = await getVersion(dep, context)
-    await updatePackage(cwd.get(), getCommand(cwd.get()), id)
+
+    const pm = new PackageManager({ context: cwd.get() })
+    await pm.upgrade(id)
 
     logs.add({
       message: `Dependency ${id} updated from ${current} to ${wanted}`,
@@ -310,9 +305,8 @@ function updateAll (context) {
       args: [updatedDeps.length]
     })
 
-    await updatePackage(cwd.get(), getCommand(cwd.get()), updatedDeps.map(
-      p => p.id
-    ).join(' '))
+    const pm = new PackageManager({ context: cwd.get() })
+    await pm.upgrade(updatedDeps.map(p => p.id).join(' '))
 
     notify({
       title: `Dependencies updated`,

packages/@vue/cli-ui/apollo-server/connectors/plugins.js

@@ -30,13 +30,9 @@ const {
   clearModule,
   execa
 } = require('@vue/cli-shared-utils')
-const {
-  progress: installProgress,
-  installPackage,
-  uninstallPackage,
-  updatePackage
-} = require('@vue/cli/lib/util/installDeps')
-const { getCommand } = require('../util/command')
+const { progress: installProgress } = require('@vue/cli/lib/util/executeCommand')
+const PackageManager = require('@vue/cli/lib/util/ProjectPackageManager')
+
 const ipc = require('../util/ipc')
 const { log } = require('../util/logger')
 const { notify } = require('../util/notification')
@@ -334,7 +330,8 @@ function install (id, context) {
     if (process.env.VUE_CLI_DEBUG && isOfficialPlugin(id)) {
       mockInstall(id, context)
     } else {
-      await installPackage(cwd.get(), getCommand(cwd.get()), id)
+      const pm = new PackageManager({ context: cwd.get() })
+      await pm.add(id)
     }
     await initPrompts(id, context)
     installationStep = 'config'
@@ -412,7 +409,8 @@ function uninstall (id, context) {
     if (process.env.VUE_CLI_DEBUG && isOfficialPlugin(id)) {
       mockUninstall(id, context)
     } else {
-      await uninstallPackage(cwd.get(), getCommand(cwd.get()), id)
+      const pm = new PackageManager({ context: cwd.get() })
+      await pm.remove(id)
     }
     currentPluginId = null
     installationStep = null
@@ -520,7 +518,8 @@ function update ({ id, full }, context) {
     if (localPath) {
       await updateLocalPackage({ cwd: cwd.get(), id, localPath, full }, context)
     } else {
-      await updatePackage(cwd.get(), getCommand(cwd.get()), id)
+      const pm = new PackageManager({ context: cwd.get() })
+      await pm.upgrade(id)
     }
 
     logs.add({
@@ -583,9 +582,8 @@ async function updateAll (context) {
       args: [updatedPlugins.length]
     })
 
-    await updatePackage(cwd.get(), getCommand(cwd.get()), updatedPlugins.map(
-      p => p.id
-    ).join(' '))
+    const pm = new PackageManager({ context: cwd.get() })
+    await pm.upgrade(updatedPlugins.map(p => p.id).join(' '))
 
     notify({
       title: `Plugins updated`,

packages/@vue/cli-ui/apollo-server/connectors/projects.js

@@ -6,7 +6,7 @@ const { getPromptModules } = require('@vue/cli/lib/util/createTools')
 const { getFeatures } = require('@vue/cli/lib/util/features')
 const { defaults } = require('@vue/cli/lib/options')
 const { toShortPluginId, execa } = require('@vue/cli-shared-utils')
-const { progress: installProgress } = require('@vue/cli/lib/util/installDeps')
+const { progress: installProgress } = require('@vue/cli/lib/util/executeCommand')
 const parseGitConfig = require('parse-git-config')
 // Connectors
 const progress = require('./progress')

packages/@vue/cli/lib/Creator.js

@@ -9,7 +9,7 @@ const Generator = require('./Generator')
 const cloneDeep = require('lodash.clonedeep')
 const sortObject = require('./util/sortObject')
 const getVersions = require('./util/getVersions')
-const { installDeps } = require('./util/installDeps')
+const PackageManager = require('./util/ProjectPackageManager')
 const { clearConsole } = require('./util/clearConsole')
 const PromptModuleAPI = require('./PromptModuleAPI')
 const writeFileTree = require('./util/writeFileTree')
@@ -117,6 +117,7 @@ module.exports = class Creator extends EventEmitter {
       (hasYarn() ? 'yarn' : null) ||
       (hasPnpm3OrLater() ? 'pnpm' : 'npm')
     )
+    const pm = new PackageManager({ context, forcePackageManager: packageManager })
 
     await clearConsole()
     logWithSpinner(`✨`, `Creating project in ${chalk.yellow(context)}.`)
@@ -176,7 +177,7 @@ module.exports = class Creator extends EventEmitter {
       // in development, avoid installation process
       await require('./util/setupDevProject')(context)
     } else {
-      await installDeps(context, packageManager)
+      await pm.install()
     }
 
     // run generator
@@ -197,7 +198,7 @@ module.exports = class Creator extends EventEmitter {
     this.emit('creation', { event: 'deps-install' })
     log()
     if (!isTestOrDebug) {
-      await installDeps(context, packageManager)
+      await pm.install()
     }
 
     // run complete cbs if any (injected by generators)

packages/@vue/cli/lib/add.js

@@ -1,12 +1,10 @@
 const chalk = require('chalk')
 const invoke = require('./invoke')
-const { loadOptions } = require('./options')
-const { installPackage } = require('./util/installDeps')
+
+const PackageManager = require('./util/ProjectPackageManager')
 const {
   log,
   error,
-  hasProjectYarn,
-  hasProjectPnpm,
   resolvePluginId,
   resolveModule
 } = require('@vue/cli-shared-utils')
@@ -23,8 +21,8 @@ async function add (pluginName, options = {}, context = process.cwd()) {
   log(`📦  Installing ${chalk.cyan(packageName)}...`)
   log()
 
-  const packageManager = loadOptions().packageManager || (hasProjectYarn(context) ? 'yarn' : hasProjectPnpm(context) ? 'pnpm' : 'npm')
-  await installPackage(context, packageManager, packageName)
+  const pm = new PackageManager({ context })
+  await pm.add(packageName)
 
   log(`${chalk.green('✔')}  Successfully installed plugin: ${chalk.cyan(packageName)}`)
   log()

packages/@vue/cli/lib/invoke.js

@@ -6,20 +6,18 @@ const inquirer = require('inquirer')
 const {
   log,
   error,
-  hasProjectYarn,
   hasProjectGit,
-  hasProjectPnpm,
   logWithSpinner,
   stopSpinner,
   resolvePluginId,
   loadModule
 } = require('@vue/cli-shared-utils')
 
 const Generator = require('./Generator')
-const { loadOptions } = require('./options')
-const { installDeps } = require('./util/installDeps')
+
 const confirmIfGitDirty = require('./util/confirmIfGitDirty')
 const readFiles = require('./util/readFiles')
+const PackageManager = require('./util/ProjectPackageManager')
 
 function getPkg (context) {
   const pkgPath = path.resolve(context, 'package.json')
@@ -130,9 +128,8 @@ async function runGenerator (context, plugin, pkg = getPkg(context)) {
   if (!isTestOrDebug && depsChanged) {
     log(`📦  Installing additional dependencies...`)
     log()
-    const packageManager =
-      loadOptions().packageManager || (hasProjectYarn(context) ? 'yarn' : hasProjectPnpm(context) ? 'pnpm' : 'npm')
-    await installDeps(context, packageManager)
+    const pm = new PackageManager({ context })
+    await pm.install()
   }
 
   if (createCompleteCbs.length) {