refactor: use built-in toString from webpack-chain

Author: yyx990803

packages/@vue/cli-service/lib/commands/inspect.js

@@ -1,82 +1,3 @@
-let patched = false
-function patchWebpackChain () {
-  if (patched) return
-
-  const Config = require('webpack-chain')
-
-  const toConfig = Config.prototype.toConfig
-  Config.prototype.toConfig = function () {
-    const config = toConfig.call(this)
-
-    // inject plugin metadata
-    const { entries: plugins, order: pluginNames } = this.plugins.order()
-    config.plugins.forEach((p, i) => {
-      Object.defineProperties(p, {
-        __pluginName: {
-          value: pluginNames[i]
-        },
-        __pluginArgs: {
-          value: plugins[pluginNames[i]].get('args')
-        }
-      })
-    })
-
-    // inject rule metadata
-    const { entries: rules, order: ruleNames } = this.module.rules.order()
-    config.module.rules.forEach((rawRule, i) => {
-      const ruleName = ruleNames[i]
-      const rule = rules[ruleName]
-      Object.defineProperties(rawRule, {
-        __ruleName: {
-          value: ruleName
-        }
-      })
-
-      if (rawRule.oneOf) {
-        const { entries: oneOfs, order: oneOfNames } = rule.oneOfs.order()
-        rawRule.oneOf.forEach((o, i) => {
-          const oneOfName = oneOfNames[i]
-          const oneOf = oneOfs[oneOfName]
-          Object.defineProperties(o, {
-            __ruleName: {
-              value: ruleName
-            },
-            __oneOfName: {
-              value: oneOfName
-            }
-          })
-          patchUse(oneOf, ruleName, oneOfName, o)
-        })
-      }
-
-      patchUse(rule, ruleName, null, rawRule)
-    })
-
-    return config
-  }
-
-  patched = true
-}
-
-function patchUse (rule, ruleName, oneOfName, rawRule) {
-  if (Array.isArray(rawRule.use)) {
-    const { order: useNames } = rule.uses.order()
-    rawRule.use.forEach((use, i) => {
-      Object.defineProperties(use, {
-        __ruleName: {
-          value: ruleName
-        },
-        __oneOfName: {
-          value: oneOfName
-        },
-        __useName: {
-          value: useNames[i]
-        }
-      })
-    })
-  }
-}
-
 module.exports = (api, options) => {
   api.registerCommand('inspect', {
     description: 'inspect internal webpack config',
@@ -90,20 +11,18 @@ module.exports = (api, options) => {
       '--verbose': 'show full function definitions in output'
     }
   }, args => {
-    patchWebpackChain()
-
     const get = require('get-value')
-    const stringify = require('javascript-stringify')
+    const { toString } = require('webpack-chain')
     const config = api.resolveWebpackConfig()
-    const paths = args._
+    const { _: paths, verbose } = args
 
     let res
     if (args.rule) {
-      res = config.module.rules.find(r => r.__ruleName === args.rule)
+      res = config.module.rules.find(r => r.__ruleNames[0] === args.rule)
     } else if (args.plugin) {
       res = config.plugins.find(p => p.__pluginName === args.plugin)
     } else if (args.rules) {
-      res = config.module.rules.map(r => r.__ruleName)
+      res = config.module.rules.map(r => r.__ruleNames[0])
     } else if (args.plugins) {
       res = config.plugins.map(p => p.__pluginName)
     } else if (paths.length > 1) {
@@ -117,54 +36,7 @@ module.exports = (api, options) => {
       res = config
     }
 
-    const pluginRE = /(?:function|class) (\w+Plugin)/
-    const output = stringify(res, (value, indent, stringify) => {
-      // shorten long functions
-      if (
-        !args.verbose &&
-        typeof value === 'function' &&
-        value.toString().length > 100
-      ) {
-        return `function () { /* omitted long function */ }`
-      }
-
-      // improve plugin output
-      if (value && value.__pluginName) {
-        let match = (
-          value.constructor &&
-          value.constructor.toString().match(pluginRE)
-        )
-        // copy-webpack-plugin
-        if (value.__pluginName === 'copy') {
-          match = [null, `CopyWebpackPlugin`]
-        }
-        const name = match[1]
-        const prefix = `/* config.plugin('${value.__pluginName}') */\n`
-
-        if (name) {
-          return prefix + `new ${name}(${
-            value.__pluginArgs.map(arg => stringify(arg)).join(',\n')
-          })`
-        } else {
-          return prefix + stringify({
-            args: value.__pluginArgs || []
-          })
-        }
-      }
-
-      // improve rule output
-      if (value && value.__ruleName) {
-        const prefix = `/* config.module.rule('${value.__ruleName}')${
-          value.__oneOfName ? `.oneOf('${value.__oneOfName}')` : ``
-        }${
-          value.__useName ? `.use('${value.__useName}')` : ``
-        } */\n`
-        return prefix + stringify(value)
-      }
-
-      return stringify(value)
-    }, 2)
-
+    const output = toString(config, { verbose })
     console.log(output)
   })
 }

packages/@vue/cli-service/package.json

@@ -39,7 +39,6 @@
     "get-value": "^3.0.1",
     "globby": "^8.0.1",
     "html-webpack-plugin": "^3.2.0",
-    "javascript-stringify": "^1.6.0",
     "launch-editor-middleware": "^2.2.1",
     "lodash.defaultsdeep": "^4.6.0",
     "mini-css-extract-plugin": "^0.4.0",
@@ -60,7 +59,7 @@
     "vue-loader": "^15.0.11",
     "vue-template-compiler": "^2.5.16",
     "webpack": "^4.8.2",
-    "webpack-chain": "^4.6.0",
+    "webpack-chain": "^4.8.0",
     "webpack-dev-server": "^3.1.4",
     "webpack-merge": "^4.1.2",
     "yorkie": "^1.0.3"

yarn.lock

@@ -10610,11 +10610,12 @@ webidl-conversions@^4.0.2:
   version "4.0.2"
   resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-4.0.2.tgz#a855980b1f0b6b359ba1d5d9fb39ae941faa63ad"
 
-webpack-chain@^4.6.0:
-  version "4.6.0"
-  resolved "https://registry.yarnpkg.com/webpack-chain/-/webpack-chain-4.6.0.tgz#3ff51bd6241ed78a62691b8da7b9dec3fcc346a0"
+webpack-chain@^4.8.0:
+  version "4.8.0"
+  resolved "https://registry.yarnpkg.com/webpack-chain/-/webpack-chain-4.8.0.tgz#06fc3dbb9f2707d4c9e899fc6250fbcf2afe6fd1"
   dependencies:
     deepmerge "^1.5.2"
+    javascript-stringify "^1.6.0"
 
 webpack-dev-middleware@3.1.3:
   version "3.1.3"