Skip to content

Commit a9088d6

Browse files
committed
use new syntax for v-el
1 parent 12ad53c commit a9088d6

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

src/compiler/compile.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ var componentDef = require('../directives/component')
1111
// special binding prefixes
1212
var bindRE = /^bind-|^:/
1313
var onRE = /^on-/
14+
var nodeRefRE = /^\$\$\./
1415

1516
// terminal directives
1617
var terminalDirectives = [
@@ -595,12 +596,10 @@ function compileDirectives (attrs, options) {
595596
})
596597
} else
597598

598-
// special case for el
599-
if (name === 'el' || name === 'bind-el' || name === ':el') {
599+
if (nodeRefRE.test(name)) {
600600
dirs.push({
601601
name: 'el',
602-
arg: bindRE.test(name),
603-
descriptors: [newDirParser.parse(value)],
602+
descriptors: [newDirParser.parse(name.replace(nodeRefRE, ''))],
604603
def: options.directives.el
605604
})
606605
} else

test/unit/specs/directives/el_spec.js

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if (_.inBrowser) {
2828
data: {
2929
ok: true
3030
},
31-
template: '<div v-if="ok" el="test" id="test"></div>'
31+
template: '<div $$.test v-if="ok" id="test"></div>'
3232
})
3333
expect(vm.$$.test).toBeTruthy()
3434
expect(vm.$$.test.id).toBe('test')
@@ -43,25 +43,6 @@ if (_.inBrowser) {
4343
})
4444
})
4545

46-
it('bind-el', function (done) {
47-
var vm = new Vue({
48-
el: el,
49-
data: {
50-
id: 'test'
51-
},
52-
template: '<div bind-el="id" id="test"></div>'
53-
})
54-
expect(vm.$$.test).toBeTruthy()
55-
expect(vm.$$.test.id).toBe('test')
56-
vm.id = 'changed'
57-
_.nextTick(function () {
58-
expect(vm.$$.test).toBeNull()
59-
expect(vm.$$.changed).toBeTruthy()
60-
expect(vm.$$.changed.id).toBe('test')
61-
done()
62-
})
63-
})
64-
6546
it('with v-repeat', function (done) {
6647
var vm = new Vue({
6748
el: el,

0 commit comments

Comments
 (0)