test wip

Author: yyx990803

package.json

@@ -16,7 +16,7 @@
     "chat": "cd examples/chat && webpack-dev-server --inline --hot --config ../webpack.shared.config.js",
     "build": "node build/build.js",
     "build-examples": "BABEL_ENV=development webpack --config examples/webpack.build-all.config.js",
-    "unit": "BABEL_ENV=development mocha test/unit/test.js --compilers js:babel-core/register",
+    "unit": "BABEL_ENV=development mocha test/unit/test.js --compilers js:babel-core/register 2>/dev/null",
     "pree2e": "npm run build-examples",
     "e2e": "casperjs test --concise ./test/e2e",
     "test": "eslint src && npm run unit && npm run e2e",

src/helpers.js

@@ -2,6 +2,9 @@ export function mapGetters (getters) {
   const res = {}
   normalizeMap(getters).forEach(({ key, val }) => {
     res[key] = function mappedGetter () {
+      if (!(val in this.$store.getters)) {
+        console.error(`[vuex] unknown getter: ${val}`)
+      }
       return this.$store.getters[val]
     }
   })

src/index.js

@@ -36,10 +36,10 @@ class Store {
     const store = this
     const { dispatch, commit } = this
     this.dispatch = function boundDispatch (type, payload) {
-      dispatch.call(store, type, payload)
+      return dispatch.call(store, type, payload)
     }
     this.commit = function boundCommit (type, payload) {
-      commit.call(store, type, payload)
+      return commit.call(store, type, payload)
     }
 
     // init state and getters
@@ -140,24 +140,27 @@ class Store {
   }
 
   commit (type, payload) {
-    const entry = this._mutations[type]
-    if (!entry) {
-      console.error(`[vuex] unknown mutation type: ${type}`)
-      return
-    }
     // check object-style commit
     let mutation
-    if (isObject(type)) {
+    if (isObject(type) && type.type) {
       payload = mutation = type
+      type = type.type
     } else {
       mutation = { type, payload }
     }
+    const entry = this._mutations[type]
+    if (!entry) {
+      console.error(`[vuex] unknown mutation type: ${type}`)
+      return
+    }
     this._committing = true
     entry.forEach(function commitIterator (handler) {
       handler(payload)
     })
     this._committing = false
-    this._subscribers.forEach(sub => sub(mutation, this.state))
+    if (!payload || !payload.silent) {
+      this._subscribers.forEach(sub => sub(mutation, this.state))
+    }
   }
 
   dispatch (type, payload) {
@@ -169,7 +172,7 @@ class Store {
     }
     return entry.length > 1
       ? Promise.all(entry.map(handler => handler(payload)))
-      : Promise.resolve(entry[0](payload))
+      : entry[0](payload)
   }
 
   subscribe (fn) {