PHPStan level 5

Author: yajra

.github/workflows/continuous-integration.yml

@@ -0,0 +1,45 @@
+name: "Continuous Integration"
+
+on:
+  push:
+  pull_request:
+  schedule:
+    - cron: '0 0 * * *'
+
+jobs:
+  phpunit:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: true
+      matrix:
+        php: [8.0, 8.1]
+        stability: [prefer-stable]
+
+    name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, gd, memcached
+          tools: composer:v2
+          coverage: none
+
+      - name: Setup Memcached
+        uses: niden/actions-memcached@v7
+
+      - name: Install dependencies
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --${{ matrix.stability }} --prefer-dist --no-interaction --no-progress
+
+      - name: Execute tests
+        run: vendor/bin/phpunit --verbose

.github/workflows/static-analysis.yml

@@ -0,0 +1,48 @@
+name: "Static Analysis"
+
+on:
+  push:
+    paths:
+      - .github/workflows/static-analysis.yml
+      - composer.*
+      - phpstan.neon.dist
+      - src/**
+      - tests/**
+
+  pull_request:
+    paths:
+      - .github/workflows/static-analysis.yml
+      - composer.*
+      - phpstan.neon.dist
+      - src/**
+      - tests/**
+
+  schedule:
+    - cron: '0 0 * * *'
+
+jobs:
+  static-analysis-phpstan:
+    name: "Static Analysis with PHPStan"
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        php-version:
+          - "8.1"
+
+    steps:
+      - name: "Checkout code"
+        uses: "actions/checkout@v2"
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
+          tools: "cs2pr"
+
+      - name: "Install dependencies with Composer"
+        uses: "ramsey/composer-install@v1"
+
+      - name: "Run a static analysis with phpstan/phpstan"
+        run: "vendor/bin/phpstan --error-format=checkstyle | cs2pr"

.styleci.yml

@@ -1,9 +1 @@
 preset: laravel
-
-enabled:
-  - align_double_arrow
-  - align_equals
-
-disabled:
-  - concat_without_spaces
-  - unalign_equals

.travis.yml

@@ -5,4 +5,5 @@
 - Added Laravel 9 specific support
 - Bump major version to match with the framework
 - Move `maatwebsite/excel` to suggest. #139
-- [BC] Rename ReadOnly to ReadOnlyField
+- Add phpstan static analysis
+- Add tests

CHANGELOG.md

@@ -17,12 +17,15 @@
   "require": {
     "php": "^8.0.2",
     "yajra/laravel-datatables-oracle": "10.*",
-    "yajra/laravel-datatables-html": "3.*|4.*",
+    "yajra/laravel-datatables-html": "9.*",
     "illuminate/console": "*"
   },
   "require-dev": {
-    "mockery/mockery": "^1.1",
-    "phpunit/phpunit": "^7.3"
+    "maatwebsite/excel": "^3.1.40",
+    "nunomaduro/larastan": "^2.1",
+    "orchestra/testbench": "^7.3",
+    "rap2hpoutre/fast-excel": "^3.2",
+    "barryvdh/laravel-snappy": "^1.0"
   },
   "autoload": {
     "psr-4": {
@@ -31,7 +34,7 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "Yajra\\DataTables\\Tests\\": "tests/"
+      "Yajra\\DataTables\\Buttons\\Tests\\": "tests/"
     }
   },
   "extra": {

composer.json

@@ -0,0 +1,18 @@
+includes:
+    - ./vendor/nunomaduro/larastan/extension.neon
+
+parameters:
+
+    paths:
+        - src
+
+    level: 5
+
+    ignoreErrors:
+        - '#Unsafe usage of new static\(\).#'
+
+    excludePaths:
+
+    checkMissingIterableValueType: false
+
+    checkGenericClassInNonGenericObjectType: false

phpstan.neon.dist

@@ -15,9 +15,9 @@ class ButtonsServiceProvider extends ServiceProvider
      *
      * @return void
      */
-    public function boot()
+    public function boot(): void
     {
-        $this->loadViewsFrom(__DIR__ . '/resources/views', 'datatables');
+        $this->loadViewsFrom(__DIR__.'/resources/views', 'datatables');
 
         $this->publishAssets();
 
@@ -30,15 +30,15 @@ public function boot()
     protected function publishAssets()
     {
         $this->publishes([
-            __DIR__ . '/config/config.php' => config_path('datatables-buttons.php'),
+            __DIR__.'/config/config.php' => config_path('datatables-buttons.php'),
         ], 'datatables-buttons');
 
         $this->publishes([
-            __DIR__ . '/resources/assets/buttons.server-side.js' => public_path('vendor/datatables/buttons.server-side.js'),
+            __DIR__.'/resources/assets/buttons.server-side.js' => public_path('vendor/datatables/buttons.server-side.js'),
         ], 'datatables-buttons');
 
         $this->publishes([
-            __DIR__ . '/resources/views' => base_path('/resources/views/vendor/datatables'),
+            __DIR__.'/resources/views' => base_path('/resources/views/vendor/datatables'),
         ], 'datatables-buttons');
     }
 
@@ -57,9 +57,9 @@ protected function registerCommands()
      *
      * @return void
      */
-    public function register()
+    public function register(): void
     {
-        $this->mergeConfigFrom(__DIR__ . '/config/config.php', 'datatables-buttons');
+        $this->mergeConfigFrom(__DIR__.'/config/config.php', 'datatables-buttons');
 
         $this->app->register(HtmlServiceProvider::class);
 

src/ButtonsServiceProvider.php

@@ -38,6 +38,7 @@ class DataTablesHtmlCommand extends DataTablesMakeCommand
      *
      * @param  string  $name
      * @return string
+     * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      */
     protected function buildClass($name)
     {
@@ -59,7 +60,7 @@ protected function buildClass($name)
      *
      * @return string
      */
-    protected function getStub()
+    protected function getStub(): string
     {
         $config = $this->laravel['config'];
 
@@ -74,7 +75,7 @@ protected function getStub()
      * @param  string  $name
      * @return string
      */
-    protected function qualifyClass($name)
+    protected function qualifyClass($name): string
     {
         $rootNamespace = $this->laravel->getNamespace();