PHPStan level 9

Author: yajra

phpstan.neon.dist

@@ -6,7 +6,7 @@ parameters:
     paths:
         - src
 
-    level: 8
+    level: max
 
     ignoreErrors:
         - '#Unsafe usage of new static\(\).#'

src/Exports/DataTablesCollectionExport.php

@@ -37,6 +37,7 @@ public function collection(): Collection
      */
     public function headings(): array
     {
+        /** @var array $first */
         $first = $this->collection->first();
         if ($first) {
             return array_keys($first);

src/Generators/DataTablesMakeCommand.php

@@ -153,11 +153,10 @@ protected function replaceTableId(string &$stub): static
      */
     protected function replaceDOM(string &$stub): static
     {
-        $stub = str_replace(
-            'DummyDOM',
-            $this->option('dom') ?: config('datatables-buttons.generator.dom', 'Bfrtip'),
-            $stub
-        );
+        /** @var string $dom */
+        $dom = $this->option('dom') ?: config('datatables-buttons.generator.dom', 'Bfrtip');
+
+        $stub = str_replace('DummyDOM', $dom, $stub);
 
         return $this;
     }
@@ -191,12 +190,10 @@ protected function getButtons(): string
             return $this->parseButtons($buttons);
         }
 
-        return $this->parseButtons(
-            config(
-                'datatables-buttons.generator.buttons',
-                'create,export,print,reset,reload'
-            )
-        );
+        /** @var string $buttons */
+        $buttons = config('datatables-buttons.generator.buttons', 'create,export,print,reset,reload');
+
+        return $this->parseButtons($buttons);
     }
 
     /**
@@ -264,6 +261,7 @@ protected function getColumns(): string
             return $this->parseColumns($columns);
         }
 
+        /** @var string $columns */
         $columns = config('datatables-buttons.generator.columns', 'id,add your columns,created_at,updated_at');
 
         return $this->parseColumns($columns);

src/Services/DataTable.php

@@ -2,6 +2,7 @@
 
 namespace Yajra\DataTables\Services;
 
+use Closure;
 use Generator;
 use Illuminate\Contracts\Support\Renderable;
 use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
@@ -223,6 +224,7 @@ public function ajax(): JsonResponse
     {
         $query = null;
         if (method_exists($this, 'query')) {
+            /** @var EloquentBuilder|QueryBuilder $query */
             $query = app()->call([$this, 'query']);
             $query = $this->applyScopes($query);
         }
@@ -332,7 +334,7 @@ public function builder(): Builder
         }
 
         if (method_exists($this, 'htmlBuilder')) {
-            return $this->htmlBuilder = app()->call([$this, 'htmlBuilder']);
+            return $this->htmlBuilder = $this->htmlBuilder();
         }
 
         return $this->htmlBuilder = app('datatables.html');
@@ -366,7 +368,10 @@ protected function getAjaxResponseData(): array
             'length' => -1,
         ]);
 
+        /** @var JsonResponse $response */
         $response = app()->call([$this, 'ajax']);
+
+        /** @var array{data: array} $data */
         $data = $response->getData(true);
 
         return $data['data'];
@@ -434,18 +439,24 @@ public function excel()
     {
         set_time_limit(3600);
 
-        $ext = '.'.strtolower($this->excelWriter);
-        $callback = $this->fastExcel ?
-            ($this->fastExcelCallback ? $this->fastExcelCallback() : null)
-            : $this->excelWriter;
+        $path = $this->getFilename().'.'.strtolower($this->excelWriter);
+
+        $excelFile = $this->buildExcelFile();
+
+        if ($excelFile instanceof FastExcel) {
+            $callback = $this->fastExcelCallback ? $this->fastExcelCallback() : null;
+
+            return $excelFile->download($path, $callback);
+        }
 
-        return $this->buildExcelFile()->download($this->getFilename().$ext, $callback);
+        // @phpstan-ignore-next-line
+        return $excelFile->download($path, $this->excelWriter);
     }
 
     /**
      * Build Excel file and prepare for export.
      *
-     * @return mixed|\Rap2hpoutre\FastExcel\FastExcel
+     * @return mixed|FastExcel
      * @throws \Exception
      */
     protected function buildExcelFile()
@@ -517,7 +528,7 @@ protected function getDataForExport(): array
     /**
      * Get export columns definition.
      *
-     * @return Collection
+     * @return Collection<int, Column>
      */
     protected function exportColumns(): Collection
     {
@@ -552,24 +563,30 @@ private function toColumnsCollection(array $columns): Collection
     /**
      * Export results to CSV file.
      *
-     * @return string|\Symfony\Component\HttpFoundation\BinaryFileResponse|\Symfony\Component\HttpFoundation\StreamedResponse
+     * @return string|\Symfony\Component\HttpFoundation\StreamedResponse
      * @throws \Exception
      */
     public function csv()
     {
         set_time_limit(3600);
-        $ext = '.'.strtolower($this->csvWriter);
-        $callback = $this->fastExcel ?
-            ($this->fastExcelCallback ? $this->fastExcelCallback() : null)
-            : $this->csvWriter;
+        $path = $this->getFilename().'.'.strtolower($this->excelWriter);
+
+        $excelFile = $this->buildExcelFile();
 
-        return $this->buildExcelFile()->download($this->getFilename().$ext, $callback);
+        if ($excelFile instanceof FastExcel) {
+            $callback = $this->fastExcelCallback ? $this->fastExcelCallback() : null;
+
+            return $excelFile->download($path, $callback);
+        }
+
+        // @phpstan-ignore-next-line
+        return $this->buildExcelFile()->download($path, $this->csvWriter);
     }
 
     /**
      * Export results to PDF file.
      *
-     * @return \Illuminate\Http\Response|string|\Symfony\Component\HttpFoundation\BinaryFileResponse|\Symfony\Component\HttpFoundation\StreamedResponse
+     * @return \Illuminate\Http\Response|string|\Symfony\Component\HttpFoundation\StreamedResponse
      * @throws \Box\Spout\Common\Exception\IOException
      * @throws \Box\Spout\Common\Exception\InvalidArgumentException
      * @throws \Box\Spout\Common\Exception\UnsupportedTypeException
@@ -582,6 +599,7 @@ public function pdf()
             return $this->snappyPdf();
         }
 
+        // @phpstan-ignore-next-line
         return $this->buildExcelFile()->download($this->getFilename().'.pdf', $this->pdfWriter);
     }
 
@@ -594,7 +612,9 @@ public function snappyPdf(): Response
     {
         /** @var \Barryvdh\Snappy\PdfWrapper $snappy */
         $snappy = app('snappy.pdf.wrapper');
-        $options = config('datatables-buttons.snappy.options');
+        $options = (array) config('datatables-buttons.snappy.options');
+
+        /** @var string $orientation */
         $orientation = config('datatables-buttons.snappy.orientation');
 
         $snappy->setOptions($options)->setOrientation($orientation);
@@ -721,15 +741,16 @@ protected function convertToLazyCollection(array|Collection $collection): LazyCo
     /**
      * @return \Closure
      */
-    public function fastExcelCallback(): \Closure
+    public function fastExcelCallback(): Closure
     {
         return function ($row) {
             $mapped = [];
-            foreach ($this->exportColumns() as $column) {
+
+            $this->exportColumns()->each(function (Column $column) use (&$mapped, $row) {
                 if ($column['exportable']) {
                     $mapped[$column['title']] = $row[$column['data']];
                 }
-            }
+            });
 
             return $mapped;
         };
@@ -742,6 +763,7 @@ protected function buildFastExcelFile(): FastExcel
     {
         $query = null;
         if (method_exists($this, 'query')) {
+            /** @var EloquentBuilder|QueryBuilder $query */
             $query = app()->call([$this, 'query']);
             $query = $this->applyScopes($query);
         }