chore: rector updates

Author: yajra

rector.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_82,
+    ]);
+};

src/Html/Builder.php

@@ -20,21 +20,21 @@ class Builder
     use Macroable;
 
     // Select plugin constants.
-    const SELECT_STYLE_API = 'api';
+    final const SELECT_STYLE_API = 'api';
 
-    const SELECT_STYLE_SINGLE = 'single';
+    final const SELECT_STYLE_SINGLE = 'single';
 
-    const SELECT_STYLE_MULTI = 'multi';
+    final const SELECT_STYLE_MULTI = 'multi';
 
-    const SELECT_STYLE_OS = 'os';
+    final const SELECT_STYLE_OS = 'os';
 
-    const SELECT_STYLE_MULTI_SHIFT = 'multi+shift';
+    final const SELECT_STYLE_MULTI_SHIFT = 'multi+shift';
 
-    const SELECT_ITEMS_ROW = 'row';
+    final const SELECT_ITEMS_ROW = 'row';
 
-    const SELECT_ITEMS_COLUMN = 'column';
+    final const SELECT_ITEMS_COLUMN = 'column';
 
-    const SELECT_ITEMS_CELL = 'cell';
+    final const SELECT_ITEMS_CELL = 'cell';
 
     /**
      * The default type to use for the DataTables javascript.
@@ -53,7 +53,10 @@ class Builder
 
     protected string $template = '';
 
-    protected array $attributes = [];
+    protected array $attributes = [
+        'serverSide' => true,
+        'processing' => true,
+    ];
 
     protected string|array $ajax = '';
 
@@ -66,10 +69,6 @@ public function __construct(public Repository $config, public Factory $view, pub
 
         $this->collection = new Collection;
         $this->tableAttributes = $defaults;
-        $this->attributes = [
-            'serverSide' => true,
-            'processing' => true,
-        ];
     }
 
     /**

src/Html/Column.php

@@ -503,7 +503,7 @@ public function parseRender(mixed $value): ?string
             return $value($parameters);
         } elseif ($this->isBuiltInRenderFunction($value)) {
             return $value;
-        } elseif (strlen($value) < 256 && $view->exists($value)) {
+        } elseif (strlen((string) $value) < 256 && $view->exists($value)) {
             return $view->make($value)->with($parameters)->render();
         }
 

src/Html/Editor/Editor.php

@@ -24,15 +24,15 @@ class Editor extends Fluent
     use HasAuthorizations;
     use HasEvents;
 
-    const DISPLAY_LIGHTBOX = 'lightbox';
+    final const DISPLAY_LIGHTBOX = 'lightbox';
 
-    const DISPLAY_ENVELOPE = 'envelope';
+    final const DISPLAY_ENVELOPE = 'envelope';
 
-    const DISPLAY_BOOTSTRAP = 'bootstrap';
+    final const DISPLAY_BOOTSTRAP = 'bootstrap';
 
-    const DISPLAY_FOUNDATION = 'foundation';
+    final const DISPLAY_FOUNDATION = 'foundation';
 
-    const DISPLAY_JQUERYUI = 'jqueryui';
+    final const DISPLAY_JQUERYUI = 'jqueryui';
 
     public array $events = [];
 
@@ -43,6 +43,7 @@ class Editor extends Fluent
      */
     public function __construct($instance = 'editor')
     {
+        $attributes = [];
         $attributes['instance'] = $instance;
 
         parent::__construct($attributes);

src/Html/Editor/Fields/BelongsTo.php

@@ -19,7 +19,7 @@ public static function model(Builder|string $class, string $text, string $id = '
         }
 
         $table = Str::singular($table);
-        $foreign = $foreign ?? $table.'_id';
+        $foreign ??= $table.'_id';
 
         return self::make($foreign, Str::title($table))
             ->modelOptions($class, $text, $id);

src/Html/Editor/Fields/Field.php

@@ -31,7 +31,7 @@ class Field extends Fluent
      */
     public function __construct($attributes = [])
     {
-        $attributes['type'] = $attributes['type'] ?? $this->type;
+        $attributes['type'] ??= $this->type;
 
         parent::__construct($attributes);
     }

src/Html/Editor/Fields/Options.php

@@ -39,12 +39,10 @@ public static function model(string|EloquentBuilder $model, string $value, strin
             $model = $model::query();
         }
 
-        return $model->get()->map(function ($model) use ($value, $key) {
-            return [
-                'value' => $model->{$key},
-                'label' => $model->{$value},
-            ];
-        });
+        return $model->get()->map(fn($model) => [
+            'value' => $model->{$key},
+            'label' => $model->{$value},
+        ]);
     }
 
     /**
@@ -65,9 +63,7 @@ public static function table(
             $callback($query);
         }
 
-        return $query->get()->map(function ($row) {
-            return (array) $row;
-        });
+        return $query->get()->map(fn($row) => (array) $row);
     }
 
     /**

src/Html/Editor/Fields/Select2.php

@@ -84,7 +84,7 @@ public function ajaxData(array|string $data): static
         if (is_array($data)) {
             $script = 'function(params) {';
             foreach ($data as $key => $value) {
-                $value = json_encode($value);
+                $value = json_encode($value, JSON_THROW_ON_ERROR);
                 $script .= " params.$key = $value; ";
             }
             $script .= 'return params; }';

src/Html/HasTable.php

@@ -111,7 +111,7 @@ public function removeTableClass(array|string $class): static
         $currentClass = $this->getTableAttribute('class');
 
         $classes = array_diff(
-            (array) preg_split('#\s+#', $currentClass, -1, PREG_SPLIT_NO_EMPTY),
+            (array) preg_split('#\s+#', (string) $currentClass, -1, PREG_SPLIT_NO_EMPTY),
             (array) preg_split('#\s+#', $class, -1, PREG_SPLIT_NO_EMPTY)
         );
         $class = implode(' ', array_unique($classes));

src/Html/HtmlBuilder.php

@@ -8,23 +8,20 @@
 
 class HtmlBuilder
 {
-    /**
-     * The URL generator instance.
-     */
-    protected UrlGenerator $url;
-
-    /**
-     * The View Factory instance.
-     */
-    protected Factory $view;
-
     /**
      * Create a new HTML builder instance.
      */
-    public function __construct(UrlGenerator $url, Factory $view)
+    public function __construct(
+        /**
+         * The URL generator instance.
+         */
+        protected UrlGenerator $url,
+        /**
+         * The View Factory instance.
+         */
+        protected Factory $view
+    )
     {
-        $this->url = $url;
-        $this->view = $view;
     }
 
     /**