only accept post requests in hive for effectful http operations (#30038)

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

Author: vporyadke

ydb/core/kqp/ut/query/kqp_stats_ut.cpp

@@ -1,3 +1,4 @@
+#include <ydb/core/base/hive.h>
 #include <ydb/core/kqp/ut/common/kqp_ut_common.h>
 #include <ydb/core/kqp/counters/kqp_counters.h>
 #include <ydb/public/sdk/cpp/include/ydb-cpp-sdk/client/table/table.h>
@@ -665,7 +666,6 @@ Y_UNIT_TEST_TWIN(OneShardNonLocalExec, UseSink) {
     TKikimrRunner kikimr(TKikimrSettings(app).SetNodeCount(2));
     auto db = kikimr.GetTableClient();
     auto session = db.CreateSession().GetValueSync().GetSession();
-    auto monPort = kikimr.GetTestServer().GetRuntime()->GetMonPort();
 
     auto firstNodeId = kikimr.GetTestServer().GetRuntime()->GetFirstNodeId();
 
@@ -674,22 +674,15 @@ Y_UNIT_TEST_TWIN(OneShardNonLocalExec, UseSink) {
     auto expectedTotalSingleNodeReqCount = counters.TotalSingleNodeReqCount->Val();
     auto expectedNonLocalSingleNodeReqCount = counters.NonLocalSingleNodeReqCount->Val();
 
-    auto drainNode = [monPort](size_t nodeId, bool undrain = false) {
-        TNetworkAddress addr("localhost", monPort);
-        TSocket s(addr);
-        TString url;
+    auto drainNode = [runtime = kikimr.GetTestServer().GetRuntime()](size_t nodeId, bool undrain = false) {
+        auto sender = runtime->AllocateEdgeActor();
+        IEventBase* ev = nullptr;
         if (undrain) {
-            url = "/tablets/app?TabletID=72057594037968897&node=" + std::to_string(nodeId) + "&page=SetDown&down=0";
+            ev = new TEvHive::TEvSetDown(nodeId, false);
         } else {
-            url = "/tablets/app?TabletID=72057594037968897&node=" + std::to_string(nodeId) + "&page=DrainNode";
+            ev = new TEvHive::TEvDrainNode(nodeId);
         }
-        SendMinimalHttpRequest(s, "localhost", url);
-        TSocketInput si(s);
-        THttpInput input(&si);
-        TString firstLine = input.FirstLine();
-
-        const auto httpCode = ParseHttpRetCode(firstLine);
-        UNIT_ASSERT_VALUES_EQUAL(httpCode, 200);
+        runtime->SendToPipe(72057594037968897, sender, ev, 0, GetPipeConfigWithRetries());
     };
 
     auto waitTablets = [&session](size_t nodeId) mutable {
@@ -700,7 +693,7 @@ Y_UNIT_TEST_TWIN(OneShardNonLocalExec, UseSink) {
                 .WithShardNodesInfo(true);
 
         bool done = false;
-        for (int i = 0; i < 10; i++) {
+        for (int i = 0; i < 5; i++) {
             std::unordered_set<ui32> nodeIds;
             auto res = session.DescribeTable("Root/EightShard", describeTableSettings)
                 .ExtractValueSync();
@@ -716,7 +709,7 @@ Y_UNIT_TEST_TWIN(OneShardNonLocalExec, UseSink) {
                 done = true;
                 break;
             }
-            Sleep(TDuration::Seconds(1));
+            Sleep(TDuration::Seconds(5));
         }
         UNIT_ASSERT_C(done, "unable to wait tablets move on specific node");
     };

ydb/core/mind/hive/hive_ut.cpp

@@ -7838,7 +7838,7 @@ Y_UNIT_TEST_SUITE(THiveTest) {
 
         {
             NActorsProto::TRemoteHttpInfo pb;
-            pb.SetMethod(HTTP_METHOD_GET);
+            pb.SetMethod(HTTP_METHOD_POST);
             pb.SetPath("/app");
             auto* p1 = pb.AddQueryParams();
             p1->SetKey("TabletID");
@@ -7866,7 +7866,7 @@ Y_UNIT_TEST_SUITE(THiveTest) {
 
         {
             NActorsProto::TRemoteHttpInfo pb;
-            pb.SetMethod(HTTP_METHOD_GET);
+            pb.SetMethod(HTTP_METHOD_POST);
             pb.SetPath("/app");
             auto* p1 = pb.AddQueryParams();
             p1->SetKey("TabletID");
@@ -7914,7 +7914,7 @@ Y_UNIT_TEST_SUITE(THiveTest) {
         }
         {
             NActorsProto::TRemoteHttpInfo pb;
-            pb.SetMethod(HTTP_METHOD_GET);
+            pb.SetMethod(HTTP_METHOD_POST);
             pb.SetPath("/app");
             auto* p1 = pb.AddQueryParams();
             p1->SetKey("TabletID");
@@ -7943,7 +7943,7 @@ Y_UNIT_TEST_SUITE(THiveTest) {
 
         {
             NActorsProto::TRemoteHttpInfo pb;
-            pb.SetMethod(HTTP_METHOD_GET);
+            pb.SetMethod(HTTP_METHOD_POST);
             pb.SetPath("/app");
             auto* p1 = pb.AddQueryParams();
             p1->SetKey("TabletID");

ydb/core/mind/hive/monitoring.cpp

@@ -18,5 +18,7 @@ class TLoggedMonTransaction {
     void WriteOperation(NIceDb::TNiceDb& db, const NJson::TJsonValue& op);
 };
 
+TCgiParameters GetParams(const NMon::TEvRemoteHttpInfo* ev);
+
 }
 }

ydb/core/mind/hive/monitoring.h

@@ -3120,9 +3120,10 @@ namespace Tests {
         return FlatQuery(runtime, mkql, opts, result);
     }
 
-    TString TClient::SendTabletMonQuery(TTestActorRuntime* runtime, ui64 tabletId, TString query) {
+    template <typename... TArgs>
+    TString TClient::SendTabletMonQuery(TTestActorRuntime* runtime, ui64 tabletId, TArgs&&... args) {
         TActorId sender = runtime->AllocateEdgeActor(0);
-        ForwardToTablet(*runtime, tabletId, sender, new NActors::NMon::TEvRemoteHttpInfo(query), 0);
+        ForwardToTablet(*runtime, tabletId, sender, new NActors::NMon::TEvRemoteHttpInfo(args...), 0);
         TAutoPtr<IEventHandle> handle;
         // Timeout for DEBUG purposes only
         runtime->GrabEdgeEvent<NMon::TEvRemoteJsonInfoRes>(handle);
@@ -3136,7 +3137,7 @@ namespace Tests {
         ui64 hive = ChangeStateStorage(Tests::Hive, Domain);
         TInstant deadline = TInstant::Now() + TIMEOUT;
         while (TInstant::Now() <= deadline) {
-            TString res = SendTabletMonQuery(runtime, hive, TString("/app?page=SetDown&node=") + ToString(nodeId) + "&down=" + (up ? "0" : "1"));
+            TString res = SendTabletMonQuery(runtime, hive, TString("/app?page=SetDown&node=") + ToString(nodeId) + "&down=" + (up ? "0" : "1"), HTTP_METHOD_POST);
             if (!res.empty() && !res.Contains("Error"))
                 return res;
 
@@ -3148,7 +3149,7 @@ namespace Tests {
     TString TClient::KickNodeInHive(TTestActorRuntime* runtime, ui32 nodeIdx) {
         ui32 nodeId = runtime->GetNodeId(nodeIdx);
         ui64 hive = ChangeStateStorage(Tests::Hive, Domain);
-        return SendTabletMonQuery(runtime, hive, TString("/app?page=KickNode&node=") + ToString(nodeId));
+        return SendTabletMonQuery(runtime, hive, TString("/app?page=KickNode&node=") + ToString(nodeId), HTTP_METHOD_POST);
     }
 
     bool TClient::WaitForTabletAlive(TTestActorRuntime* runtime, ui64 tabletId, bool leader, TDuration timeout) {

ydb/core/testlib/test_client.cpp

@@ -708,7 +708,8 @@ namespace Tests {
         TAutoPtr<NMsgBusProxy::TBusResponse> HiveCreateTablet(ui32 domainUid, ui64 owner, ui64 owner_index, TTabletTypes::EType tablet_type,
                 const TVector<ui32>& allowed_node_ids, const TVector<TSubDomainKey>& allowed_domains = {}, const TChannelsBindings& binding = {});
 
-        TString SendTabletMonQuery(TTestActorRuntime* runtime, ui64 tabletId, TString query);
+        template <typename... TArgs>
+        TString SendTabletMonQuery(TTestActorRuntime* runtime, ui64 tabletId, TArgs&&... args);
         TString MarkNodeInHive(TTestActorRuntime* runtime, ui32 nodeIdx, bool up);
         TString KickNodeInHive(TTestActorRuntime* runtime, ui32 nodeIdx);
         bool WaitForTabletAlive(TTestActorRuntime* runtime, ui64 tabletId, bool leader, TDuration timeout);

ydb/core/testlib/test_client.h

@@ -1510,31 +1510,31 @@ def test_security(cls):
             'Cookie': 'ydb_session_id=' + cls.database_session_id,
         })
 
-        result['down_node_root'] = cls.get_viewer("/tablets/app", params={
+        result['down_node_root'] = cls.post_viewer("/tablets/app", params={
             'TabletID': '72057594037968897',
             'page': 'SetDown',
             'node': '1',
             'down': '0',
         }, headers={
             'Cookie': 'ydb_session_id=' + cls.root_session_id,
         })
-        result['down_node_monitoring'] = cls.get_viewer("/tablets/app", params={
+        result['down_node_monitoring'] = cls.post_viewer("/tablets/app", params={
             'TabletID': '72057594037968897',
             'page': 'SetDown',
             'node': '1',
             'down': '0',
         }, headers={
             'Cookie': 'ydb_session_id=' + cls.monitoring_session_id,
         })
-        result['down_node_viewer'] = cls.get_viewer("/tablets/app", params={
+        result['down_node_viewer'] = cls.post_viewer("/tablets/app", params={
             'TabletID': '72057594037968897',
             'page': 'SetDown',
             'node': '1',
             'down': '0',
         }, headers={
             'Cookie': 'ydb_session_id=' + cls.viewer_session_id,
         })
-        result['down_node_database'] = cls.get_viewer("/tablets/app", params={
+        result['down_node_database'] = cls.post_viewer("/tablets/app", params={
             'TabletID': '72057594037968897',
             'page': 'SetDown',
             'node': '1',

ydb/core/viewer/tests/test.py

@@ -2,7 +2,7 @@
 import json
 import logging
 
-from six.moves.urllib.request import urlopen
+from six.moves.urllib.request import urlopen, Request
 from six.moves.urllib.parse import urlencode
 
 logger = logging.getLogger()
@@ -20,12 +20,12 @@ def __init__(self, server, mon_port, hive_id=DEFAULT_HIVE_ID):
             hive_id=self.__hive_id
         )
 
-    def __get(self, url, timeout):
-        u = urlopen(url, timeout=TIMEOUT)
+    def __post(self, url, timeout):
+        u = urlopen(Request(url, method='POST'), timeout=TIMEOUT)
         u.read()
 
     def rebalance_all_tablets(self):
-        self.__get(
+        self.__post(
             self.__url + '&page=Rebalance',
             timeout=TIMEOUT
         )
@@ -39,7 +39,7 @@ def change_tablet_group(self, tablet_id, channels=()):
         if channels:
             url_lst.append('channel=' + ','.join(map(str, channels)))
 
-        self.__get('&'.join(url_lst), timeout=TIMEOUT)
+        self.__post('&'.join(url_lst), timeout=TIMEOUT)
 
     def change_tablet_group_by_tablet_type(self, tablet_type, percent=None, channels=()):
         url_lst = [
@@ -53,17 +53,17 @@ def change_tablet_group_by_tablet_type(self, tablet_type, percent=None, channels
             )
         if channels:
             url_lst.append('channel=' + ','.join(map(str, channels)))
-        self.__get('&'.join(url_lst), timeout=TIMEOUT)
+        self.__post('&'.join(url_lst), timeout=TIMEOUT)
 
     def kick_tablets_from_node(self, node_id):
-        self.__get(
+        self.__post(
             self.__url + "&page=KickNode&node={node}".format(node=node_id),
             timeout=TIMEOUT
         )
 
     def block_node(self, node_id, block=True):
         block = '1' if block else '0'
-        self.__get(
+        self.__post(
             self.__url + "&page=SetDown&node={node}&down={down}".format(node=node_id, down=block),
             timeout=TIMEOUT
         )
@@ -72,7 +72,7 @@ def unblock_node(self, node_id):
         self.block_node(node_id, block=False)
 
     def change_tablet_weight(self, tablet_id, tablet_weight):
-        self.__get(
+        self.__post(
             self.__url + "&page=UpdateResources&tablet={tablet}&kv={size}".format(
                 tablet=tablet_id,
                 size=tablet_weight
@@ -81,7 +81,7 @@ def change_tablet_weight(self, tablet_id, tablet_weight):
         )
 
     def change_tablet_cpu_usage(self, tablet_id, cpu_usage):
-        self.__get(
+        self.__post(
             self.__url + "&page=UpdateResources&tablet={tablet}&cpu={size}".format(
                 tablet=tablet_id,
                 size=cpu_usage
@@ -93,21 +93,21 @@ def set_min_scatter_to_balance(self, min_scatter_to_balance=101):
         """
         min_scatter_to_balance=101 -- effectively disables auto rebalancing
         """
-        self.__get(
+        self.__post(
             self.__url + "&page=Settings&minScatterToBalance={min_scatter_to_balance}".format(
                 min_scatter_to_balance=min_scatter_to_balance), timeout=TIMEOUT
         )
 
     def set_max_scheduled_tablets(self, max_scheduled_tablets=10):
-        self.__get(
+        self.__post(
             self.__url + "&page=Settings&maxScheduledTablets={max_scheduled_tablets}".format(
                 max_scheduled_tablets=max_scheduled_tablets
             ),
             timeout=TIMEOUT
         )
 
     def set_max_boot_batch_size(self, max_boot_batch_size=10):
-        self.__get(
+        self.__post(
             self.__url + "&page=Settings&maxBootBatchSize={max_boot_batch_size}".format(
                 max_boot_batch_size=max_boot_batch_size
             ),

ydb/tests/library/clients/kikimr_http_client.py

@@ -624,12 +624,12 @@ def _kick_tablets_from_node(self, node_index):
         mon_port = self._get_mon_port(0)
 
         toggle_down_url = 'http://localhost:{}/tablets/app?TabletID=72057594037968897&node={}&page=SetDown&down=1'.format(mon_port, node_index + 1)
-        toggle_down_reply = requests.get(toggle_down_url)
+        toggle_down_reply = requests.post(toggle_down_url)
         assert_that(toggle_down_reply.status_code, equal_to(200))
         logging.debug('Toggle down reply: {}'.format(toggle_down_reply.text))
 
         kick_url = 'http://localhost:{}/tablets/app?TabletID=72057594037968897&node={}&page=KickNode'.format(mon_port, node_index + 1)
-        kick_reply = requests.get(kick_url)
+        kick_reply = requests.post(kick_url)
         assert_that(kick_reply.status_code, equal_to(200))
         logging.debug('Kick reply: {}'.format(kick_reply.text))
 
@@ -644,7 +644,7 @@ def _enable_tablets_on_node(self, node_index):
             try:
                 mon_port = self._get_mon_port(0)
                 toggle_up_url = 'http://localhost:{}/tablets/app?TabletID=72057594037968897&node={}&page=SetDown&down=0'.format(mon_port, node_index + 1)
-                toggle_up_reply = requests.get(toggle_up_url)
+                toggle_up_reply = requests.post(toggle_up_url)
 
                 logging.debug('Toggle up reply: {}'.format(toggle_up_reply.text))
                 if toggle_up_reply.status_code != 200 and attempts: