Skip to content

Commit f4ecb96

Browse files
authored
Fix linker error on macOS (#2299)
1 parent c237642 commit f4ecb96

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,14 +269,16 @@ target_include_directories(${PROJECT_NAME} SYSTEM ${_INTERFACE_OR_PUBLIC}
269269
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
270270
)
271271

272-
# Always require threads
273272
target_link_libraries(${PROJECT_NAME} ${_INTERFACE_OR_PUBLIC}
273+
# Always require threads
274274
Threads::Threads
275275
# Needed for Windows libs on Mingw, as the pragma comment(lib, "xyz") aren't triggered.
276276
$<$<PLATFORM_ID:Windows>:ws2_32>
277277
$<$<PLATFORM_ID:Windows>:crypt32>
278278
# Needed for API from MacOS Security framework
279279
"$<$<AND:$<PLATFORM_ID:Darwin>,$<BOOL:${HTTPLIB_IS_USING_OPENSSL}>,$<BOOL:${HTTPLIB_USE_CERTS_FROM_MACOSX_KEYCHAIN}>>:-framework CoreFoundation -framework Security>"
280+
# Needed for non-blocking getaddrinfo on MacOS
281+
"$<$<AND:$<PLATFORM_ID:Darwin>,$<BOOL:${HTTPLIB_USE_NON_BLOCKING_GETADDRINFO}>>:-framework CFNetwork>"
280282
# Can't put multiple targets in a single generator expression or it bugs out.
281283
$<$<BOOL:${HTTPLIB_IS_USING_BROTLI}>:Brotli::common>
282284
$<$<BOOL:${HTTPLIB_IS_USING_BROTLI}>:Brotli::encoder>

0 commit comments

Comments
 (0)