feat: add methodSnippets.replaceArguments (powerful way to customize methodSnippets)

Author: zardoy

src/configurationType.ts

@@ -354,6 +354,21 @@ export type Configuration = {
      * @default pick-first
      */
     'methodSnippets.multipleSignatures': 'pick-first' | 'empty' /* DON'T SEE A NEED TO IMPLEMENT: | 'pick-longest'  | 'pick-shortest' */
+    /**
+     * Use empty string for tabstop, `null` to remove argument
+     * In replace string use `$` to insert tabstop and `\$` to insert `$`
+     *
+     * Examples:
+     * ```json
+     * "listener": "() => $",
+     * "eventName": "'$'"
+     * "thisArg": null
+     * ```
+     * @default {}
+     */
+    'methodSnippets.replaceArguments': {
+        [argumentName: string]: string | null
+    }
     /**
      * Wether to disable our and builtin method snippets within jsx attributes
      * @default true

src/onCompletionAccepted.ts

@@ -12,6 +12,7 @@ export default (tsApi: { onCompletionAccepted }) => {
     let justAcceptedReturnKeywordSuggestion = false
     let onCompletionAcceptedOverride: ((item: any) => void) | undefined
 
+    // eslint-disable-next-line complexity
     tsApi.onCompletionAccepted(async (item: vscode.CompletionItem & { document: vscode.TextDocument }) => {
         if (onCompletionAcceptedOverride) {
             onCompletionAcceptedOverride(item)
@@ -45,11 +46,27 @@ export default (tsApi: { onCompletionAccepted }) => {
                 inFlightMethodSnippetOperation = controller
                 const params: RequestResponseTypes['getFullMethodSnippet'] | undefined = await sendCommand('getFullMethodSnippet')
                 if (!controller.signal.aborted && params) {
+                    const replaceArguments = getExtensionSetting('methodSnippets.replaceArguments')
+
                     const snippet = new vscode.SnippetString('')
                     snippet.appendText('(')
-                    // todo maybe when have skipped, add a way to leave trailing , (previous behavior)
+                    // todo maybe when have optional (skipped), add a way to leave trailing , with tabstop (previous behavior)
                     for (const [i, param] of params.entries()) {
-                        snippet.appendPlaceholder(param)
+                        const replacer = replaceArguments[param.replace(/\?$/, '')]
+                        if (replacer === null) continue
+                        if (replacer) {
+                            snippet.appendPlaceholder(inner => {
+                                // eslint-disable-next-line unicorn/no-array-for-each
+                                replacer.split(/(?<!\\)\$/g).forEach((text, i, arr) => {
+                                    // inner.appendText(text.replace(/\\\$/g, '$'))
+                                    inner.value += text
+                                    if (i !== arr.length - 1) inner.appendTabstop()
+                                })
+                            })
+                        } else {
+                            snippet.appendPlaceholder(param)
+                        }
+
                         if (i !== params.length - 1) snippet.appendText(', ')
                     }
 

typescript/src/constructMethodSnippet.ts

@@ -60,6 +60,7 @@ export default (languageService: ts.LanguageService, sourceFile: ts.SourceFile,
     const allFiltered = paramsToInsert.length === 0 && parameters.length > paramsToInsert.length
     if (allFiltered) return ['']
 
+    // methodSnippets.replaceArguments is processed with last stage in onCompletionAccepted
     return paramsToInsert
     // return `(${paramsToInsert.map((param, i) => `\${${i + 1}:${param.replaceAll}}`).join(', ')})`