Skip to content

Commit 4b9cb1e

Browse files
committed
method snippets: add tabstop on many signature
fix eslint
1 parent f2a83cc commit 4b9cb1e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/onCompletionAccepted.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export default (tsApi: { onCompletionAccepted }) => {
6262
for (const [i, { insertText, name }] of parameters.entries()) {
6363
const isRest = insertText.startsWith('...')
6464
let text: string
65-
// eslint-disable-next-line default-case, @typescript-eslint/switch-exhaustiveness-check
65+
// eslint-disable-next-line default-case
6666
switch (insertMode) {
6767
case 'always-name':
6868
text = name
@@ -81,7 +81,8 @@ export default (tsApi: { onCompletionAccepted }) => {
8181
}
8282

8383
const allFiltered = data.parameters.length > parameters.length
84-
if (allFiltered) snippet.appendTabstop()
84+
// TODO when many, but at least one not empty
85+
if (allFiltered || data.hasManySignatures) snippet.appendTabstop()
8586

8687
snippet.appendText(')')
8788
void editor.insertSnippet(snippet, undefined, {

0 commit comments

Comments
 (0)