fix: rename settings: jsxEmmet and jsxPseudoEmmet to fix default values collision

feat: Add new settings auto-migration functionality, it won't harm!

Author: zardoy

.vscode/settings.json

@@ -14,5 +14,8 @@
                 ],
             }
         }
+    ],
+    "githubPullRequests.ignoredPullRequestBranches": [
+        "develop"
     ]
 }

src/configurationType.ts

@@ -120,10 +120,10 @@ export type Configuration = {
     'removeCodeFixes.codefixes': ('fixMissingMember' | 'fixMissingProperties' | 'fixMissingAttributes' | 'fixMissingFunctionDeclaration')[]
     /**
      * Use full-blown emmet in jsx/tsx files!
-     * Requires `jsxPseudoEmmet` be off and `emmet.excludeLanguages` to have `javascriptreact` and `typescriptreact`
+     * Requires `jsxPseudoEmmet.enabled` to be disabled and `emmet.excludeLanguages` to have `javascriptreact` and `typescriptreact`
      * @default true
      * */
-    jsxEmmet: boolean
+    'jsxEmmet.enable': boolean
     /**
      * Override snippet inserted on `.` literally
      * @default false
@@ -141,7 +141,7 @@ export type Configuration = {
      * Suggests only common tags such as div
      * @default false
      */
-    jsxPseudoEmmet: boolean
+    'jsxPseudoEmmet.enable': boolean
     /**
      * Note: Sorting matters
      */

src/emmet.ts

@@ -19,13 +19,13 @@ export const registerEmmet = async () => {
             reactLangs,
             {
                 async provideCompletionItems(document, position, token, context) {
-                    if (!getExtensionSetting('jsxEmmet')) return
+                    if (!getExtensionSetting('jsxEmmet.enable')) return
                     const emmetConfig = vscode.workspace.getConfiguration('emmet')
                     if (isEmmetEnabled && !emmetConfig.excludeLanguages.includes(document.languageId)) return
 
                     const result = await sendCommand<EmmetResult>('emmet-completions', { document, position })
                     if (!result) return
-                    const offset = document.offsetAt(position)
+                    const offset: number = document.offsetAt(position)
                     const sendToEmmet = document.getText().slice(offset + result.emmetTextOffset, offset)
                     const emmetCompletions = emmet.doComplete(
                         {

src/extension.ts

@@ -2,14 +2,15 @@
 import * as vscode from 'vscode'
 import { defaultJsSupersetLangs } from '@zardoy/vscode-utils/build/langs'
 import { getActiveRegularEditor } from '@zardoy/vscode-utils'
-import { extensionCtx, getExtensionSettingId, getExtensionCommandId, registerActiveDevelopmentCommand } from 'vscode-framework'
+import { extensionCtx, getExtensionSettingId, getExtensionCommandId } from 'vscode-framework'
 import { pickObj } from '@zardoy/utils'
 import { TriggerCharacterCommand } from '../typescript/src/ipcTypes'
 import { Configuration } from './configurationType'
 import webImports from './webImports'
 import { sendCommand } from './sendCommand'
 import { registerEmmet } from './emmet'
 import experimentalPostfixes from './experimentalPostfixes'
+import migrateSettings from './migrateSettings'
 
 export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted }) => {
     let webWaitingForConfigSync = false
@@ -121,6 +122,8 @@ export const activateTsPlugin = (tsApi: { configurePlugin; onCompletionAccepted
 }
 
 export const activate = async () => {
+    migrateSettings()
+
     const possiblyActivateTsPlugin = async () => {
         const tsExtension = vscode.extensions.getExtension('vscode.typescript-language-features')
         if (!tsExtension) return

src/migrateSettings.ts

@@ -0,0 +1,23 @@
+import { migrateExtensionSettings } from '../../vscode-utils/build/migrateSettings'
+
+export default () => {
+    void migrateExtensionSettings(
+        [
+            {
+                rename: {
+                    old: 'jsxEmmet',
+                    new: 'jsxEmmet.enable',
+                    mustBePrimitive: true,
+                },
+            },
+            {
+                rename: {
+                    old: 'jsxPseudoEmmet',
+                    new: 'jsxPseudoEmmet.enable',
+                    mustBePrimitive: true,
+                },
+            },
+        ],
+        process.env.IDS_PREFIX!,
+    )
+}

typescript/src/completionsAtPosition.ts

@@ -70,7 +70,7 @@ export const getCompletionsAtPosition = (
 
             // #region Fake emmet
             if (
-                c('jsxPseudoEmmet') &&
+                c('jsxPseudoEmmet.enable') &&
                 leftNode &&
                 prepareTextForEmmet(fileName, leftNode, sourceFile, position, languageService) !== false &&
                 ensurePrior() &&