update ts in project add tests for method snippets

improve perf of findChildNode
fix: escape $ in banned builtin positions
fix: don't expand method snippet (including builtin) in mroe places such as object expressions

Author: zardoy

package.json

@@ -47,7 +47,8 @@
         "fs-extra": "^10.1.0",
         "type-fest": "^2.13.1",
         "typed-jsonfile": "^0.2.1",
-        "typescript": "^4.5.4",
+        "typescript-old": "npm:typescript@4.5.4",
+        "typescript": "^4.8.3",
         "typescript-essential-plugins": "workspace:*",
         "vitest": "^0.15.1",
         "vscode-manifest": "^0.0.4"

pnpm-lock.yaml

@@ -4,7 +4,7 @@ import * as emmet from '@vscode/emmet-helper'
 import isInBannedPosition from './isInBannedPosition'
 import { GetConfig } from './types'
 import { findChildContainingPosition } from './utils'
-import { isGoodPositionBuiltinMethodCompletion } from './isGootPositionMethodCompletion'
+import { isGoodPositionBuiltinMethodCompletion } from './isGoodPositionMethodCompletion'
 
 export type PrevCompletionMap = Record<string, { originalName?: string; documentationOverride?: string | tslib.SymbolDisplayPart[] }>
 

typescript/src/completionsAtPosition.ts

@@ -7,7 +7,7 @@ import _ from 'lodash'
 import { GetConfig } from './types'
 import { getCompletionsAtPosition, PrevCompletionMap } from './completionsAtPosition'
 import { oneOf } from '@zardoy/utils'
-import { isGoodPositionMethodCompletion } from './isGootPositionMethodCompletion'
+import { isGoodPositionMethodCompletion } from './isGoodPositionMethodCompletion'
 
 const thisPluginMarker = Symbol('__essentialPluginsMarker__')
 

typescript/src/index.ts

@@ -1,8 +1,9 @@
 import type tslib from 'typescript/lib/tsserverlibrary'
-import { findChildContainingPosition } from './utils'
+import { findChildContainingPosition, findChildContainingPositionMaxDepth } from './utils'
 
 export const isGoodPositionBuiltinMethodCompletion = (ts: typeof tslib, sourceFile: tslib.SourceFile, position: number) => {
-    const importClauseCandidate = findChildContainingPosition(ts, sourceFile, position, 2)
+    const importClauseCandidate = findChildContainingPositionMaxDepth(ts, sourceFile, position, 2)
+    console.log(sourceFile.getFullText().slice(0, position))
     if (importClauseCandidate?.kind === 266) return false
     const currentNode = findChildContainingPosition(ts, sourceFile, position)
     // const obj = { method() {}, arrow: () => {} }