feat: insertNameOfCompletion command that is useful to bind when suggest widget is visible to insert name instead of insertText of TS completion. Useful with "tsEssentialPlugins.objectLiteralCompletions.keepOriginal": "remove"

Author: zardoy

.vscode/settings.json

@@ -6,23 +6,8 @@
         }
     },
     "tsEssentialPlugins.suggestions.ignoreAutoImports": [
-        "typescript-full"
-    ],
-    "betterSnippets.customSnippets": [
-        {
-            "name": "SyntaxKind",
-            "body": "ts.SyntaxKind",
-            "when": {}
-        },
-        {
-            "name": "logKind",
-            "body": "console.log(ts.SyntaxKind[${1:node}!.kind])",
-            "when": {
-                "locations": [
-                    "lineStart"
-                ],
-            }
-        }
+        "typescript-full",
+        "@volar/language-service/*"
     ],
     "githubPullRequests.ignoredPullRequestBranches": [
         "develop"

package.json

@@ -50,6 +50,11 @@
                 "command": "goToNodeBySyntaxKindWithinSelection",
                 "title": "Go to Node by Syntax Kind Within Selection",
                 "category": "TS Essentials"
+            },
+            {
+                "command": "insertNameOfCompletion",
+                "title": "Insert Name of Completion",
+                "category": "TS Essentials"
             }
         ],
         "keybindings": [

src/specialCommands.ts

@@ -237,4 +237,12 @@ export default () => {
         })
         await vscode.commands.executeCommand(preview ? 'acceptRenameInputWithPreview' : 'acceptRenameInput')
     })
+
+    registerExtensionCommand('insertNameOfCompletion', async () => {
+        const editor = vscode.window.activeTextEditor
+        if (!editor) return
+        const result = await sendCommand<RequestResponseTypes['getLastResolvedCompletion']>('getLastResolvedCompletion')
+        if (!result) return
+        await editor.insertSnippet(new vscode.SnippetString().appendText(result.name))
+    })
 }

typescript/src/completionEntryDetails.ts

@@ -1,7 +1,12 @@
 import { PrevCompletionMap, PrevCompletionsAdditionalData } from './completionsAtPosition'
+import { RequestResponseTypes } from './ipcTypes'
 import namespaceAutoImports from './namespaceAutoImports'
 import { GetConfig } from './types'
 
+export const lastResolvedCompletion = {
+    value: undefined as undefined | RequestResponseTypes['getLastResolvedCompletion'],
+}
+
 export default function completionEntryDetails(
     inputArgs: Parameters<ts.LanguageService['getCompletionEntryDetails']>,
     languageService: ts.LanguageService,
@@ -10,6 +15,7 @@ export default function completionEntryDetails(
     prevCompletionsAdittionalData: PrevCompletionsAdditionalData,
 ): ts.CompletionEntryDetails | undefined {
     const [fileName, position, entryName, formatOptions, source, preferences, data] = inputArgs
+    lastResolvedCompletion.value = { name: entryName }
     const program = languageService.getProgram()
     const sourceFile = program?.getSourceFile(fileName)
     if (!program || !sourceFile) return

typescript/src/ipcTypes.ts

@@ -15,9 +15,10 @@ export const triggerCharacterCommands = [
     'acceptRenameWithParams',
     'getFullMethodSnippet',
     'getExtendedCodeActionEdits',
+    'getLastResolvedCompletion',
 ] as const
 
-export type TriggerCharacterCommand = (typeof triggerCharacterCommands)[number]
+export type TriggerCharacterCommand = typeof triggerCharacterCommands[number]
 
 export type NodeAtPositionResponse = {
     kindName: string
@@ -79,6 +80,9 @@ export type RequestResponseTypes = {
     getFixAllEdits: ts.TextChange[]
     getFullMethodSnippet: string[] | 'ambiguous' | undefined
     getExtendedCodeActionEdits: ApplyExtendedCodeActionResult
+    getLastResolvedCompletion: {
+        name: string
+    }
 }
 
 // INPUT

typescript/src/specialCommands/handle.ts

@@ -5,6 +5,7 @@ import { overrideRequestPreferences } from '../decorateProxy'
 import { NodeAtPositionResponse, RequestOptionsTypes, RequestResponseTypes, TriggerCharacterCommand, triggerCharacterCommands } from '../ipcTypes'
 import { GetConfig } from '../types'
 import { findChildContainingExactPosition, findChildContainingPosition, getNodePath } from '../utils'
+import { lastResolvedCompletion } from '../completionEntryDetails'
 import getEmmetCompletions from './emmet'
 import objectIntoArrayConverters from './objectIntoArrayConverters'
 
@@ -260,6 +261,9 @@ export default (
             nodesByKind: collectedNodes,
         } satisfies RequestResponseTypes['filterBySyntaxKind']
     }
+    if (specialCommand === 'getLastResolvedCompletion') {
+        return lastResolvedCompletion.value
+    }
 
     return null
 }

vscode-framework.config.js

@@ -15,7 +15,7 @@ const pipeline = promisify(stream.pipeline)
 /** @type {(keyof Config)[]} */
 const languageOveridableSettings = [
     'removeUselessFunctionProps.enable',
-    'removeOrMarkGlobalLibCompletions.action',
+    'globalLibCompletions.action',
     'disableUselessHighlighting',
     'suggestions.keywordsInsertText',
     'caseSensitiveCompletions',