Skip to content

Conversation

@tcheeric
Copy link
Collaborator

Description

This pull request includes the following changes:

  1. Mock Invoice Generation:

    • Enhanced the createInvoice method to generate a unique mock bolt11 invoice using a hex string derived from the current timestamp. This improves the mock server's response realism.
  2. Logging Improvements:

    • Added Lombok @Slf4j logging across phoenixd-rest, including requests, operations, and factory classes. This provides safe and meaningful log messages.
    • Included a logging guide and provided a simplelogger.properties file to make DEBUG logs visible by default.
  3. Version Bump:

    • Incremented the project's version to 0.1.4 and updated the CHANGELOG to reflect updates related to logging configuration.

Checklist

  • Code compiles correctly
  • All tests passing
  • Changes have been reviewed and approved
  • Documentation updated where needed
  • Version bumped if necessary

- Updated the createInvoice method to generate a unique mock bolt11 invoice
  using a hex string derived from the current time. This enhances the realism
  of the mock server's responses.
@github-actions
Copy link

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
AutoCloseable used without 'try'-with-resources 🔶 Warning 1
Simplifiable conditional expression 🔶 Warning 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@tcheeric tcheeric merged commit 10bda5b into develop Oct 21, 2025
4 of 5 checks passed
@tcheeric tcheeric deleted the release/0.1.4 branch October 21, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants