Skip to content

Conversation

Copy link

Copilot AI commented Nov 2, 2025

  • Extract duplicated Bech32 charset string to a class-level constant in MockLnServer.java
  • Update generateValidBolt11Invoice() to use the constant
  • Update calculateBech32Checksum() to use the constant
  • Build and test the changes to ensure no regressions
  • Clean up accidentally committed build artifacts

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: tcheeric <6341500+tcheeric@users.noreply.github.com>
@tcheeric tcheeric marked this pull request as ready for review November 2, 2025 21:36
@tcheeric tcheeric merged commit c3b735d into release/0.1.4 Nov 2, 2025
@tcheeric tcheeric deleted the copilot/sub-pr-57-again branch November 2, 2025 21:36
Copilot AI requested a review from tcheeric November 2, 2025 21:37
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

xyz/tcheeric/phoenixd/mock/MockLnServer.class
xyz/tcheeric/phoenixd/mock/Main.class

P1 Badge Remove build output from version control

The change introduces several files under phoenixd-* /target (e.g. compiled .class files and Maven status lists). These are generated by the build and will be rewritten every time mvn runs, causing noisy diffs and repository bloat. They should be deleted and ignored rather than committed so that future builds do not constantly modify tracked files.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants